From patchwork Mon Nov 5 00:25:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafael David Tinoco X-Patchwork-Id: 150128 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1991944ljp; Sun, 4 Nov 2018 16:25:47 -0800 (PST) X-Google-Smtp-Source: AJdET5fovsjCqnH0xOP5BhcYIZQ1oyLxehDqcucKsizzm4MVb0qMEWnE9MJJ8Q8KxNaACcoS6iTS X-Received: by 2002:a17:906:f04:: with SMTP id z4-v6mr7929584eji.106.1541377547108; Sun, 04 Nov 2018 16:25:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541377547; cv=none; d=google.com; s=arc-20160816; b=nAenkUiGnt4yeiv29y2fotwNcXluiKPJ0KtoFOi2BnQ7n+smx/vPmrdTh3HFClpQRj BdchrlEFS1JWPA2ma9JE7FowcutNOcQs9rhQYQm1N+EkG0kWA9oUGjCZ67mLPUD3XzGn toH9FL4iCLgfcJeP17IfsTBPjz8HSe2uswuCt5TiVhYalOIohpcuFufUAnyVpAEF4MXA FyXzK1fG0/qNZPMZE/pkPa4dx2ku2RIYJ+qBl4Rw1GbFjghDvO6HO6FaYhAn2tNwTc2/ wEpE/1vQqUSgHN7WJEu/D3XTOui1xticUh8haQxgJa3KqGL4bzAcV/Aj3MwvnuRPl8+B QSzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :cc:mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:delivered-to; bh=MwJZAMqEedGCgoGHnqsxOT3lspCW7RAytwOf6z2uY98=; b=diymAal6f8G25dWj+Zq6Y0JtoiABP4Fu7J7nA8cg1s1zKC9PzwgsheANKlythFlzmV kV8WpvrBbq9OO79Io1Gaf8SeSrlbZmojc6xIrpa29Eurj9wKRVztYZztW2P1kTQWgOOt 6ozQKJ7wxlA/sYD1ekCmGwmFn0m59nzp5DnBZkTJeGqLZ44C1+NaJybac5otb+YlPkY/ ihkgjdNsZqzFkIv92mijo9k6ZCAd0ymz+IlXHFhtrWNi6zbxsIrk6yk+9rElibcXgdTO 2IxS1K3tpPFfpAwdlsZWpYBR9wm1tutPEx5qQ0ftvB2f974Vd6BcjuCZx8tqkqR5C+T/ 1k0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eCx9tuRi; spf=pass (google.com: domain of ltp-bounces+patch=linaro.org@lists.linux.it designates 213.254.12.146 as permitted sender) smtp.mailfrom="ltp-bounces+patch=linaro.org@lists.linux.it"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from picard.linux.it (picard.linux.it. [213.254.12.146]) by mx.google.com with ESMTPS id r4-v6si8354955edy.231.2018.11.04.16.25.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Nov 2018 16:25:47 -0800 (PST) Received-SPF: pass (google.com: domain of ltp-bounces+patch=linaro.org@lists.linux.it designates 213.254.12.146 as permitted sender) client-ip=213.254.12.146; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eCx9tuRi; spf=pass (google.com: domain of ltp-bounces+patch=linaro.org@lists.linux.it designates 213.254.12.146 as permitted sender) smtp.mailfrom="ltp-bounces+patch=linaro.org@lists.linux.it"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B20BC3E7845 for ; Mon, 5 Nov 2018 01:25:46 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) by picard.linux.it (Postfix) with ESMTP id 0DB953E63A8 for ; Mon, 5 Nov 2018 01:25:42 +0100 (CET) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 9093510005EE for ; Mon, 5 Nov 2018 01:25:41 +0100 (CET) Received: by mail-qk1-x741.google.com with SMTP id n12so11969923qkh.11 for ; Sun, 04 Nov 2018 16:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kVBDFGXm2usm4msNjMVlMY3OwCo9PVIe4hRm2GGPWxE=; b=eCx9tuRitz81VFT5M/KMgYVRVEsad0WPU4mAAIV1YWoPnr1GFc06ImGAGlwK0hgU0w +t5VgO/xbawmlu9y5Zr8nDjoNhxZgW4hcdZEIAvO7eoUdpyu+kOlHmlaexlCt9xoUi/t km6ma5E7czSz2XnbEM/rMrTKXc3bF7FkWO+7c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kVBDFGXm2usm4msNjMVlMY3OwCo9PVIe4hRm2GGPWxE=; b=Ar03xCSqjn3PwVTAxwQRCx70BesSYhaGrGDz1uD5jQcVpbpUtWCgmIA+AyHxz+5QbK LvZr2EFKQlXd44nhhF1X8MTHhkTXWCjJemwUV+JLLJsh4GMYFRLLfjfEImeJ+1/FrUXi geDz4j+UFLzxiuMbzw3SnrkqMWUlvyTBPfAYp7+klmI0skzfY8rMFMTwpZX45JfdJCi6 omB6PFYngH85Ppifyv4fIiSaI1WtUTlgYkFSwirD7m6UTuBnJCck3zJvSsGd12fA10J8 AoqwH7f2NZaagHU4ET1RiAh9+jrkQwVRSS9bNCG3o2TUWSrdH7+hjbCgvXCdXFFgdwjF +fZg== X-Gm-Message-State: AGRZ1gJranFj2qStxLNCU74QSqORI+HWE22GtuXFctcmDl2xZH2l+XUj kWi9Y6WizeKhrD8NW73AyOwBdKhP0a00Zkf0 X-Received: by 2002:a0c:e58b:: with SMTP id t11mr19219218qvm.76.1541377540006; Sun, 04 Nov 2018 16:25:40 -0800 (PST) Received: from workstation.celeiro.br ([138.204.25.17]) by smtp.gmail.com with ESMTPSA id p31sm20658279qkh.86.2018.11.04.16.25.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Nov 2018 16:25:39 -0800 (PST) From: Rafael David Tinoco To: ltp@lists.linux.it Date: Sun, 4 Nov 2018 22:25:35 -0200 Message-Id: <20181105002536.29715-1-rafael.tinoco@linaro.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: References: MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.99.2 at in-4.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-4.smtp.seeweb.it Cc: rafael.tinoco@linaro.org Subject: [LTP] [PATCH v2 1/2] syscalls/fremovexattr: Add fremovexattr() tests X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+patch=linaro.org@lists.linux.it Sender: "ltp" Fixes: #276 Following the same logic and tests used to test removexattr() syscall, this commit implements tests for fremovexattr(). It only differs from removexattr() on the given arguments: using a file descriptor instead of the filename. Kernel has different entry points for both, with slightly different execution paths, mainly related to dealing with the passed file descriptor. Signed-off-by: Rafael David Tinoco --- runtest/syscalls | 3 + .../kernel/syscalls/fremovexattr/.gitignore | 2 + .../kernel/syscalls/fremovexattr/Makefile | 8 ++ .../syscalls/fremovexattr/fremovexattr01.c | 106 ++++++++++++++ .../syscalls/fremovexattr/fremovexattr02.c | 130 ++++++++++++++++++ 5 files changed, 249 insertions(+) create mode 100644 testcases/kernel/syscalls/fremovexattr/.gitignore create mode 100644 testcases/kernel/syscalls/fremovexattr/Makefile create mode 100644 testcases/kernel/syscalls/fremovexattr/fremovexattr01.c create mode 100644 testcases/kernel/syscalls/fremovexattr/fremovexattr02.c diff --git a/runtest/syscalls b/runtest/syscalls index 2ac9f7665..c48ada707 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -319,6 +319,9 @@ fork14 fork14 fpathconf01 fpathconf01 +fremovexattr01 fremovexattr01 +fremovexattr02 fremovexattr02 + fstat01 fstat01 fstat01_64 fstat01_64 fstat02 fstat02 diff --git a/testcases/kernel/syscalls/fremovexattr/.gitignore b/testcases/kernel/syscalls/fremovexattr/.gitignore new file mode 100644 index 000000000..455a9db2e --- /dev/null +++ b/testcases/kernel/syscalls/fremovexattr/.gitignore @@ -0,0 +1,2 @@ +fremovexattr01 +fremovexattr02 diff --git a/testcases/kernel/syscalls/fremovexattr/Makefile b/testcases/kernel/syscalls/fremovexattr/Makefile new file mode 100644 index 000000000..f71e4fc25 --- /dev/null +++ b/testcases/kernel/syscalls/fremovexattr/Makefile @@ -0,0 +1,8 @@ +# Copyright (c) 2018 - Linaro Limited. All rights reserved. +# SPDX-License-Identifier: GPL-2.0-or-later + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +include $(top_srcdir)/include/mk/generic_leaf_target.mk \ No newline at end of file diff --git a/testcases/kernel/syscalls/fremovexattr/fremovexattr01.c b/testcases/kernel/syscalls/fremovexattr/fremovexattr01.c new file mode 100644 index 000000000..543016f01 --- /dev/null +++ b/testcases/kernel/syscalls/fremovexattr/fremovexattr01.c @@ -0,0 +1,106 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2018 Linaro Limited. All rights reserved. + * Author: Rafael David Tinoco + */ + +/* + * Test Name: fremovexattr01 + * + * Description: + * Like removexattr(2), fremovexattr(2) also removes an extended attribute, + * identified by a name, from a file but, instead of using a filename path, it + * uses a descriptor. This test verifies that a simple call to fremovexattr(2) + * removes, indeed, a previously set attribute key/value from a file. + */ + +#include "config.h" +#include +#include + +#ifdef HAVE_SYS_XATTR_H +# include +#endif + +#include "tst_test.h" + +#ifdef HAVE_SYS_XATTR_H + +#define ENOATTR ENODATA + +#define XATTR_TEST_KEY "user.testkey" +#define XATTR_TEST_VALUE "this is a test value" +#define XATTR_TEST_VALUE_SIZE 20 + +#define MNTPOINT "mntpoint" +#define FNAME MNTPOINT"/fremovexattr01testfile" + +static int fd = -1; +static char *got_value; + +static void verify_fremovexattr(void) +{ + SAFE_FSETXATTR(fd, XATTR_TEST_KEY, XATTR_TEST_VALUE, + XATTR_TEST_VALUE_SIZE, XATTR_CREATE); + + TEST(fremovexattr(fd, XATTR_TEST_KEY)); + + if (TST_RET != 0) { + tst_res(TFAIL | TTERRNO, "fremovexattr(2) failed"); + return; + } + + memset(got_value, 0, XATTR_TEST_VALUE_SIZE); + + TEST(fgetxattr(fd, XATTR_TEST_KEY, got_value, XATTR_TEST_VALUE_SIZE)); + + if (TST_RET >= 0) { + tst_res(TFAIL, "fremovexattr(2) did not remove attribute"); + return; + } + + if (TST_RET < 0 && TST_ERR != ENOATTR) { + tst_brk(TBROK, "fremovexattr(2) could not verify removal"); + return; + } + + tst_res(TPASS, "fremovexattr(2) removed attribute as expected"); +} + +static void cleanup(void) +{ + free(got_value); + + close(fd); +} + +static void setup(void) +{ + SAFE_TOUCH(FNAME, 0644, NULL); + + fd = SAFE_OPEN(FNAME, O_RDWR, NULL); + + TEST(fremovexattr(fd, XATTR_TEST_KEY)); + + if (TST_RET == -1 && TST_ERR == EOPNOTSUPP) { + tst_brk(TCONF, "fremovexattr(2) not supported"); + return; + } + + got_value = SAFE_MALLOC(XATTR_TEST_VALUE_SIZE); +} + +static struct tst_test test = { + .setup = setup, + .test_all = verify_fremovexattr, + .cleanup = cleanup, + .mntpoint = MNTPOINT, + .mount_device = 1, + .all_filesystems = 1, + .needs_tmpdir = 1, + .needs_root = 1, +}; + +#else /* HAVE_SYS_XATTR_H */ +TST_TEST_TCONF(" does not exist"); +#endif diff --git a/testcases/kernel/syscalls/fremovexattr/fremovexattr02.c b/testcases/kernel/syscalls/fremovexattr/fremovexattr02.c new file mode 100644 index 000000000..5585b6abe --- /dev/null +++ b/testcases/kernel/syscalls/fremovexattr/fremovexattr02.c @@ -0,0 +1,130 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2018 Linaro Limited. All rights reserved. + * Author: Rafael David Tinoco + */ + +/* + * Test Name: fremovexattr02 + * + * Test cases:: + * 1) fremovexattr(2) fails if the named attribute does not exist. + * 2) fremovexattr(2) fails if file descriptor is not valid. + * 3) fremovexattr(2) fails if named attribute has an invalid address. + * + * Expected Results: + * fremovexattr(2) should return -1 and set errno to ENODATA. + * fremovexattr(2) should return -1 and set errno to EBADF. + * fremovexattr(2) should return -1 and set errno to EFAULT. + */ + +#include "config.h" +#include +#include +#include +#include + +#ifdef HAVE_SYS_XATTR_H +# include +#endif + +#include "tst_test.h" + +#ifdef HAVE_SYS_XATTR_H + +#define XATTR_TEST_KEY "user.testkey" + +#define MNTPOINT "mntpoint" +#define FNAME MNTPOINT"/fremovexattr02testfile" + +static int fd = -1; + +struct test_case { + int fd; + char *key; + char *value; + char *gotvalue; + int size; + int exp_ret; + int exp_err; +}; + +struct test_case tc[] = { + { /* case 1: attribute does not exist */ + .key = XATTR_TEST_KEY, + .exp_ret = -1, + .exp_err = ENODATA, + }, + { /* case 2: file descriptor is invalid */ + .fd = -1, + .key = XATTR_TEST_KEY, + .exp_ret = -1, + .exp_err = EBADF, + }, + { /* case 3: bad name attribute */ + .exp_ret = -1, + .exp_err = EFAULT, + }, +}; + +static void verify_fremovexattr(unsigned int i) +{ + TEST(fremovexattr(tc[i].fd, tc[i].key)); + + if (TST_RET == -1 && TST_ERR == EOPNOTSUPP) + tst_brk(TCONF, "fremovexattr(2) not supported"); + + if (tc[i].exp_ret == TST_RET) { + + if (tc[i].exp_err) { + if (tc[i].exp_err == TST_ERR) { + tst_res(TPASS, "fremovexattr(2) passed"); + return; + } + } else { + tst_res(TPASS, "fremovexattr(2) passed"); + return; + } + } + + tst_res(TFAIL | TTERRNO, "fremovexattr(2) failed"); +} + +static void cleanup(void) +{ + if (fd > 0) + SAFE_CLOSE(fd); +} + +static void setup(void) +{ + size_t i = 0; + + SAFE_TOUCH(FNAME, 0644, NULL); + fd = SAFE_OPEN(FNAME, O_RDWR, NULL); + + for (i = 0; i < ARRAY_SIZE(tc); i++) { + + if (tc[i].fd != -1) + tc[i].fd = fd; + + if (!tc[i].key && tc[i].exp_err == EFAULT) + tc[i].key = tst_get_bad_addr(cleanup); + } +} + +static struct tst_test test = { + .setup = setup, + .test = verify_fremovexattr, + .cleanup = cleanup, + .tcnt = ARRAY_SIZE(tc), + .mntpoint = MNTPOINT, + .mount_device = 1, + .all_filesystems = 1, + .needs_tmpdir = 1, + .needs_root = 1, +}; + +#else /* HAVE_SYS_XATTR_H */ +TST_TEST_TCONF(" does not exist"); +#endif