From patchwork Fri Oct 11 00:27:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 175898 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp42452ill; Thu, 10 Oct 2019 17:29:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxOPAqsWkyPP7vxIC4M8e0btWYqFKhpZDrjv86aO10xKdsl5w56a5AMn3qasQNsKsQAbx+6 X-Received: by 2002:a17:906:5e11:: with SMTP id n17mr11122058eju.302.1570753788995; Thu, 10 Oct 2019 17:29:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570753788; cv=none; d=google.com; s=arc-20160816; b=0FZef9k8M9JoCqUkf2pO9peyQzoS+Of6JnZrlUbEYT9Wf9Xx0bAPRYtHu9EhkgKJIW g2aZS+idCFcmbPyklITDXHwLTzaoovT+qaVbhw2OyKMcgo+ySEQlf7qu9OftKQv2CbP7 owr6+uvXo9aBhTppAKHkgMf5aIS3EklZVRA0qhRF/D3kjbC87k0k5dVprVFHYt/5GfrL rP7z55DK28zs7s5Uq14mjivslsNQj1j6UvjOCKg75ea4euRGUCYjQJtnmSpxShbiZ651 iXt+yrcXi8QqGaxuIqQNYQlq4mQvjxZct+L9izb7mKA9Ph+KVquUSqV+8dyZr2ofGGEl ZJ1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=rEOxUviEkcCW48fJxCH3+DMoe12h6LP7M/4uKtZsbx8=; b=w/C3YgCVJpNx2VOH/57y8INtpNsdLNPPcgLRsVaC0YylTDjMRxhS/bOZevll2nqi1L 8dSFB3WHL5Zo5d2FiSkEC1NPxbJho5Cvi6+ytDY6Hx7G/501TPO0NfR2ngCDZW1aK5Mk 8Xou/3W8vrQQr2CpWYg0Xf3/4psVlFjVRGgeq2n2kUWXz1fFcXcdojLPZH0qAQUIp1fR XnsxSDHDqjrdojlZ5wYzPMed97VCPB+NrbSWsa+IrSYZUFeCfz+tKHOGf4HClVzkEtpp NfufL6n2fwnVRW/DuumIIwEDm7dbgZOJuYce7o+y0NFi1fiy3CNtMc16Cb7cwRMsprNY GPow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iAsoVQsf; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f30si5192818ede.435.2019.10.10.17.29.48; Thu, 10 Oct 2019 17:29:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iAsoVQsf; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbfJKA3s (ORCPT + 8 others); Thu, 10 Oct 2019 20:29:48 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:44908 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727369AbfJKA2Z (ORCPT ); Thu, 10 Oct 2019 20:28:25 -0400 Received: by mail-lj1-f194.google.com with SMTP id m13so7989801ljj.11 for ; Thu, 10 Oct 2019 17:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=rEOxUviEkcCW48fJxCH3+DMoe12h6LP7M/4uKtZsbx8=; b=iAsoVQsfqYvDGQefSDs72eSXfctA8ou9qKor43CyO+fvRlLcBxhAkT+k9IgpVXaICJ kRjr8e/8uDi7Y9FOENx9GD2n8DKbgz4VmLfNlKSN3It8fQyg/R/r92ZCnng20zvOL5nE aHqeBAreNBQ3nj4FhEe1ntRsaP/5r65kyq88wbXfif2UmVCnOl2jKyJBBma/5+B9kdoT z7bW+tH/oOvSZ16Da6PINXm+KQzR2nUztMgY5uUhipADqMYIkgrIpkbp3JJJ/irrHkHl yqJ0RCTq6U10iy1qnw8K2rissPKQH6ef8c7WjcubOzGNsBpxeaqbbl/QTlZI3XsV/gKL +GHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rEOxUviEkcCW48fJxCH3+DMoe12h6LP7M/4uKtZsbx8=; b=qSc8gznnUAl5T6RUuhlJ7DQfHhYOKxQKvrbId/lidOWHFjqMf2g+to58MzFhPQxf2+ 1I390hUm4MSREi8rgjVF9EjPSEEwOsD4h+96FuHETQ4cO0nZvFrDKJ6d0smAcfnCP+9f pn5xokDzZwpHd0Ch+aYfdWrTKc+9mDEfJcB6BVtIEjM/ce8C0lClNYFGoh9j3SlUB3Rz gnmD11yvwEJIKmiTIk/H1NsW0SvGMR85MW9ysitSEoZCT0sKAjLJKWLsxSMWoc618+O8 ds7SlwPnzg1BWRitt7QVj1iSvh2BqMMIDXXI1s8drrz366HL9lYP8Wcdyw9h7mucX1CD OkLA== X-Gm-Message-State: APjAAAXK1dyErxKrhZIyQDQDt0/qWdWHvi4dLpkVQc3l6UTei56H9Cav 2yExr6rmjN57oRZ+ORK9BSe8SKCS3h4= X-Received: by 2002:a2e:584b:: with SMTP id x11mr8035721ljd.90.1570753701013; Thu, 10 Oct 2019 17:28:21 -0700 (PDT) Received: from localhost.localdomain (88-201-94-178.pool.ukrtel.net. [178.94.201.88]) by smtp.gmail.com with ESMTPSA id 126sm2367010lfh.45.2019.10.10.17.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 17:28:20 -0700 (PDT) From: Ivan Khoronzhuk To: ast@kernel.org, daniel@iogearbox.net, yhs@fb.com, davem@davemloft.net, jakub.kicinski@netronome.com, hawk@kernel.org, john.fastabend@gmail.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, clang-built-linux@googlegroups.com, ilias.apalodimas@linaro.org, sergei.shtylyov@cogentembedded.com, Ivan Khoronzhuk Subject: [PATCH v5 bpf-next 00/15] samples: bpf: improve/fix cross-compilation Date: Fri, 11 Oct 2019 03:27:53 +0300 Message-Id: <20191011002808.28206-1-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This series contains mainly fixes/improvements for cross-compilation but not only, tested for arm, arm64, and intended for any arch. Also verified on native build (not cross compilation) for x86_64 and arm, arm64. Initial RFC link: https://lkml.org/lkml/2019/8/29/1665 Prev. version: https://lkml.org/lkml/2019/10/9/1045 Besides the patches given here, the RFC also contains couple patches related to llvm clang arm: include: asm: swab: mask rev16 instruction for clang arm: include: asm: unified: mask .syntax unified for clang They are necessarily to verify arm 32 build. Also, couple more fixes were added but are not merged in bpf-next yet, they can be needed for verification/configuration steps, if not in your tree the fixes can be taken here: https://www.spinics.net/lists/netdev/msg601716.html https://www.spinics.net/lists/netdev/msg601714.html https://www.spinics.net/lists/linux-kbuild/msg23468.html Now, to build samples, SAMPLE_BPF should be enabled in config. The change touches not only cross-compilation and can have impact on other archs and build environments, so might be good idea to verify it in order to add appropriate changes, some warn options could be tuned also. All is tested on x86-64 with clang installed (has to be built containing targets for arm, arm64..., see llc --version, usually it's present already) Instructions to test native on x86_64 ================================================= Native build on x86_64 is done in usual way and shouldn't have difference except HOSTCC is now printed as CC wile building the samples. Instructions to test cross compilation on arm64 ================================================= #Toolchain used for test: gcc version 8.3.0 (GNU Toolchain for the A-profile Architecture 8.3-2019.03 (arm-rel-8.36)) # Get some arm64 FS, containing at least libelf I've used sdk for TI am65x got here: http://downloads.ti.com/processor-sdk-linux/esd/AM65X/latest/exports/\ ti-processor-sdk-linux-am65xx-evm-06.00.00.07-Linux-x86-Install.bin # Install this binary to some dir, say "sdk". # Configure kernel (use defconfig as no matter), but clean everything # before. make ARCH=arm64 -C tools/ clean make ARCH=arm64 -C samples/bpf clean make ARCH=arm64 clean make ARCH=arm64 defconfig # Enable SAMPLE_BPF and it's dependencies in config # The kernel version used in sdk doesn't correspond to checked one, # but for this verification only headers need to be syched, # so install them (can be enabled in config): make ARCH=arm64 headers_install # or on SDK if need keep them in sync (not necessarily to verify): make ARCH=arm64 INSTALL_HDR_PATH=/../sdk/\ ti-processor-sdk-linux-am65xx-evm-06.00.00.07/linux-devkit/sysroots/\ aarch64-linux/usr headers_install # Build samples make samples/bpf/ ARCH=arm64 CROSS_COMPILE="aarch64-linux-gnu-"\ SYSROOT="/../sdk/ti-processor-sdk-linux-am65xx-evm-06.00.00.07/\ linux-devkit/sysroots/aarch64-linux" Instructions to test cross compilation on arm ================================================= #Toolchains used for test: arm-linux-gnueabihf-gcc (Linaro GCC 7.2-2017.11) 7.2.1 20171011 or arm-linux-gnueabihf-gcc (GNU Toolchain for the A-profile Architecture 8.3-2019.03 \ (arm-rel-8.36)) 8.3.0 # Get some FS, I've used sdk for TI am52xx got here: http://downloads.ti.com/processor-sdk-linux/esd/AM57X/05_03_00_07/exports/\ ti-processor-sdk-linux-am57xx-evm-05.03.00.07-Linux-x86-Install.bin # Install this binary to some dir, say "sdk". # Configure kernel, but clean everything before. make ARCH=arm -C tools/ clean make ARCH=arm -C samples/bpf clean make ARCH=arm clean make ARCH=arm omap2plus_defconfig # The kernel version used in sdk doesn't correspond to checked one, but # headers only should be synched, # so install them (can be enabled in config): make ARCH=arm headers_install # or on SDK if need keep them in sync (not necessarily): make ARCH=arm INSTALL_HDR_PATH=/../sdk/\ ti-processor-sdk-linux-am57xx-evm-05.03.00.07/linux-devkit/sysroots/\ armv7ahf-neon-linux-gnueabi/usr headers_install # Build samples make samples/bpf/ ARCH=arm CROSS_COMPILE="arm-linux-gnueabihf-"\ SYSROOT="/../sdk/ti-processor-sdk-linux-am57xx-evm-05.03\ .00.07/linux-devkit/sysroots/armv7ahf-neon-linux-gnueabi" Based on bpf-next/master v5..v4: - any changes, only missed SOBs are added v4..v3: - renamed CLANG_EXTRA_CFLAGS on BPF_EXTRA_CFLAGS - used filter for ARCH_ARM_SELECTOR - omit "-fomit-frame-pointer" and use same flags for native and "cross" - used sample/bpf prefixes - use C instead of C++ compiler for test_libbpf target v3..v2: - renamed makefile.progs to makeifle.target, as more appropriate - left only __LINUX_ARM_ARCH__ for D options for arm - for host build - left options from KBUILD_HOST for compatibility reasons - split patch adding c/cxx/ld flags to libbpf by modules - moved readme change to separate patch - added patch setting options for cross-compile - fixed issue with option error for syscall_nrs.S, avoiding overlap for ccflags-y. v2..v1: - restructured patches order - split "samples: bpf: Makefile: base progs build on Makefile.progs" to make change more readable. It added couple nice extra patches. - removed redundant patch: "samples: bpf: Makefile: remove target for native build" - added fix: "samples: bpf: makefile: fix cookie_uid_helper_example obj build" - limited -D option filter only for arm - improved comments - added couple instructions to verify cross compilation for arm and arm64 arches based on TI am57xx and am65xx sdks. - corrected include a little order Ivan Khoronzhuk (15): samples/bpf: fix HDR_PROBE "echo" samples/bpf: fix cookie_uid_helper_example obj build samples/bpf: use --target from cross-compile samples/bpf: use own EXTRA_CFLAGS for clang commands samples/bpf: use __LINUX_ARM_ARCH__ selector for arm samples/bpf: drop unnecessarily inclusion for bpf_load samples/bpf: add makefile.target for separate CC target build samples/bpf: base target programs rules on Makefile.target samples/bpf: use own flags but not HOSTCFLAGS samples/bpf: use target CC environment for HDR_PROBE libbpf: don't use cxx to test_libpf target libbpf: add C/LDFLAGS to libbpf.so and test_libpf targets samples/bpf: provide C/LDFLAGS to libbpf samples/bpf: add sysroot support samples/bpf: add preparation steps and sysroot info to readme samples/bpf/Makefile | 164 ++++++++++-------- samples/bpf/Makefile.target | 75 ++++++++ samples/bpf/README.rst | 41 ++++- tools/lib/bpf/Makefile | 23 +-- .../bpf/{test_libbpf.cpp => test_libbpf.c} | 14 +- 5 files changed, 218 insertions(+), 99 deletions(-) create mode 100644 samples/bpf/Makefile.target rename tools/lib/bpf/{test_libbpf.cpp => test_libbpf.c} (61%) -- 2.17.1 Tested-by: Ilias Apalodimas