mbox series

[net-next,0/4] net: ipa: simplify endpoint programming

Message ID 20200702112537.347994-1-elder@linaro.org
Headers show
Series net: ipa: simplify endpoint programming | expand

Message

Alex Elder July 2, 2020, 11:25 a.m. UTC 
Add tests to functions so they don't update undefined endpoint
registers, rather than requiring the caller to avoid calling them.

Move the call to a workaround function required when suspending
inside the function that puts an endpoint into suspend mode.  This
requires moving a few functions (which are otherwise unchanged).

Then simplify ipa_endpoint_program() to call essentially all
endpoint register update functions unconditionally.

					-Alex

Alex Elder (4):
  net: ipa: move version test inside ipa_endpoint_program_delay()
  net: ipa: always handle suspend workaround
  net: ipa: move version test inside ipa_endpoint_program_suspend()
  net: ipa: simplify ipa_endpoint_program()

 drivers/net/ipa/ipa_endpoint.c | 190 +++++++++++++++++----------------
 1 file changed, 99 insertions(+), 91 deletions(-)

-- 
2.25.1

Comments

David Miller July 2, 2020, 9:31 p.m. UTC | #1 
From: Alex Elder <elder@linaro.org>

Date: Thu,  2 Jul 2020 06:25:33 -0500

> Add tests to functions so they don't update undefined endpoint

> registers, rather than requiring the caller to avoid calling them.

> 

> Move the call to a workaround function required when suspending

> inside the function that puts an endpoint into suspend mode.  This

> requires moving a few functions (which are otherwise unchanged).

> 

> Then simplify ipa_endpoint_program() to call essentially all

> endpoint register update functions unconditionally.


Series applied, thank you.