mbox series

[bpf-next,0/2] Do not limit cb_flags when creating child sk from listen sk

Message ID 20201002013442.2541568-1-kafai@fb.com
Headers show
Series Do not limit cb_flags when creating child sk from listen sk | expand

Message

Martin KaFai Lau Oct. 2, 2020, 1:34 a.m. UTC 
This set fixes an issue that the bpf_skops_init_child() unnecessarily
limited the child sk from inheriting all bpf_sock_ops_cb_flags
of the listen sk.  It also adds a test to check that.

Martin KaFai Lau (2):
  bpf: tcp: Do not limit cb_flags when creating child sk from listen sk
  bpf: selftest: Ensure the child sk inherited all bpf_sock_ops_cb_flags

 include/net/tcp.h                             | 33 -------------------
 net/ipv4/tcp_minisocks.c                      |  1 -
 .../bpf/prog_tests/tcp_hdr_options.c          | 12 +++++++
 .../bpf/progs/test_misc_tcp_hdr_options.c     |  4 +--
 .../bpf/progs/test_tcp_hdr_options.c          |  7 ++--
 .../selftests/bpf/test_tcp_hdr_options.h      |  5 +--
 6 files changed, 22 insertions(+), 40 deletions(-)

Comments

Stanislav Fomichev Oct. 2, 2020, 4:03 p.m. UTC | #1 
On 10/01, Martin KaFai Lau wrote:
> This set fixes an issue that the bpf_skops_init_child() unnecessarily
> limited the child sk from inheriting all bpf_sock_ops_cb_flags
> of the listen sk.  It also adds a test to check that.
Thank you, that fixed it for me!

Tested-by: Stanislav Fomichev <sdf@google.com>