mbox series

[ethtool,v3,0/7] pause frame stats

Message ID 20201018213151.3450437-1-kuba@kernel.org
Headers show
Series pause frame stats | expand

Message

Jakub Kicinski Oct. 18, 2020, 9:31 p.m. UTC
Hi!

Sorry about the delay from v2.


This set adds support for pause frame statistics.

First pause frame info is extended to support --json.

Pause stats are first of this kind of statistics so add
support for a new flag (--include-statistics).

Next add support for dumping policy to check if the statistics
flag is supported for a given subcommand.

Last but not least - display statistics.

v3:
 - rename the ctx variable to policy_ctx
 - instead of returning the flags policy save it to a member
   of struct nl_context, for potential reuse. Also we don't
   have to worry about returning flags and negative errors
   from the read helper this way :)

Jakub Kicinski (7):
  update UAPI header copies
  pause: add --json support
  separate FLAGS out in -h
  add support for stats in subcommands
  netlink: prepare for more per-op info
  netlink: use policy dumping to check if stats flag is supported
  pause: add support for dumping statistics

 ethtool.8.in           |   7 ++
 ethtool.c              |  17 +++-
 internal.h             |   1 +
 netlink/coalesce.c     |   6 +-
 netlink/msgbuff.h      |   6 ++
 netlink/netlink.c      | 179 ++++++++++++++++++++++++++++++++++++++---
 netlink/netlink.h      |  31 +++++--
 netlink/pause.c        | 111 ++++++++++++++++++++++---
 uapi/linux/genetlink.h |  11 +++
 uapi/linux/netlink.h   |   4 +
 10 files changed, 336 insertions(+), 37 deletions(-)

Comments

Michal Kubecek Oct. 19, 2020, 11:11 a.m. UTC | #1
On Sun, Oct 18, 2020 at 02:31:44PM -0700, Jakub Kicinski wrote:
> Hi!
> 
> Sorry about the delay from v2.

Actually, I'm rather surprised you were able to get back to this so
early, given the situation.

> This set adds support for pause frame statistics.
> 
> First pause frame info is extended to support --json.
> 
> Pause stats are first of this kind of statistics so add
> support for a new flag (--include-statistics).
> 
> Next add support for dumping policy to check if the statistics
> flag is supported for a given subcommand.
> 
> Last but not least - display statistics.
> 
> v3:
>  - rename the ctx variable to policy_ctx
>  - instead of returning the flags policy save it to a member
>    of struct nl_context, for potential reuse. Also we don't
>    have to worry about returning flags and negative errors
>    from the read helper this way :)
> 
> Jakub Kicinski (7):
>   update UAPI header copies
>   pause: add --json support
>   separate FLAGS out in -h
>   add support for stats in subcommands
>   netlink: prepare for more per-op info
>   netlink: use policy dumping to check if stats flag is supported
>   pause: add support for dumping statistics
> 
>  ethtool.8.in           |   7 ++
>  ethtool.c              |  17 +++-
>  internal.h             |   1 +
>  netlink/coalesce.c     |   6 +-
>  netlink/msgbuff.h      |   6 ++
>  netlink/netlink.c      | 179 ++++++++++++++++++++++++++++++++++++++---
>  netlink/netlink.h      |  31 +++++--
>  netlink/pause.c        | 111 ++++++++++++++++++++++---
>  uapi/linux/genetlink.h |  11 +++
>  uapi/linux/netlink.h   |   4 +
>  10 files changed, 336 insertions(+), 37 deletions(-)

Series applied, thank you.

Michal