mbox series

[net-next,0/4] net: ipa: little fixes

Message ID 20201109165635.5449-1-elder@linaro.org
Headers show
Series net: ipa: little fixes | expand

Message

Alex Elder Nov. 9, 2020, 4:56 p.m. UTC 
This series adds a few small fixes to the IPA code.

The first patch appeared in a different form in June, and got some
pushback from David because he felt a problem that can be caught at
build time *should* be caught at build time.
  https://lore.kernel.org/netdev/20200610195332.2612233-1-elder@linaro.org/
I agree with that, but in this case the "problem" was never actually
a problem.  There's a little more explanation on the patch, but
basically now we remove the BUILD_BUG_ON() call entirely.

The second deletes a line of code that isn't needed.

The third converts a warning message to be a debug, as requested by
Stephen Boyd.

And the last one just gets rid of an error message that would be
output after a different message had already reported a problem.

					-Alex

Alex Elder (4):
  net: ipa: don't break build on large transaction size
  net: ipa: get rid of a useless line of code
  net: ipa: change a warning to debug
  net: ipa: drop an error message

 drivers/net/ipa/gsi.c      | 7 +------
 drivers/net/ipa/ipa_main.c | 6 +-----
 drivers/net/ipa/ipa_mem.c  | 8 ++++----
 3 files changed, 6 insertions(+), 15 deletions(-)

-- 
2.20.1

Comments

Jakub Kicinski Nov. 11, 2020, 10:08 p.m. UTC | #1 
On Mon,  9 Nov 2020 10:56:31 -0600 Alex Elder wrote:
> This series adds a few small fixes to the IPA code.

> 

> The first patch appeared in a different form in June, and got some

> pushback from David because he felt a problem that can be caught at

> build time *should* be caught at build time.

>   https://lore.kernel.org/netdev/20200610195332.2612233-1-elder@linaro.org/

> I agree with that, but in this case the "problem" was never actually

> a problem.  There's a little more explanation on the patch, but

> basically now we remove the BUILD_BUG_ON() call entirely.

> 

> The second deletes a line of code that isn't needed.

> 

> The third converts a warning message to be a debug, as requested by

> Stephen Boyd.

> 

> And the last one just gets rid of an error message that would be

> output after a different message had already reported a problem.


Applied, thanks!