| Message ID | 20210111052759.2144758-1-kuba@kernel.org |
|---|---|
| Headers | show |
| Series | MAINTAINERS: remove inactive folks from networking | expand |
On Mon, 2021-01-11 at 09:41 -0800, Jakub Kicinski wrote: > On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote: > > On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote: > > > Drop Felix from Mediatek Ethernet driver maintainers. > > > We haven't seen any tags since the initial submission. > > [] > > > diff --git a/MAINTAINERS b/MAINTAINERS > > [] > > > @@ -11165,7 +11165,6 @@ F: Documentation/devicetree/bindings/dma/mtk-* > > > F: drivers/dma/mediatek/ > > > > > > > > > MEDIATEK ETHERNET DRIVER > > > -M: Felix Fietkau <nbd@nbd.name> > > > M: John Crispin <john@phrozen.org> > > > M: Sean Wang <sean.wang@mediatek.com> > > > M: Mark Lee <Mark-MC.Lee@mediatek.com> > > > > I think your script is broken as there are multiple subdirectories > > for this entry and > > Quite the opposite, the script intentionally only counts contributions > only to the code under the MAINTAINERS entry. My mistake. I'd seen Felix's name fairly often. I ran this command: $ git log --pretty=oneline --since=5-years-ago --grep="-by: Felix Fietkau" drivers/net/ethernet/mediatek/ 656e705243fd0c2864b89634ea16ed444ef64dc6 net-next: mediatek: add support for MT7623 ethernet Saw that felix had worked on mediatek and then looked up files in drivers/net with mediatek and conflated the wireless files and ethernet files. btw: because I didn't see the script published and so can't verify what's being done here, the MAINTAINERS file shows: F: *Files* and directories wildcard patterns. A trailing slash includes all files and subdirectory files. F: drivers/net/ all files in and below drivers/net F: drivers/net/* all files in drivers/net, but not below cheers, Joe
On Sun, 10 Jan 2021 21:36:24 -0800 Chris Snook wrote: > On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski <kuba@kernel.org> wrote: > > Jay was not active in recent years and does not have plans > > to return to work on ATLX drivers. > > > > Subsystem ATLX ETHERNET DRIVERS > > Changes 20 / 116 (17%) > > Last activity: 2020-02-24 > > Jay Cliburn <jcliburn@gmail.com>: > > Chris Snook <chris.snook@gmail.com>: > > Tags ea973742140b 2020-02-24 00:00:00 1 > > Top reviewers: > > [4]: andrew@lunn.ch > > [2]: kuba@kernel.org > > [2]: o.rempel@pengutronix.de > > INACTIVE MAINTAINER Jay Cliburn <jcliburn@gmail.com> > > > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > I'm overdue to be moved to CREDITS as well. I never had alx hardware, > I no longer have atl1c or atl1e hardware, and I haven't powered on my > atl1 or atl2 hardware in years. Your call, obviously, but having someone familiar with the code and the hardware look at the patches and provide Ack or Review tags is in itself very, very helpful. There is no requirement to actually test any of the changes or develop new features.
On Mon, Jan 11, 2021 at 6:39 PM Jakub Kicinski <kuba@kernel.org> wrote: > > On Sun, 10 Jan 2021 21:36:24 -0800 Chris Snook wrote: > > On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski <kuba@kernel.org> wrote: > > > Jay was not active in recent years and does not have plans > > > to return to work on ATLX drivers. > > > > > > Subsystem ATLX ETHERNET DRIVERS > > > Changes 20 / 116 (17%) > > > Last activity: 2020-02-24 > > > Jay Cliburn <jcliburn@gmail.com>: > > > Chris Snook <chris.snook@gmail.com>: > > > Tags ea973742140b 2020-02-24 00:00:00 1 > > > Top reviewers: > > > [4]: andrew@lunn.ch > > > [2]: kuba@kernel.org > > > [2]: o.rempel@pengutronix.de > > > INACTIVE MAINTAINER Jay Cliburn <jcliburn@gmail.com> > > > > > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > > > I'm overdue to be moved to CREDITS as well. I never had alx hardware, > > I no longer have atl1c or atl1e hardware, and I haven't powered on my > > atl1 or atl2 hardware in years. > > Your call, obviously, but having someone familiar with the code and the > hardware look at the patches and provide Ack or Review tags is in > itself very, very helpful. There is no requirement to actually test any > of the changes or develop new features. In that case, I'm happy to keep reviewing them. Acked-by: Chris Snook <chris.snook@gmail.com>
Hi! This series intends to remove some most evidently inactive maintainers. To make maintainers' lives easier we're trying to nudge people towards CCing all the relevant folks on patches, in an attempt to improve review rate. We have a check in patchwork which validates the CC list against get_maintainers.pl. It's a little awkward, however, to force people to CC maintainers who we haven't seen on the mailing list for years. This series removes from maintainers folks who didn't provide any tag (incl. authoring a patch) in the last 5 years. To ensure reasonable signal to noise ratio we only considered MAINTAINERS entries which had more than 100 patches fall under them in that time period. All this is purely a process-greasing exercise, I hope nobody sees this series as an affront. Most folks are moved to CREDITS, a couple entries are simply removed. The following inactive maintainers are kept, because they indicated the intention to come back in the near future: - Veaceslav Falico (bonding) - Christian Benvenuti (Cisco drivers) Patches in this series contain report from a script which did the analysis. Big thanks to Jonathan Corbet for help and writing the script (although I feel like I used it differently than Jon may have intended ;)). The output format is thus: Subsystem $name Changes $reviewed / $total ($percent%) // how many changes to the subsystem had at least one ack/review Last activity: $date_of_most_recent_patch $maintainer/reviewer1: Author $last_commit_authored_by_the_person $how_many_in_5yrs Committer $last_committed $how_many Tags $last_tag_like_review_signoff_etc $how_many $maintainer/reviewer2: Author $last_commit_authored_by_the_person $how_many_in_5yrs Committer $last_committed $how_many Tags $last_tag_like_review_signoff_etc $how_many Top reviewers: // Top 3 reviewers (who are not listed in MAINTAINERS) [$count_of_reviews_and_acks]: $email INACTIVE MAINTAINER $name // maintainer / reviewer who has done nothing in last 5yrs Jakub Kicinski (9): MAINTAINERS: altx: move Jay Cliburn to CREDITS MAINTAINERS: net: move Alexey Kuznetsov to CREDITS MAINTAINERS: vrf: move Shrijeet to CREDITS MAINTAINERS: ena: remove Zorik Machulsky from reviewers MAINTAINERS: tls: move Aviad to CREDITS MAINTAINERS: mtk-eth: remove Felix MAINTAINERS: ipvs: move Wensong Zhang to CREDITS MAINTAINERS: dccp: move Gerrit Renker to CREDITS MAINTAINERS: skge/sky2: move Mirko Lindner to CREDITS CREDITS | 28 ++++++++++++++++++++++++++++ MAINTAINERS | 11 +---------- 2 files changed, 29 insertions(+), 10 deletions(-)