mbox series

[v3,net-next,0/2] pktgen: scripts improvements

Message ID 20210311103253.14676-1-irusskikh@marvell.com
Headers show
Series pktgen: scripts improvements | expand

Message

Igor Russkikh March 11, 2021, 10:32 a.m. UTC
Hello netdev community,

Please consider small improvements to pktgen scripts we use in our environment.

Adding delay parameter through command line,
Adding new -a (append) parameter to make flex runs

v3: change us to ns in docs
v2: Review comments from Jesper

CC: Jesper Dangaard Brouer <brouer@redhat.com>

Igor Russkikh (2):
  samples: pktgen: allow to specify delay parameter via new opt
  samples: pktgen: new append mode

 samples/pktgen/README.rst                     | 18 +++++++++++
 samples/pktgen/functions.sh                   |  7 ++++-
 samples/pktgen/parameters.sh                  | 15 ++++++++-
 .../pktgen_bench_xmit_mode_netif_receive.sh   |  3 --
 .../pktgen_bench_xmit_mode_queue_xmit.sh      |  3 --
 samples/pktgen/pktgen_sample01_simple.sh      | 25 ++++++++-------
 samples/pktgen/pktgen_sample02_multiqueue.sh  | 29 +++++++++--------
 .../pktgen_sample03_burst_single_flow.sh      | 15 ++++-----
 samples/pktgen/pktgen_sample04_many_flows.sh  | 17 +++++-----
 .../pktgen/pktgen_sample05_flow_per_thread.sh | 17 +++++-----
 ...sample06_numa_awared_queue_irq_affinity.sh | 31 ++++++++++---------
 11 files changed, 110 insertions(+), 70 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 14, 2021, 9:30 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Thu, 11 Mar 2021 11:32:51 +0100 you wrote:
> Hello netdev community,

> 

> Please consider small improvements to pktgen scripts we use in our environment.

> 

> Adding delay parameter through command line,

> Adding new -a (append) parameter to make flex runs

> 

> [...]


Here is the summary with links:
  - [v3,net-next,1/2] samples: pktgen: allow to specify delay parameter via new opt
    https://git.kernel.org/netdev/net-next/c/ef700f2ea27e
  - [v3,net-next,2/2] samples: pktgen: new append mode
    https://git.kernel.org/netdev/net-next/c/c8fd4852022c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Jesper Dangaard Brouer March 15, 2021, 8:45 a.m. UTC | #2
On Thu, 11 Mar 2021 11:32:51 +0100
Igor Russkikh <irusskikh@marvell.com> wrote:

> Hello netdev community,

> 

> Please consider small improvements to pktgen scripts we use in our environment.

> 

> Adding delay parameter through command line,

> Adding new -a (append) parameter to make flex runs

> 

> v3: change us to ns in docs

> v2: Review comments from Jesper

> 

> CC: Jesper Dangaard Brouer <brouer@redhat.com>


Did a quick review and everything looks okay.
The patches are already applied, but you will still get my ACK,
even-though it will not make it to the commit log.

Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>


> Igor Russkikh (2):

>   samples: pktgen: allow to specify delay parameter via new opt

>   samples: pktgen: new append mode

> 

>  samples/pktgen/README.rst                     | 18 +++++++++++

>  samples/pktgen/functions.sh                   |  7 ++++-

>  samples/pktgen/parameters.sh                  | 15 ++++++++-

>  .../pktgen_bench_xmit_mode_netif_receive.sh   |  3 --

>  .../pktgen_bench_xmit_mode_queue_xmit.sh      |  3 --

>  samples/pktgen/pktgen_sample01_simple.sh      | 25 ++++++++-------

>  samples/pktgen/pktgen_sample02_multiqueue.sh  | 29 +++++++++--------

>  .../pktgen_sample03_burst_single_flow.sh      | 15 ++++-----

>  samples/pktgen/pktgen_sample04_many_flows.sh  | 17 +++++-----

>  .../pktgen/pktgen_sample05_flow_per_thread.sh | 17 +++++-----

>  ...sample06_numa_awared_queue_irq_affinity.sh | 31 ++++++++++---------

>  11 files changed, 110 insertions(+), 70 deletions(-)


-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
Igor Russkikh March 15, 2021, 11:55 a.m. UTC | #3
>> v3: change us to ns in docs

>> v2: Review comments from Jesper

>>

>> CC: Jesper Dangaard Brouer <brouer@redhat.com>

> 

> Did a quick review and everything looks okay.

> The patches are already applied, but you will still get my ACK,

> even-though it will not make it to the commit log.

> 

> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>


Thanks for the review, Jesper!

  Igor