mbox series

[net,0/2] Bugfixes for HTB

Message ID 20210311144206.2135872-1-maximmi@nvidia.com
Headers show
Series Bugfixes for HTB | expand

Message

Maxim Mikityanskiy March 11, 2021, 2:42 p.m. UTC 
The HTB offload feature introduced a few bugs in HTB. One affects the
non-offload mode, preventing attaching qdiscs to HTB classes, and the
other affects the error flow, when the netdev doesn't support the
offload, but it was requested. This short series fixes them.

Maxim Mikityanskiy (2):
  sch_htb: Fix select_queue for non-offload mode
  sch_htb: Fix offload cleanup in htb_destroy on htb_init failure

 net/sched/sch_htb.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

Comments

Cong Wang March 12, 2021, 1:36 a.m. UTC | #1 
On Thu, Mar 11, 2021 at 6:42 AM Maxim Mikityanskiy <maximmi@nvidia.com> wrote:
>

> The HTB offload feature introduced a few bugs in HTB. One affects the

> non-offload mode, preventing attaching qdiscs to HTB classes, and the

> other affects the error flow, when the netdev doesn't support the

> offload, but it was requested. This short series fixes them.


Both look good to me.

Acked-by: Cong Wang <cong.wang@bytedance.com>


Thanks.