mbox series

[V5,0/7] vDPA/ifcvf: enables Intel C5000X-PL virtio-net

Message ID 20210317094933.16417-1-lingshan.zhu@intel.com
Headers show
Series vDPA/ifcvf: enables Intel C5000X-PL virtio-net | expand

Message

Zhu Lingshan March 17, 2021, 9:49 a.m. UTC 
This series enabled Intel FGPA SmartNIC C5000X-PL virtio-net for vDPA.

vDPA requires VIRTIO_F_ACCESS_PLATFORM as a must,
this series verify this feature bit when set features.

Changes from V4:
deduce VIRTIO device ID from pdev device id or subsystem
device id(Jason)

Changes from V3:
checks features to set in verify_min_features(Jason)
deduce VIRTIO device ID from pdev ids in get_device_id(Jason)

Changes from V2:
verify VIRTIO_F_ACCESS_PLATFORM when set features(Jason)

Changes from V1:
remove version number string(Leon)
add new device ids and remove original device ids
in separate patches(Jason)

Zhu Lingshan (7):
  vDPA/ifcvf: get_vendor_id returns a device specific vendor id
  vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA
  vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids
  vDPA/ifcvf: remove the version number string
  vDPA/ifcvf: fetch device feature bits when probe
  vDPA/ifcvf: verify mandatory feature bits for vDPA
  vDPA/ifcvf: deduce VIRTIO device ID from pdev ids

 drivers/vdpa/ifcvf/ifcvf_base.c | 24 +++++++++++++++++--
 drivers/vdpa/ifcvf/ifcvf_base.h | 17 ++++++++++----
 drivers/vdpa/ifcvf/ifcvf_main.c | 41 ++++++++++++++++++++++++++-------
 3 files changed, 68 insertions(+), 14 deletions(-)

Comments

Jason Wang March 18, 2021, 2:44 a.m. UTC | #1 
在 2021/3/17 下午5:49, Zhu Lingshan 写道:
> This commit deduces the VIRTIO device ID of a probed

> device from its pdev device ids.

>

> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>

> ---

>   drivers/vdpa/ifcvf/ifcvf_base.h |  1 +

>   drivers/vdpa/ifcvf/ifcvf_main.c | 14 +++++++++++++-

>   2 files changed, 14 insertions(+), 1 deletion(-)

>

> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h

> index f77239fc1644..b2eeb16b9c2c 100644

> --- a/drivers/vdpa/ifcvf/ifcvf_base.h

> +++ b/drivers/vdpa/ifcvf/ifcvf_base.h

> @@ -127,4 +127,5 @@ int ifcvf_verify_min_features(struct ifcvf_hw *hw, u64 features);

>   u16 ifcvf_get_vq_state(struct ifcvf_hw *hw, u16 qid);

>   int ifcvf_set_vq_state(struct ifcvf_hw *hw, u16 qid, u16 num);

>   struct ifcvf_adapter *vf_to_adapter(struct ifcvf_hw *hw);

> +int ifcvf_probed_virtio_net(struct ifcvf_hw *hw);

>   #endif /* _IFCVF_H_ */

> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c

> index ea93ea7fd5df..9fade400b5a4 100644

> --- a/drivers/vdpa/ifcvf/ifcvf_main.c

> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c

> @@ -323,7 +323,19 @@ static u32 ifcvf_vdpa_get_generation(struct vdpa_device *vdpa_dev)

>   

>   static u32 ifcvf_vdpa_get_device_id(struct vdpa_device *vdpa_dev)

>   {

> -	return VIRTIO_ID_NET;

> +	struct ifcvf_adapter *adapter = vdpa_to_adapter(vdpa_dev);

> +	struct pci_dev *pdev = adapter->pdev;

> +	u32 ret = -ENODEV;

> +

> +	if (pdev->device < 0x1000 || pdev->device > 0x107f)

> +		return ret;

> +

> +	if (pdev->device < 0x1040)

> +		ret =  pdev->subsystem_device;

> +	else

> +		ret =  pdev->device - 0x1040;

> +

> +	return ret;

>   }



It would be better to keep the comment.

But anyway

Acked-by: Jason Wang <jasowang@redhat.com>




>   

>   static u32 ifcvf_vdpa_get_vendor_id(struct vdpa_device *vdpa_dev)