| Message ID | 20210720173557.999534-1-vladimir.oltean@nxp.com |
|---|---|
| Headers | show |
| Series | Fixes for the switchdev FDB fan-out helpers | expand |
Hi Vladimir, On 20/07/2021 19:35, Vladimir Oltean wrote: > With the semicolon at the end, the compiler sees the shim function as a > declaration and not as a definition, and warns: > > 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined Thank you for the patch! My CI also reported the same issue and I confirm it removes the warning. Tested-by: Matthieu Baerts <matthieu.baerts@tessares.net> Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Jul 2021 20:35:55 +0300 you wrote: > Hi, > > There are already two fixes for the newly added helpers to multiply a > switchdev FDB add/del event times the number of lower interfaces of a > bridge. These are: > > (1) the shim definition of switchdev_handle_fdb_del_to_device() is > broken, as reported by the kernel test robot. > (2) while checking where switchdev_handle_fdb_del_to_device() is called > from, I realized it is called once from where it shouldn't, aka from > __switchdev_handle_fdb_del_to_device(). That shouldn't happen, > instead that function should recurse into itself directly. > > [...] Here is the summary with links: - [net-next,1/2] net: switchdev: remove stray semicolon in switchdev_handle_fdb_del_to_device shim https://git.kernel.org/netdev/net-next/c/94111dfc18b8 - [net-next,2/2] net: switchdev: recurse into __switchdev_handle_fdb_del_to_device https://git.kernel.org/netdev/net-next/c/71f4f89a0324 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Hi, There are already two fixes for the newly added helpers to multiply a switchdev FDB add/del event times the number of lower interfaces of a bridge. These are: (1) the shim definition of switchdev_handle_fdb_del_to_device() is broken, as reported by the kernel test robot. (2) while checking where switchdev_handle_fdb_del_to_device() is called from, I realized it is called once from where it shouldn't, aka from __switchdev_handle_fdb_del_to_device(). That shouldn't happen, instead that function should recurse into itself directly. Vladimir Oltean (2): net: switchdev: remove stray semicolon in switchdev_handle_fdb_del_to_device shim net: switchdev: recurse into __switchdev_handle_fdb_del_to_device include/net/switchdev.h | 2 +- net/switchdev/switchdev.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)