| Message ID | 20210907212420.28529-1-saeed@kernel.org |
|---|---|
| Headers | show |
| Series | mlx5 fixes 2021-09-07 | expand |
On Tue, 7 Sep 2021 14:24:20 -0700 Saeed Mahameed wrote: > From: Aya Levin <ayal@nvidia.com> > > When activating the PTP-RQ, redirect the RQT from drop-RQ to PTP-RQ. > Use mlx5e_channels_get_ptp_rqn to retrieve the rqn. This helper returns > a boolean (not status), hence caller should consider return value 0 as a > fail. Change the caller interpretation of the return value. It would be really great to turn down the dial on the abbreviations and add some user-visible impact, as is best practice (some would say a requirement) for fixes. I've been following the PTP work in mlx5 a little bit but I have no idea what a RQT is and what kind of issues to expect without this patch.
On Wed, 2021-09-08 at 09:39 -0700, Jakub Kicinski wrote: > On Tue, 7 Sep 2021 14:24:20 -0700 Saeed Mahameed wrote: > > From: Aya Levin <ayal@nvidia.com> > > > > When activating the PTP-RQ, redirect the RQT from drop-RQ to PTP- > > RQ. > > Use mlx5e_channels_get_ptp_rqn to retrieve the rqn. This helper > > returns > > a boolean (not status), hence caller should consider return value 0 > > as a > > fail. Change the caller interpretation of the return value. > > It would be really great to turn down the dial on the abbreviations > and > add some user-visible impact, as is best practice (some would say a > requirement) for fixes. > Ack and agreed ! I will enforce this. > I've been following the PTP work in mlx5 a little bit but I have no > idea > what a RQT is and what kind of issues to expect without this patch. RQT is a simple RQ Table; where we group rq numbers in one table object so steering and RSS objects can point to a table of RQs. To simplify driver code: 1. we use RQT objects also for single RQ destinations. 2. HW/FW do not allow destroying RQs when they are directly being referenced by Steering rules. RQTs help keeping steering objects pointing to a valid RQT object while driver is destroying RQs, while re-configuring, we just swap the rq number in the RQT with the new configuration RQs, or when device is deactivated (ifconfig down) we just swap all RQ numbers in all RQTs with the "Drop RQ"
On Tue 2021-09-07 14:24:17, Saeed Mahameed wrote: > From: Saeed Mahameed <saeedm@nvidia.com> > > Handle error flow on mlx5_core_alloc_pd() failure, > read_fw_strings_work must be canceled. > > Fixes: c71ad41ccb0c ("net/mlx5: FW tracer, events handling") Reviewed-by: Pavel Machek (CIP) <pavel@denx.de> -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
From: Saeed Mahameed <saeedm@nvidia.com> Hi Dave, Jakub, This series introduces some fixes to mlx5 driver. Please pull and let me know if there is any problem. Included here, a patch which solves a build warning reported on linux-kernel mailing list [1]: Fix commit ("net/mlx5: Bridge, fix uninitialized variable usage") I hope this series can make it to rc1. [1] https://www.spinics.net/lists/netdev/msg765481.html Thanks, Saeed. --- The following changes since commit 0f77f2defaf682eb7e7ef623168e49c74ae529e3: ieee802154: Remove redundant initialization of variable ret (2021-09-07 14:06:08 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-fixes-2021-09-07 for you to fetch changes up to 8db6a54f3cae6a803b2cbf5390662bca641f7da8: net/mlx5e: Fix condition when retrieving PTP-rqn (2021-09-07 14:17:02 -0700) ---------------------------------------------------------------- mlx5-fixes-2021-09-07 ---------------------------------------------------------------- Aya Levin (2): net/mlx5e: Fix mutual exclusion between CQE compression and HW TS net/mlx5e: Fix condition when retrieving PTP-rqn Maor Gottlieb (1): net/mlx5: Fix potential sleeping in atomic context Mark Bloch (1): net/mlx5: Lag, don't update lag if lag isn't supported Parav Pandit (1): net/mlx5: Fix rdma aux device on devlink reload Saeed Mahameed (1): net/mlx5: FWTrace, cancel work on alloc pd error flow Vlad Buslov (1): net/mlx5: Bridge, fix uninitialized variable usage drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 7 ++----- drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 3 ++- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 11 ++++++----- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 ++--- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 10 ++++++++-- 9 files changed, 26 insertions(+), 22 deletions(-)