mbox series

[net,0/4] mptcp: a bunch of assorted fixes

Message ID cover.1608114076.git.pabeni@redhat.com
Headers show
Series mptcp: a bunch of assorted fixes | expand

Message

Paolo Abeni Dec. 16, 2020, 11:48 a.m. UTC 
This series pulls a few fixes for the MPTCP datapath.
Most issues addressed here has been recently introduced
with the recent reworks, with the notable exception of
the first patch, which addresses an issue present since
the early days

Paolo Abeni (4):
  mptcp: fix security context on server socket
  mptcp: properly annotate nested lock
  mptcp: push pending frames when subflow has free space
  mptcp: fix pending data accounting

 net/mptcp/options.c                               | 13 ++++++++-----
 net/mptcp/protocol.c                              | 11 ++++++-----
 net/mptcp/protocol.h                              |  2 +-
 tools/testing/selftests/net/mptcp/simult_flows.sh |  6 +++---
 4 files changed, 18 insertions(+), 14 deletions(-)

Comments

Mat Martineau Dec. 16, 2020, 11:37 p.m. UTC | #1 
On Wed, 16 Dec 2020, Paolo Abeni wrote:

> MPTCP closes the subflows while holding the msk-level lock.
> While acquiring the subflow socket lock we need to use the
> correct nested annotation, or we can hit a lockdep splat
> at runtime.
>
> Reported-and-tested-by: Geliang Tang <geliangtang@gmail.com>
> Fixes: e16163b6e2b7 ("mptcp: refactor shutdown and close")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> net/mptcp/protocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel
patchwork-bot+netdevbpf@kernel.org Dec. 17, 2020, 6:30 p.m. UTC | #2 
Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Wed, 16 Dec 2020 12:48:31 +0100 you wrote:
> This series pulls a few fixes for the MPTCP datapath.

> Most issues addressed here has been recently introduced

> with the recent reworks, with the notable exception of

> the first patch, which addresses an issue present since

> the early days

> 

> Paolo Abeni (4):

>   mptcp: fix security context on server socket

>   mptcp: properly annotate nested lock

>   mptcp: push pending frames when subflow has free space

>   mptcp: fix pending data accounting

> 

> [...]


Here is the summary with links:
  - [net,1/4] mptcp: fix security context on server socket
    https://git.kernel.org/netdev/net/c/0c14846032f2
  - [net,2/4] mptcp: properly annotate nested lock
    https://git.kernel.org/netdev/net/c/3f8b2667f257
  - [net,3/4] mptcp: push pending frames when subflow has free space
    https://git.kernel.org/netdev/net/c/219d04992b68
  - [net,4/4] mptcp: fix pending data accounting
    https://git.kernel.org/netdev/net/c/13e1603739e5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html