From patchwork Mon Feb 6 22:53:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 93494 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1928249qgi; Mon, 6 Feb 2017 14:53:55 -0800 (PST) X-Received: by 10.84.248.70 with SMTP id e6mr21049849pln.179.1486421635143; Mon, 06 Feb 2017 14:53:55 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5si2012240pgi.392.2017.02.06.14.53.55; Mon, 06 Feb 2017 14:53:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbdBFWxx (ORCPT + 5 others); Mon, 6 Feb 2017 17:53:53 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:35361 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbdBFWxw (ORCPT ); Mon, 6 Feb 2017 17:53:52 -0500 Received: by mail-lf0-f45.google.com with SMTP id n124so53034047lfd.2 for ; Mon, 06 Feb 2017 14:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=eJ683xyP6KlbA+CE/JbZxdf0nZeZBiRrAMoFAgt6rbA=; b=Wgp1z2GxkAJdllg9BvwQLR3M8JdMex5fjnFPbBXVGBEPS+BdQ6vvWr5pigupRKZxdS 6JPuk58FgeshxqtrF+OiGsuRIJE3pLgwnSQmCUTXwUInfR5nCek+PoZDf4Gl6vgq8hgy ruowNAkXBGGt8r86Ox0JJ4pBl2U2et8j4Rsz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=eJ683xyP6KlbA+CE/JbZxdf0nZeZBiRrAMoFAgt6rbA=; b=sWBRPZBsr+0FA6ah4y6XBPsM+qNnHHEsSa98ZkB+d2hn92CTty9Hgopxw3CIKdzHcj 7rMDF1KQJOodexYx/Ajusgpzk6SaPDwztTtegv5zFVB8EkwLJIZ2FC2EAh/zApd9omD+ aajkvxbqisX0AkeqkBpLPzdP6Zq6TEi7GBCfEsqfB33AuBIXp9/PL9xcVOL+LMhI9Uer GbCCnPRD66TzDxDZtYlbwwdgBKojtF7rLGMJzvKGbxlCSkH4VXVUowiJUgwfrvpjjY+L m9CKRtmrNrjsB+E13fax746GA/H4LEp4mmkiO9P+Q5vLqXQnO4ZK0TY1eWJ77v65xaeU wGEg== X-Gm-Message-State: AIkVDXKwrGlxkaISoyZWCNornyILd2+T/QcPE6kHGJaQc7wcv1pziXnmTUCE93NcXWk657F0 X-Received: by 10.25.219.82 with SMTP id s79mr4071704lfg.116.1486421630456; Mon, 06 Feb 2017 14:53:50 -0800 (PST) Received: from localhost.localdomain (183-224-132-95.pool.ukrtel.net. [95.132.224.183]) by smtp.gmail.com with ESMTPSA id f18sm684235ljb.20.2017.02.06.14.53.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Feb 2017 14:53:49 -0800 (PST) From: Ivan Khoronzhuk To: mugunthanvnm@ti.com Cc: grygorii.strashko@ti.com, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: [PATCH] net: ethernet: ti: cpsw: remove netif_trans_update Date: Tue, 7 Feb 2017 00:53:45 +0200 Message-Id: <1486421625-24413-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org No need to update jiffies in txq->trans_start twice, it's supposed to be done in netdev_start_xmit() and anyway is re-written. Also, no reason to update trans time in case of an error. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/cpsw.c | 2 -- 1 file changed, 2 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 35a95dc..4d1c0c3 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1601,8 +1601,6 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb, struct cpdma_chan *txch; int ret, q_idx; - netif_trans_update(ndev); - if (skb_padto(skb, CPSW_MIN_PACKET_SIZE)) { cpsw_err(priv, tx_err, "packet pad failed\n"); ndev->stats.tx_dropped++;