From patchwork Wed Mar 11 22:33:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 222668 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FBDC2BB1D for ; Wed, 11 Mar 2020 22:33:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAB732074B for ; Wed, 11 Mar 2020 22:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583966005; bh=DCA9Vqez8sEHk63Rk3h6Ni55LoHVCMrL/2cPBxgJLsM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=d75R/Lvl98V0izoplQhi4pcriNp/fqlET+XBjXIJG9GCiMd/h1IGf1NlSBtOPTFxF IDmwSvAtUIBzPQo4JwtFhYNvSPCA8xFL8pDujwIitMvqMN8fmSqobrPAxEVDlSvaGh moviD63qswgp/Mlx9B9q1exGn/VavSzf+NgFdHlo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387500AbgCKWdX (ORCPT ); Wed, 11 Mar 2020 18:33:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:38246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387485AbgCKWdW (ORCPT ); Wed, 11 Mar 2020 18:33:22 -0400 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3166E20755; Wed, 11 Mar 2020 22:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583966001; bh=DCA9Vqez8sEHk63Rk3h6Ni55LoHVCMrL/2cPBxgJLsM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ca0+BnOlMYjglgivSn6PxQ/oiSz18sXZbXPdXqEPk5DBtE//SZowHW1Vbb8DkNLld LS6t2U/3xfaaPIDaItrC3w3J288j4TsAWgVQZu9p+a05JM8WNwnbvNPS58WQfaSCnT 7NYbndao7OwOpA/HYYIJSxdP11xZY9OWTmlHj2AM= From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, mkubecek@suse.cz, sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, madalin.bucur@nxp.com, fugang.duan@nxp.com, claudiu.manoil@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, jacob.e.keller@intel.com, alexander.h.duyck@linux.intel.com, Jakub Kicinski Subject: [PATCH net-next 14/15] net: ixgbe: reject unsupported coalescing params Date: Wed, 11 Mar 2020 15:33:01 -0700 Message-Id: <20200311223302.2171564-15-kuba@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311223302.2171564-1-kuba@kernel.org> References: <20200311223302.2171564-1-kuba@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c index 7c52ae8ac005..c6bf0a50ee63 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c @@ -3444,6 +3444,7 @@ static int ixgbe_set_priv_flags(struct net_device *netdev, u32 priv_flags) } static const struct ethtool_ops ixgbe_ethtool_ops = { + .supported_coalesce_params = ETHTOOL_COALESCE_USECS, .get_drvinfo = ixgbe_get_drvinfo, .get_regs_len = ixgbe_get_regs_len, .get_regs = ixgbe_get_regs,