diff mbox series

[RFC,net-next,06/22] nexthop: Pass extack to nexthop notifier

Message ID 20200908091037.2709823-7-idosch@idosch.org
State Superseded
Headers show
Series nexthop: Add support for nexthop objects offload | expand

Commit Message

Ido Schimmel Sept. 8, 2020, 9:10 a.m. UTC
From: Ido Schimmel <idosch@nvidia.com>

The next patch will add extack to the notification info. This allows
listeners to veto notifications and communicate the reason to user space.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 net/ipv4/nexthop.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

David Ahern Sept. 8, 2020, 2:44 p.m. UTC | #1
On 9/8/20 3:10 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> The next patch will add extack to the notification info. This allows
> listeners to veto notifications and communicate the reason to user space.
> 
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
>  net/ipv4/nexthop.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
> index 8c0f17c6863c..dafcb9f17250 100644
> --- a/net/ipv4/nexthop.c
> +++ b/net/ipv4/nexthop.c
> @@ -38,7 +38,8 @@ static const struct nla_policy rtm_nh_policy[NHA_MAX + 1] = {
>  
>  static int call_nexthop_notifiers(struct net *net,
>  				  enum nexthop_event_type event_type,
> -				  struct nexthop *nh)
> +				  struct nexthop *nh,
> +				  struct netlink_ext_ack *extack)
>  {
>  	int err;
>  
> @@ -907,7 +908,7 @@ static void __remove_nexthop(struct net *net, struct nexthop *nh,
>  static void remove_nexthop(struct net *net, struct nexthop *nh,
>  			   struct nl_info *nlinfo)
>  {
> -	call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh);
> +	call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh, NULL);
>  
>  	/* remove from the tree */
>  	rb_erase(&nh->rb_node, &net->nexthop.rb_root);
> 

Reviewed-by: David Ahern <dsahern@gmail.com>
diff mbox series

Patch

diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
index 8c0f17c6863c..dafcb9f17250 100644
--- a/net/ipv4/nexthop.c
+++ b/net/ipv4/nexthop.c
@@ -38,7 +38,8 @@  static const struct nla_policy rtm_nh_policy[NHA_MAX + 1] = {
 
 static int call_nexthop_notifiers(struct net *net,
 				  enum nexthop_event_type event_type,
-				  struct nexthop *nh)
+				  struct nexthop *nh,
+				  struct netlink_ext_ack *extack)
 {
 	int err;
 
@@ -907,7 +908,7 @@  static void __remove_nexthop(struct net *net, struct nexthop *nh,
 static void remove_nexthop(struct net *net, struct nexthop *nh,
 			   struct nl_info *nlinfo)
 {
-	call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh);
+	call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh, NULL);
 
 	/* remove from the tree */
 	rb_erase(&nh->rb_node, &net->nexthop.rb_root);