From patchwork Thu Dec 3 14:43:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 336942 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp349636ilb; Thu, 3 Dec 2020 06:46:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJwdaNWFCH5mA990XA3L2eto/J4kZ0VvcCLXjj4aAWlw2R+SZNJD2WCP8cprv9zJsMNTSQWC X-Received: by 2002:aa7:c58a:: with SMTP id g10mr3049697edq.315.1607006761545; Thu, 03 Dec 2020 06:46:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607006761; cv=none; d=google.com; s=arc-20160816; b=0QHayL5nU+gkoTC2pOwasWNRKoVJKKT4B8yWbqatGYAqCQZ9SMTnsWl+InxUGiaOBb 5Ft5hlIIYsyVGper5OPQz28qQ4xWHPYE2L5XiUdb85WUDo+wAJ7LqYT71oNfBmTPZVWq 9x7kxRvi3t1kTZHdXWGDWTpxdmMVfyNE9Dj1T55dT/DgbRk64GJarY6oS5brg7yqUJz0 6v4ek066b3sSnY8ZlZPsowyRIUkLeoTM6rilq1DdBvRakewgpXXuVSK5e+794vV2NzAt dTnaKCToZy61CqzokYb77I+68l2kN7o6NIZ/a0EXTnTNSlOxvrLEIgw4PZ5hL+Dxmt+V pHTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xKonHAzWScU6PiPc/DK529aH5VgAZfj3Pj1T+1htNxI=; b=BnCe4wPyku3tT5lB2hLYPVfuCXv/UJ8JGEwgch9FSJZvVF+p/1sZ9jzLPl1x79OrkF u1o9UI0YnPCnQ1hBO8oMMwWMS10q1KGDmwvVNhNYymL1sITIVD6v0bByGmTILSU9PQcC 6XsSeGukFSkYDY36E3d55G7m5rIxBtTyk3UhhNRjQ18uCQNtJnmaxd44o1BcCDXRE66Y lsJD07XrPd3HZYEuHY+wXuv+LEKL36KJgtxklur9daRlg0vjf1VOrG5ak43kFNA+NHO1 7cPaMFUcx2RqHfQIrqKqySphoTSKBgnaTd4nKqztky9/JxtCC7Pxcnq38jzOdwFf3jCP mAXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Vec/zxkK"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si1180242ejf.404.2020.12.03.06.46.01; Thu, 03 Dec 2020 06:46:01 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Vec/zxkK"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389312AbgLCOoi (ORCPT + 8 others); Thu, 3 Dec 2020 09:44:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730820AbgLCOoi (ORCPT ); Thu, 3 Dec 2020 09:44:38 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27DE0C061A4F for ; Thu, 3 Dec 2020 06:43:51 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id y10so2773410ljc.7 for ; Thu, 03 Dec 2020 06:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xKonHAzWScU6PiPc/DK529aH5VgAZfj3Pj1T+1htNxI=; b=Vec/zxkKCF/pLDv4KJLo2qXej9uAOcjIE2oZbVGbIcqS3/98akRIQU1HfFcOjSArc4 0VrDfss+2Llv6L/tyj0Pk+GmB0nBRTLVYCAlwUztRiRbgW+zXJdoJbDAqQIKKFug8t/B yG8YvfUr4TNwrP+xu/pbtts2KP3Y7+o/Lz+9fPwqcj+SxglzxX42fg+Hm9quL+b1t3hL n7VQFhpw10dA+5EtsAGrENOPIZc18bJBPzrTq4v06xPY5cQZm4j7kkKog872rtta9LEZ HPoh5JllGy5SBW9e8IsLGyTTvH7u6cvnPxexRUOS2ImDXjlGfFA/ppFaX5bA+8OE3KC6 bceA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xKonHAzWScU6PiPc/DK529aH5VgAZfj3Pj1T+1htNxI=; b=oKAHwcgL0Sev3W7urM97SOdtWaUZTBJsn9q+bUqBkpCJ6faqfm+3k+9Llkt3b5JLPj 4aLajzuRBnCV8hmK+0vzEApJX6pzfUWIEqc4H/tG62oz5NTvsA5BWqKbMeH8MDzSZZi5 +r+RyqMWoD5DUk9qzvTewS3snYqtPKK2+/TlvvKu+rjDwMhY39zZkHMQt2Ywyq6q3X// 4nHntEJSq08RRB+SfvgJrchDep6rKAreGwKTmopk+h4JUyUQQSxAtmKfxO9bFWqyKO8f nh/+bhwZcHpqLml9PnRUakhX9hcjFeWg/R+fxL63af5jx8qjkjxP3nJ4XOlve0y3PLQn +aRA== X-Gm-Message-State: AOAM531G+jjcfHTpxX1Hn7qaWK/zyj+Gt+QFQ5l+WcZmwJCbcD5d+biM 9AbLtlNk9g0Pnl8/jKX1yLo8nw== X-Received: by 2002:a2e:920a:: with SMTP id k10mr1314492ljg.260.1607006629599; Thu, 03 Dec 2020 06:43:49 -0800 (PST) Received: from localhost (c-9b28e555.07-21-73746f28.bbcust.telenor.se. [85.229.40.155]) by smtp.gmail.com with ESMTPSA id q11sm579011lfo.249.2020.12.03.06.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 06:43:49 -0800 (PST) From: Anders Roxell To: madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Anders Roxell Subject: [PATCH] dpaa_eth: fix build errorr in dpaa_fq_init Date: Thu, 3 Dec 2020 15:43:43 +0100 Message-Id: <20201203144343.790719-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When building FSL_DPAA_ETH the following build error shows up: /tmp/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function ‘dpaa_fq_init’: /tmp/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:1135:9: error: too few arguments to function ‘xdp_rxq_info_reg’ 1135 | err = xdp_rxq_info_reg(&dpaa_fq->xdp_rxq, dpaa_fq->net_dev, | ^~~~~~~~~~~~~~~~ Commit b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path") added an extra argument to function xdp_rxq_info_reg and commit d57e57d0cd04 ("dpaa_eth: add XDP_TX support") didn't know about that extra argument. Signed-off-by: Anders Roxell --- I think this issue is seen since both patches went in at the same time to bpf-next and net-next. drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2 Acked-by: Björn Töpel diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 947b3d2f9c7e..6cc8c4e078de 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -1133,7 +1133,7 @@ static int dpaa_fq_init(struct dpaa_fq *dpaa_fq, bool td_enable) if (dpaa_fq->fq_type == FQ_TYPE_RX_DEFAULT || dpaa_fq->fq_type == FQ_TYPE_RX_PCD) { err = xdp_rxq_info_reg(&dpaa_fq->xdp_rxq, dpaa_fq->net_dev, - dpaa_fq->fqid); + dpaa_fq->fqid, 0); if (err) { dev_err(dev, "xdp_rxq_info_reg() = %d\n", err); return err;