From patchwork Wed Jan 13 17:15:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 362175 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp720591jap; Wed, 13 Jan 2021 09:17:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9SzZ5qjLTAa6ITHJFTDBTx2pAq/9++PoI5fTsz5ZgitUxfEx1U0PqOoe4w69W9lp4FnHc X-Received: by 2002:a05:6402:1597:: with SMTP id c23mr2684008edv.212.1610558252273; Wed, 13 Jan 2021 09:17:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610558252; cv=none; d=google.com; s=arc-20160816; b=GVFBpH/cZfi1FsWdIg29WKZFNj+hCPX30D+8VC2hwtR+FiVkcifSKQkdEwsWYdUkNe Q6qRCscFlKKihychWsDSXwkDCI/S9fDfcl4kj74ff0UjtPKAbXECBYXERsyNgMVDJ5T6 2EFbTV2jVELslycU6EES/d5zM0Yknawl+NzS/qLzHj5DXdaq8N742h1Ur9Wwb0AIk7pZ R73/MxK8xtjgCSvY+6PJbwNgA+OMh9RxzSCbMyjomaayzl0qZIYprwy96SeWpCTCA6yN ejRXE4DNfSg4icHyvIeoBhV/9QQDr3/uIJY0HgpZqlBjU2uIdt7utVjiGPkD1V01qAnW NuMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4ne5Zo1fGRu2iVcYjOo63CG/Ih5OIPi4+1L9+3+54RU=; b=C5cgdAd1w1g1rTFKmhsIihCaCG5rd2V3jz99g3X2sOSmVv8Zn7se83BorMVK9HpQ+y tqNAU0WjK76CEsmTTPB/9PKt6sQx/4aWwaTbqNuLdqFDKgh7Z6VqWk1QyvqCQMMOlRFM x2V8X5RnsYmdJz7ABzUbS9lonsv9tunDnsplpG03w69C6Ds69Ni2Xi3DkB/W/NWOajdK DeS1BN3y5/2oxYlpTWnMnFeS4HmFO7CdaE46A2WV85x4lAJXPphafi5lX3SLO34uXZnu EfCi0Bmc8oevvr3cglE4y4bYMXqT+xMD5CJ9wwZU4RhvEOzaaqRRZy/dw0v/Ur5hT+sy FiFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sbTiZViy; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si1354723edk.605.2021.01.13.09.17.32; Wed, 13 Jan 2021 09:17:32 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sbTiZViy; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728152AbhAMRQ7 (ORCPT + 7 others); Wed, 13 Jan 2021 12:16:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728129AbhAMRQ6 (ORCPT ); Wed, 13 Jan 2021 12:16:58 -0500 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB72FC0617AA for ; Wed, 13 Jan 2021 09:15:42 -0800 (PST) Received: by mail-io1-xd2a.google.com with SMTP id u26so5667790iof.3 for ; Wed, 13 Jan 2021 09:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4ne5Zo1fGRu2iVcYjOo63CG/Ih5OIPi4+1L9+3+54RU=; b=sbTiZViyBdcIcY4TVKLFp8dMDvOB4aVI4mbfI/SnTr0qjNrxX70pM1g+vz1sNk3GQG 5ua75OuvAWyvNffK2SnKjyBQXPEGehG9YcSDUTb25W9uXNlJeR9g0K+1w/Mw2hoB0ul9 qK88hj4K0F35DtHh+Jpkuo9fZmHGbiFCH1amd5EuGFa6HY1PuQi0fVy9m6vVOjpFLn+6 gw4JytVhDzdpgtnmLZzm0ujlTRNebECGbuGasjItPUm3gR0Mwxd4iGAzNTUT5FlIUOfB 304dS++1ksF9IFYEXKGfWJ23OtEArnIjaE+4WrwsHPQEHbpqKEBMIF1D0ut470lXDoj+ JCLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4ne5Zo1fGRu2iVcYjOo63CG/Ih5OIPi4+1L9+3+54RU=; b=bn4oSlSBeleyjj1fs3k8FVA3QXSEo8pnjQCzL42Yn2EmIx76nj9Ii8FzsIqriNh7j/ fHVPz7qkqYFpykIBewLGGNWXmq7uIpil7o2rwnh9MffRbNLi+1D04Q6Dz3s1qry0fVUK 4fYTBGzLC96pR1jUjoCh93NjXxFX2R89fr7SH225pyIacLEqbONhAonGlpVBlbempops +xG9UeRsNbXEQtppnSQxe2Nz3z3jSaqRwPfcU5ab3l729ELp1qFVgvtMgkhIuLoCUGdw VdFtwhCBTpbqBXme6HwQIIQKiXTkeUARlmnHGWIADLA9/PTVtnRK9tq2PEVFT/U9ffC8 GIAg== X-Gm-Message-State: AOAM531+UQvpSS7XrBQgT3wDmJN6n3fFt6VD+FnrLV+ZDEDt5yPsfNpC YoITx4J3uPBTUUSaruACQFa7Lg== X-Received: by 2002:a5e:dc0d:: with SMTP id b13mr2581885iok.31.1610558142318; Wed, 13 Jan 2021 09:15:42 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id h9sm1120579ili.43.2021.01.13.09.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 09:15:41 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 5/6] net: ipa: change stop channel retry delay Date: Wed, 13 Jan 2021 11:15:31 -0600 Message-Id: <20210113171532.19248-6-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210113171532.19248-1-elder@linaro.org> References: <20210113171532.19248-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If a GSI stop channel command leaves the channel in STOP_IN_PROC state, we retry the stop command after a 1-2 millisecond delay. I have been told that a 3-5 millisecond delay is a better choice. Fixes: 650d1603825d8 ("soc: qcom: ipa: the generic software interface") Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 4de769166978b..5c163f9c0ea7b 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -903,7 +903,7 @@ int gsi_channel_stop(struct gsi *gsi, u32 channel_id) ret = gsi_channel_stop_command(channel); if (ret != -EAGAIN) break; - usleep_range(USEC_PER_MSEC, 2 * USEC_PER_MSEC); + usleep_range(3 * USEC_PER_MSEC, 5 * USEC_PER_MSEC); } while (retries--); mutex_unlock(&gsi->mutex);