diff mbox series

[v2,net-next,2/4] skbuff: constify skb_propagate_pfmemalloc() "page" argument

Message ID 20210127201031.98544-3-alobakin@pm.me
State Superseded
Headers show
Series net: consolidate page_is_pfmemalloc() usage | expand

Commit Message

Alexander Lobakin Jan. 27, 2021, 8:11 p.m. UTC 
The function doesn't write anything to the page struct itself,
so this argument can be const.

Misc: align second argument to the brace while at it.

Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
 include/linux/skbuff.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Rientjes Jan. 28, 2021, 10:45 p.m. UTC | #1 
On Wed, 27 Jan 2021, Alexander Lobakin wrote:

> The function doesn't write anything to the page struct itself,

> so this argument can be const.

> 

> Misc: align second argument to the brace while at it.

> 

> Signed-off-by: Alexander Lobakin <alobakin@pm.me>


Acked-by: David Rientjes <rientjes@google.com>
diff mbox series

Patch

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 9313b5aaf45b..b027526da4f9 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -2943,8 +2943,8 @@  static inline struct page *dev_alloc_page(void)
  *	@page: The page that was allocated from skb_alloc_page
  *	@skb: The skb that may need pfmemalloc set
  */
-static inline void skb_propagate_pfmemalloc(struct page *page,
-					     struct sk_buff *skb)
+static inline void skb_propagate_pfmemalloc(const struct page *page,
+					    struct sk_buff *skb)
 {
 	if (page_is_pfmemalloc(page))
 		skb->pfmemalloc = true;