From patchwork Mon Mar 15 15:21:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 400488 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3517877jai; Mon, 15 Mar 2021 08:22:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNvHjPRAI+5gII0zFBIPwkTqaJVkfBghKk3VXd1PJjjZljVUnhqDP759pZUup2flDeSBZm X-Received: by 2002:a17:906:d790:: with SMTP id pj16mr23837550ejb.255.1615821734336; Mon, 15 Mar 2021 08:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615821734; cv=none; d=google.com; s=arc-20160816; b=FxEG/eODrZ6GltIvfcSq4MbB3kx7hqD+pGKcK6kyrijWJq3yUtjWNh1Xr8UKB75LBO UjD056j5WqdqJSConkjslY1KNRQ8UdnQrXOn9O3QzxkvaOB8nGlGRZVfp0I7bjawty9o pZCkyr+xA0DuC2p1EtbLFBtsaZGNNV6qBGByZskD6zP1VFIDNx8yDTpWBDePdGWy4qOG 8VDgRyKV3L3dfPXNjyp4x9zYF2oZKnHBFrCcqjBgp7CwXgR1RpgTfEnMHpJApXVjp2GM ZrLjoBdlMhfVgFJntrhmWqGH+wZnO1Po/sHs3GYV+U++Ydm3N1//yw2ovUjXSLaGAnmk BU3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HrzQhsRc599ph2zuSB7VP6Fml8kkJcZ8OjvvN5VFwSM=; b=vRRwwShcWz+QZOpltUKzKSCrpwlB91OnZDixXkQQKKgeWY0LwWLNKZHVcfaPulWico UPFOuacnYRQs72c4x0mEiIMpb8nv2KtmdZVelHqLJiR4vNtMeUTffvJXpzZkXnGK0YmS CxwAPRr8435XCDfm6Gg1jlVeekeE5wFwfE/CxLsmUr6prpz6JnMf1AKPRFqQ6cKkQXxW W/M0CBMep4AEvoG2Yj2SgardotoJv0LDKyevdiOk+IiPz8C9gyDfbyaAUiwcNGkT6CRt rmnB532VyjBs805f0OFR82MPeS1XAAXb9wGJXwze/7ZjRrBfhwBD+UwtYOgGfFu15koL woiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="mOx3t/LV"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jl2si11312305ejc.488.2021.03.15.08.22.14; Mon, 15 Mar 2021 08:22:14 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="mOx3t/LV"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbhCOPVk (ORCPT + 8 others); Mon, 15 Mar 2021 11:21:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231268AbhCOPVS (ORCPT ); Mon, 15 Mar 2021 11:21:18 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC49C061762 for ; Mon, 15 Mar 2021 08:21:16 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id h18so9709951ils.2 for ; Mon, 15 Mar 2021 08:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HrzQhsRc599ph2zuSB7VP6Fml8kkJcZ8OjvvN5VFwSM=; b=mOx3t/LV8m8lw+fAqMgEDSFeYFjtJ80xNdotUsL8CQKcHlLxMSHfn1+yiEAQaPC3/d y2AKFpPjZqZ/sW0l9sMIX/U7lM2vIobiKYQc3XXFSGWLMpxGJI+Z3Jo56DcY0Ge7q2Hb 59eMuvail70J81AhVO2qs7ydvFHa4N7tLWSBoX4gsv+aypnJtkDt1vLNkpEyBJl714lp g36os3gs9PQ7ElPtSi5hvdC0Ne4IpmKQyzjOcpiOFZ65dIs9DI4FOR1qdxHa43HyDPEp /ipPoj4l6Bhrp626PBZ7E0DV/zuyap1AREfNe5+SgX4VljXrIoqe8rJ5ii3ntEK4XVp2 pULg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HrzQhsRc599ph2zuSB7VP6Fml8kkJcZ8OjvvN5VFwSM=; b=J89bkpXeZ9fYYiGkJWqc4Dyn9NxdodiMCFtlEFcRY/l4tfOxc3vPQIC6sPlT0jfLOQ ovp1E1XoZBT3a1E0Ia2YkC8cMAwW+utr6WV5CdhkS1028V5stRq1KsvvHGH632U6zZPF CjtRVvWjDHFgX5DnkNhNUMl/WoPg7ZZ9VCJ7dc1Ln7F32nuWkyEJEY/D2irbNS5X2JLZ ZRTpBF4FTu7f+CFs8HUFgNTiZFaCTMk6lDpxJNTGkPhv/BMSdWs3xlzWzWV83iLX5gYY /f/DjywL/y0/fYDjLHrv8WTth84mYXFXgikJCr3nKzlUOOPp9WU24cKLwZLmcoH3q97y KpSw== X-Gm-Message-State: AOAM530YxcSfHhpR0AXuW/NH4mA4/xAC8bxpNk0BKlNRF5VAVS9A9Nm+ qMTbfzN92vDbYqVm1LHmtU13bQ== X-Received: by 2002:a05:6e02:2192:: with SMTP id j18mr99575ila.196.1615821676373; Mon, 15 Mar 2021 08:21:16 -0700 (PDT) Received: from localhost.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id l17sm8194275ilt.27.2021.03.15.08.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 08:21:16 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: manivannan.sadhasivam@linaro.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/3] net: ipa: fix a duplicated tlv_type value Date: Mon, 15 Mar 2021 10:21:10 -0500 Message-Id: <20210315152112.1907968-2-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210315152112.1907968-1-elder@linaro.org> References: <20210315152112.1907968-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In the ipa_indication_register_req_ei[] encoding array, the tlv_type associated with the ipa_mhi_ready_ind field is wrong. It duplicates the value used for the data_usage_quota_reached field (0x11) and should use value 0x12 instead. Fix this bug. Reported-by: Manivannan Sadhasivam Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_qmi_msg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 Acked-by: Manivannan Sadhasivam diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c index 73413371e3d3e..e00f829a783f6 100644 --- a/drivers/net/ipa/ipa_qmi_msg.c +++ b/drivers/net/ipa/ipa_qmi_msg.c @@ -56,7 +56,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = { .elem_size = sizeof_field(struct ipa_indication_register_req, ipa_mhi_ready_ind_valid), - .tlv_type = 0x11, + .tlv_type = 0x12, .offset = offsetof(struct ipa_indication_register_req, ipa_mhi_ready_ind_valid), }, @@ -66,7 +66,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = { .elem_size = sizeof_field(struct ipa_indication_register_req, ipa_mhi_ready_ind), - .tlv_type = 0x11, + .tlv_type = 0x12, .offset = offsetof(struct ipa_indication_register_req, ipa_mhi_ready_ind), },