From patchwork Mon Mar 22 10:38:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 406542 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF03C433C1 for ; Mon, 22 Mar 2021 10:39:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA6B560200 for ; Mon, 22 Mar 2021 10:39:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbhCVKii (ORCPT ); Mon, 22 Mar 2021 06:38:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229951AbhCVKiZ (ORCPT ); Mon, 22 Mar 2021 06:38:25 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD201C061574 for ; Mon, 22 Mar 2021 03:38:24 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id x21so18653222eds.4 for ; Mon, 22 Mar 2021 03:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=N+Z019FTmNdQoy2fMcasjqIR4BZXtUnBZiaXBGeEH5A=; b=r+wp0XzvOyj8O+bF+Baem0XKKYipKmS3prj8msBFBl9fLK+Wv3nOXAHp82xdcv78WA Pr902tKEALv9Vw3VTHPNcXnEgphj/Uoub0kvCj3s3TXJ+ChhQVOHzZFLT8sd0CCvx6jQ tKN7/yzhZ3Tr3AX5OdNbfzuqRvDoyyNs4Gj92cAf9y6WuINR32FLkFBn3Oe/6cUjJNrM wS7YZ580JV/xdOg3P9hse78XjppY7v0+lxGBQV7ZvcwCGQLy2Oq/rzpgUiB0IDjouL2f klBql6UJIln34A4gEhBbZFD0FVmAe3/H2xEW/XlV/UgVOoIStq0JI0awQvGVW8aZfhDD ws4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=N+Z019FTmNdQoy2fMcasjqIR4BZXtUnBZiaXBGeEH5A=; b=aMX9MHMev8rR0XJFzO/6Gm9nzYhr2BRSyjtafGo0yr1y0bppifrgpGphxjGD35RrQh jfnt6P5HPEpA4e8agdvaQURKV2xPskEtbpF0dovFrgtxgmWwGumWeaC6n8U/KTcHUFNO VRCKZXbjdJ64qRlYgdnmnxonFiNF0Khm0D8POdbPxcAHBG6mjqTm+y/hSbAzC2h1HAvd RiG4UoQNLsLvC0gLOV0MljCCYMC7mGwi+0bhgQrLyTntcg3jhN+tiEZwT0zExz+2efnP LmcCfeartGJrI2SHh3/mNOrw9NC9w8yp/4omY6stukwClAOwmQwB9cQ5o5YAwfamzPBB xpew== X-Gm-Message-State: AOAM5323+e0RbJOFJssWR07u5YA6DGG7kcTanfvHwn2G25zXHOS7JpMQ R+/EdOQf6hAwMDiploYJhUk= X-Google-Smtp-Source: ABdhPJxYUe1bmTRUZApiJN5K9y/zVkwGG+yX8v37O0KAP2Z9gAHyMeJAf4Jnj7OuCpjYGQsf6HxCZg== X-Received: by 2002:a50:f314:: with SMTP id p20mr24609567edm.236.1616409503586; Mon, 22 Mar 2021 03:38:23 -0700 (PDT) Received: from localhost.localdomain (5-12-16-165.residential.rdsnet.ro. [5.12.16.165]) by smtp.gmail.com with ESMTPSA id cb17sm11267097edb.10.2021.03.22.03.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 03:38:22 -0700 (PDT) From: Vladimir Oltean To: "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Roopa Prabhu , Nikolay Aleksandrov , Vladimir Oltean Subject: [PATCH net-next] net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as __be64 Date: Mon, 22 Mar 2021 12:38:19 +0200 Message-Id: <20210322103819.3723179-1-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean The only caller of br_vlan_tunnel_lookup, br_handle_ingress_vlan_tunnel, extracts the tunnel_id from struct ip_tunnel_info::struct ip_tunnel_key:: tun_id which is a __be64 value. The exact endianness does not seem to matter, because the tunnel id is just used as a lookup key for the VLAN group's tunnel hash table, and the value is not interpreted directly per se. Moreover, rhashtable_lookup_fast treats the key argument as a const void *. Therefore, there is no functional change associated with this patch, just one to silence "make W=1" builds. Signed-off-by: Vladimir Oltean Acked-by: Nikolay Aleksandrov --- net/bridge/br_vlan_tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c index 169e005fbda2..0d3a8c01552e 100644 --- a/net/bridge/br_vlan_tunnel.c +++ b/net/bridge/br_vlan_tunnel.c @@ -35,7 +35,7 @@ static const struct rhashtable_params br_vlan_tunnel_rht_params = { }; static struct net_bridge_vlan *br_vlan_tunnel_lookup(struct rhashtable *tbl, - u64 tunnel_id) + __be64 tunnel_id) { return rhashtable_lookup_fast(tbl, &tunnel_id, br_vlan_tunnel_rht_params);