| Message ID | d6d705a9-ebe7-5ed5-ec08-840500739c2c@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,1/4] r8169: use smp_store_mb in rtl_tx | expand |
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index dd6113fd7..038cd6fde 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4259,7 +4259,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb, txd_first->opts1 |= cpu_to_le32(DescOwn | FirstFrag); /* Force all memory writes to complete before notifying device */ - wmb(); + dma_wmb(); tp->cur_tx += frags + 1;
It's the typical dma_wmb() use case to finish descriptor writes before ringing the device doorbell. Therefore switch to this lighter barrier. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)