mbox series

[v5,00/10] Add Stack Smashing Protection and Object Size Checking

Message ID 20171129094300.20296-1-yselkowi@redhat.com
Headers show
Series Add Stack Smashing Protection and Object Size Checking | expand

Message

Yaakov Selkowitz Nov. 29, 2017, 9:42 a.m. UTC 
Changes in this version:

* _ELIDABLE_INLINE in C99 mode causes conflicts with extern function declarations.
Restoring __ssp_inline from NetBSD, updated to modern GCC, allows for fewer changes
to the main headers.

* The 'symbol' argument to __ssp_decl/__ssp_redirect_raw was always the same as 'fun'.
It is removed in this version to avoid needless duplication.

* The return type of read was fixed (tested on mmix-knuth-mmixware).

* Basic documentation has been added.

Yaakov Selkowitz (10):
  ssp: add APIs for Stack Smashing Protection
  ssp: add Object Size Checking common code
  ssp: add Object Size Checking for string.h
  ssp: add Object Size Checking for strings.h
  ssp: add Object Size Checking for stdio.h, part 1
  ssp: add Object Size Checking for unistd.h, part 1
  ssp: add documentation
  ssp: add build infrastructure
  cygwin: export SSP functions
  cygwin: create libssp compatibility import library

 newlib/Makefile.am                     |   4 +
 newlib/Makefile.in                     |   4 +
 newlib/libc/Makefile.am                |   4 +-
 newlib/libc/Makefile.in                |  15 +-
 newlib/libc/configure                  |   3 +-
 newlib/libc/configure.in               |   2 +-
 newlib/libc/include/ssp/ssp.h          |  77 ++++
 newlib/libc/include/ssp/stdio.h        | 101 +++++
 newlib/libc/include/ssp/string.h       | 115 ++++++
 newlib/libc/include/ssp/strings.h      |  55 +++
 newlib/libc/include/ssp/unistd.h       |  53 +++
 newlib/libc/include/stdio.h            |   4 +
 newlib/libc/include/string.h           |   4 +
 newlib/libc/include/strings.h          |   4 +
 newlib/libc/include/sys/features.h     |  18 +-
 newlib/libc/include/sys/unistd.h       |   5 +
 newlib/libc/libc.in.xml                |   1 +
 newlib/libc/libc.texinfo               |   1 +
 newlib/libc/ssp/Makefile.am            |  69 ++++
 newlib/libc/ssp/Makefile.in            | 706 +++++++++++++++++++++++++++++++++
 newlib/libc/ssp/chk_fail.c             |  13 +
 newlib/libc/ssp/gets_chk.c             |  78 ++++
 newlib/libc/ssp/memcpy_chk.c           |  54 +++
 newlib/libc/ssp/memmove_chk.c          |  50 +++
 newlib/libc/ssp/mempcpy_chk.c          |  21 +
 newlib/libc/ssp/memset_chk.c           |  49 +++
 newlib/libc/ssp/snprintf_chk.c         |  59 +++
 newlib/libc/ssp/sprintf_chk.c          |  63 +++
 newlib/libc/ssp/ssp.tex                |  44 ++
 newlib/libc/ssp/stack_protector.c      |  45 +++
 newlib/libc/ssp/stpcpy_chk.c           |  58 +++
 newlib/libc/ssp/stpncpy_chk.c          |  56 +++
 newlib/libc/ssp/strcat_chk.c           |  62 +++
 newlib/libc/ssp/strcpy_chk.c           |  55 +++
 newlib/libc/ssp/strncat_chk.c          |  73 ++++
 newlib/libc/ssp/strncpy_chk.c          |  55 +++
 newlib/libc/ssp/vsnprintf_chk.c        |  51 +++
 newlib/libc/ssp/vsprintf_chk.c         |  60 +++
 winsup/cygwin/Makefile.in              |   5 +-
 winsup/cygwin/common.din               |  19 +
 winsup/cygwin/include/cygwin/version.h |   7 +-
 41 files changed, 2210 insertions(+), 12 deletions(-)
 create mode 100644 newlib/libc/include/ssp/ssp.h
 create mode 100644 newlib/libc/include/ssp/stdio.h
 create mode 100644 newlib/libc/include/ssp/string.h
 create mode 100644 newlib/libc/include/ssp/strings.h
 create mode 100644 newlib/libc/include/ssp/unistd.h
 create mode 100644 newlib/libc/ssp/Makefile.am
 create mode 100644 newlib/libc/ssp/Makefile.in
 create mode 100644 newlib/libc/ssp/chk_fail.c
 create mode 100644 newlib/libc/ssp/gets_chk.c
 create mode 100644 newlib/libc/ssp/memcpy_chk.c
 create mode 100644 newlib/libc/ssp/memmove_chk.c
 create mode 100644 newlib/libc/ssp/mempcpy_chk.c
 create mode 100644 newlib/libc/ssp/memset_chk.c
 create mode 100644 newlib/libc/ssp/snprintf_chk.c
 create mode 100644 newlib/libc/ssp/sprintf_chk.c
 create mode 100644 newlib/libc/ssp/ssp.tex
 create mode 100644 newlib/libc/ssp/stack_protector.c
 create mode 100644 newlib/libc/ssp/stpcpy_chk.c
 create mode 100644 newlib/libc/ssp/stpncpy_chk.c
 create mode 100644 newlib/libc/ssp/strcat_chk.c
 create mode 100644 newlib/libc/ssp/strcpy_chk.c
 create mode 100644 newlib/libc/ssp/strncat_chk.c
 create mode 100644 newlib/libc/ssp/strncpy_chk.c
 create mode 100644 newlib/libc/ssp/vsnprintf_chk.c
 create mode 100644 newlib/libc/ssp/vsprintf_chk.c

-- 
2.15.0

Comments

Corinna Vinschen Nov. 29, 2017, 5:22 p.m. UTC | #1 
On Nov 29 03:42, Yaakov Selkowitz wrote:
> Changes in this version:

> 

> * _ELIDABLE_INLINE in C99 mode causes conflicts with extern function declarations.

> Restoring __ssp_inline from NetBSD, updated to modern GCC, allows for fewer changes

> to the main headers.

> 

> * The 'symbol' argument to __ssp_decl/__ssp_redirect_raw was always the same as 'fun'.

> It is removed in this version to avoid needless duplication.

> 

> * The return type of read was fixed (tested on mmix-knuth-mmixware).

> 

> * Basic documentation has been added.

> 

> Yaakov Selkowitz (10):

>   ssp: add APIs for Stack Smashing Protection

>   ssp: add Object Size Checking common code

>   ssp: add Object Size Checking for string.h

>   ssp: add Object Size Checking for strings.h

>   ssp: add Object Size Checking for stdio.h, part 1

>   ssp: add Object Size Checking for unistd.h, part 1

>   ssp: add documentation

>   ssp: add build infrastructure

>   cygwin: export SSP functions

>   cygwin: create libssp compatibility import library


Looks good to me.  If you think this is the final version, feel free
to push.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat