mbox series

[Xen-devel,00/17] xen/arm64: Rework head.S to make it more compliant with the Arm Arm

Message ID 20190610193215.23704-1-julien.grall@arm.com
Headers show
Series xen/arm64: Rework head.S to make it more compliant with the Arm Arm | expand

Message

Julien Grall June 10, 2019, 7:31 p.m. UTC 
Hi all,

This is part of the boot/memory rework for Xen on Arm, but not sent as
MM-PARTx as this is focusing on the boot code.

Similar to the memory code, the boot code is not following the Arm Arm and
could lead to memory corruption/TLB conflict abort. I am not aware
of any platforms where Xen fails to boot, yet it should be fixed sooner
rather than later.

While making the code more compliant, I have also took the opportunity
to simplify the boot and also add more documentation.

After this series, the boot CPU and secondary CPUs path is mostly compliant
with the Arm Arm. The only non-compliant places I am aware of are:
    1) create_page_tables: Some rework is necessary to update the page-tables
    safely without the MMU on.
    2) The switches between boot and runtime page-tables (for both boot CPU
       and secondary CPUs) are not safe.

Both will be addressed in follow-up work.

Lastly, only Arm64 has been modified so far. Arm32 requires the same
modifications. It will be sent once I gathered feedback on the approach.

Note that the series have a minor clash with MM-PART3 and reference some
change done in MM-PART1. Yet the code is mostly self-contained to
xen/arch/arm64/head.S.

For convenience I provided a branch based on staging:
    git://xenbits.xen.org/people/julieng/xen-unstable.git branch boot/arm64/v1

Cheers,

Julien Grall (17):
  xen/arm64: head Mark the end of subroutines with ENDPROC
  xen/arm64: head: Don't clobber x30/lr in the macro PRINT
  xen/arm64: head: Rework UART initialization on boot CPU
  xen/arm64: head: Don't "reserve" x24 for the CPUID
  xen/arm64: head: Introduce print_reg
  xen/arm64: head: Introduce distinct paths for the boot CPU and
    secondary CPUs
  xen/arm64: head: Rework and document check_cpu_mode()
  xen/arm64: head: Rework and document zero_bss()
  xen/arm64: head: Improve coding style and document cpu_init()
  xen/arm64: head: Improve coding style and document
    create_pages_tables()
  xen/arm64: head: Document enable_mmu()
  xen/arm64: head: Move assembly switch to the runtime PT in secondary
    CPUs path
  xen/arm64: head: Don't setup the fixmap on secondary CPUs
  xen/arm64: head: Remove ID map as soon as it is not used
  xen/arm64: head: Rework and document setup_fixmap()
  xen/arm64: head: Rework and document launch()
  xen/arm64: Zero BSS after the MMU and D-cache is turned on

 xen/arch/arm/arm64/head.S | 396 +++++++++++++++++++++++++++++++++-------------
 xen/arch/arm/mm.c         |  23 ++-
 2 files changed, 306 insertions(+), 113 deletions(-)