From patchwork Mon Apr 11 13:33:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 65519 Delivered-To: patch@linaro.org Received: by 10.112.43.237 with SMTP id z13csp1477818lbl; Mon, 11 Apr 2016 06:36:26 -0700 (PDT) X-Received: by 10.31.180.133 with SMTP id d127mr12050290vkf.86.1460381777078; Mon, 11 Apr 2016 06:36:17 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id 97si5847576uak.187.2016.04.11.06.36.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Apr 2016 06:36:17 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apbzb-0005CY-TK; Mon, 11 Apr 2016 13:35:03 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apbzb-0005C4-4b for xen-devel@lists.xen.org; Mon, 11 Apr 2016 13:35:03 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id 73/DA-27880-608AB075; Mon, 11 Apr 2016 13:35:02 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRWlGSWpSXmKPExsVysyfVTZdtBXe 4wYEPnBZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8bu+W9YC2ZwVix/rt7AOIu9i5GTQ0hgE6PE 8c0CXYxcQPZpRolVP58zgiTYBDQl7nz+xARiiwhIS1z7fBksziwQJbF+UzcriC0skCBx5eorZ hCbRUBV4u/ZSWA2r4CzRNurVrAFEgJyEiePTQar5xRwkVh4/hOQzQG0zFmieVbwBEbuBYwMqx g1ilOLylKLdA2N9ZKKMtMzSnITM3N0DQ1M9XJTi4sT01NzEpOK9ZLzczcxAn3LAAQ7GP9t8zz EKMnBpCTKu3M+d7gQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCV6t5UA5waLU9NSKtMwcYJDBpCU4 eJREeINA0rzFBYm5xZnpEKlTjIpS4rzvlgElBEASGaV5cG2wwL7EKCslzMsIdIgQT0FqUW5mC ar8K0ZxDkYlYV5pkPE8mXklcNNfAS1mAlr87B8nyOKSRISUVAPj2q9TpsnHq0/bef3T/++Mt/ 6EBl8Ky5mSwa8dWvBHTnXpuhuCLq07Wh563XmV/dI1fHqPQ2qY1rqVFuz37hxYcrycv7nv4Ok FxX8W7RAQCNS13fDs+bEFqiWLlYqPC53eUtLMtESCi1e+ia+SjVea7zqrfPZOh6QwpiM6E8Ne dkQfsSv994RfiaU4I9FQi7moOBEAOixjomcCAAA= X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-7.tower-206.messagelabs.com!1460381701!33892127!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 46323 invoked from network); 11 Apr 2016 13:35:01 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-7.tower-206.messagelabs.com with SMTP; 11 Apr 2016 13:35:01 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C384A547; Mon, 11 Apr 2016 06:32:34 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.215.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E81F03F21A; Mon, 11 Apr 2016 06:33:46 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Mon, 11 Apr 2016 14:33:37 +0100 Message-Id: <1460381617-5786-6-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1460381617-5786-1-git-send-email-julien.grall@arm.com> References: <1460381617-5786-1-git-send-email-julien.grall@arm.com> Cc: Julien Grall , sstabellini@kernel.org, shannon.zhao@linaro.org Subject: [Xen-devel] [for-4.7 v2 5/5] xen/arm: acpi: Print more error messages in acpi_map_gic_cpu_interface X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" It's helpful to spot any error without having to modify the hypervisor code. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini Reviewed-by: Shannon Zhao --- Changes in v2: - Add Stefano's and Shannon's reviewed-by --- xen/arch/arm/acpi/boot.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c index f3d8e7c..28b3450 100644 --- a/xen/arch/arm/acpi/boot.c +++ b/xen/arch/arm/acpi/boot.c @@ -63,7 +63,10 @@ acpi_map_gic_cpu_interface(struct acpi_madt_generic_interrupt *processor) total_cpus++; if ( !enabled ) + { + printk("Skipping disabled CPU entry with 0x%"PRIx64" MPIDR\n", mpidr); return; + } if ( enabled_cpus >= NR_CPUS ) { @@ -101,7 +104,11 @@ acpi_map_gic_cpu_interface(struct acpi_madt_generic_interrupt *processor) } if ( !acpi_psci_present() ) + { + printk("PSCI not present, skipping CPU MPIDR 0x%"PRIx64"\n", + mpidr); return; + } if ( (rc = arch_cpu_init(enabled_cpus, NULL)) < 0 ) {