From patchwork Thu Jun 9 13:59:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 69711 Delivered-To: patch@linaro.org Received: by 10.140.106.246 with SMTP id e109csp343564qgf; Thu, 9 Jun 2016 07:00:58 -0700 (PDT) X-Received: by 10.31.174.80 with SMTP id x77mr4767090vke.13.1465480858149; Thu, 09 Jun 2016 07:00:58 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id q131si1828676vkb.107.2016.06.09.07.00.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jun 2016 07:00:58 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bB0UP-0007kY-Tx; Thu, 09 Jun 2016 13:59:17 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bB0UO-0007kR-J2 for xen-devel@lists.xen.org; Thu, 09 Jun 2016 13:59:16 +0000 Received: from [85.158.139.211] by server-13.bemta-5.messagelabs.com id 41/EB-25698-33679575; Thu, 09 Jun 2016 13:59:15 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRWlGSWpSXmKPExsVysyfVTde4LDL cYMsmKYslHxezODB6HN39mymAMYo1My8pvyKBNaP/31ymgiu8FccPxzUw/uDqYuTiEBLYwCix bfY3ZgjnNKPEma93GLsYOTnYBDQl7nz+xARiiwhIS1z7fBksziwQLHH9/BYWEFtYIEpi8ZVLQ DUcHCwCqhL3F0aChHkFXCSO/ZsMViIhICdx8thk1gmMnAsYGVYxqhenFpWlFuma6yUVZaZnlO QmZuboGhqY6uWmFhcnpqfmJCYV6yXn525iBPqKAQh2MB6b7HyIUZKDSUmU17skMlyILyk/pTI jsTgjvqg0J7X4EKMMB4eSBC9rKVBOsCg1PbUiLTMHGDQwaQkOHiUR3pUgrbzFBYm5xZnpEKlT jIpS4rwMIH0CIImM0jy4NligXmKUlRLmZQQ6RIinILUoN7MEVf4VozgHo5Iw73aQ8TyZeSVw0 18BLWYCWrz8SDjI4pJEhJRUAyPPO16H/5Kym0NNb8ycdnda9+nV0v+4882X7NR65cy/vP2v99 482zuxqnH5tq/Epqz4GjPTvEH62klDtpVBR82nvQm7uVAr2HfdzzU7wloTf9/0cv6fv/b2pj2 eXTk3lZW+vHkkYh6fFZA6I/BJoVUo1y7eH1PEZBek79kbwFi6YO+hC44RO14rsRRnJBpqMRcV JwIAY8I6a08CAAA= X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-4.tower-206.messagelabs.com!1465480754!44089964!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 56665 invoked from network); 9 Jun 2016 13:59:15 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-4.tower-206.messagelabs.com with SMTP; 9 Jun 2016 13:59:15 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D06CF; Thu, 9 Jun 2016 06:59:50 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.215.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56A4F3F47F; Thu, 9 Jun 2016 06:59:13 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Thu, 9 Jun 2016 14:59:06 +0100 Message-Id: <1465480746-23914-1-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 Cc: Julien Grall , sstabellini@kernel.org, wei.chen@arm.com Subject: [Xen-devel] [PATCH] xen/arm: gic-v2: Fix ARM32 build after "xen/arm: gicv2: Export GICv2m..." X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" Commit "xen/arm: gicv2: Export GICv2m register frames to DOM0 by device tree" breaks compilation on ARM32. This is because paddr_t field are printed using %lx. Fix it by using PRIpaddr which will provide the correct modifiers. Signed-off-by: Julien Grall --- Stefano, the patch "xen/arm: gicv2: Export GICv2m register..." is still in your branch next-4.8. Do you plan to rebase before merging the branch? If not, I will add the commit ID in the message. I would also be fine if you decide to fold this patch into the patch that introduced the build issue. --- xen/arch/arm/gic-v2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index afeab57..2c1c0ba 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -597,7 +597,7 @@ static int gicv2_map_hwdown_extra_mappings(struct domain *d) int ret; u32 spi; - printk("GICv2: Mapping v2m frame to d%d: addr=0x%lx size=0x%lx spi_base=%u num_spis=%u\n", + printk("GICv2: Mapping v2m frame to d%d: addr=0x%"PRIpaddr" size=0x%"PRIpaddr" spi_base=%u num_spis=%u\n", d->domain_id, v2m_data->addr, v2m_data->size, v2m_data->spi_start, v2m_data->nr_spis); @@ -685,7 +685,7 @@ static int gicv2m_make_dt_node(const struct domain *d, { v2m = v2m_data->dt_node; - printk("GICv2: Creating v2m DT node for d%d: addr=0x%lx size=0x%lx spi_base=%u num_spis=%u\n", + printk("GICv2: Creating v2m DT node for d%d: addr=0x%"PRIpaddr" size=0x%"PRIpaddr" spi_base=%u num_spis=%u\n", d->domain_id, v2m_data->addr, v2m_data->size, v2m_data->spi_start, v2m_data->nr_spis);