From patchwork Thu Mar 30 12:43:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 96291 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp220933qgd; Thu, 30 Mar 2017 05:45:02 -0700 (PDT) X-Received: by 10.107.8.39 with SMTP id 39mr144374ioi.189.1490877902589; Thu, 30 Mar 2017 05:45:02 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id 188si2575336ite.65.2017.03.30.05.45.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 05:45:02 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctZQ3-0006up-32; Thu, 30 Mar 2017 12:43:15 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctZQ2-0006uh-7V for xen-devel@lists.xen.org; Thu, 30 Mar 2017 12:43:14 +0000 Received: from [193.109.254.147] by server-7.bemta-6.messagelabs.com id 67/61-04817-16DFCD85; Thu, 30 Mar 2017 12:43:13 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRWlGSWpSXmKPExsVysyfVTTfh750 Ig80PLCyWfFzM4sDocXT3b6YAxijWzLyk/IoE1oyj7YdZC2ZqVJxr/crYwDhPoYuRi0NIYCOj RMPeSywQzmlGiQ0vz7B2MXJysAloStz5/IkJxBYRkJa49vkyI4jNLBAj8fFYGwuILSyQLvH54 EUwm0VAVeLQ+utg9bwClhJHL/wDi0sIyEvsarvIOoGRcwEjwypGjeLUorLUIl0jc72kosz0jJ LcxMwcXUMDM73c1OLixPTUnMSkYr3k/NxNjECPMQDBDsbFawMPMUpyMCmJ8m6eeydCiC8pP6U yI7E4I76oNCe1+BCjDAeHkgSv7B+gnGBRanpqRVpmDjB0YNISHDxKIrzBIGne4oLE3OLMdIjU KUZdjjmzd79hEmLJy89LlRLnDQQpEgApyijNgxsBC+NLjLJSwryMQEcJ8RSkFuVmlqDKv2IU5 2BUEuadAjKFJzOvBG7TK6AjmICOELe5BXJESSJCSqqBMblFwmzl/uCiwITc03XWDgqzY27kx5 UzxXSc/Sy/K9qs+piV71aPFhX+6vylRjUKdYJq3793bTo3YWqJ/+fZZ7Y53BDZVtZ4UiiM9b/ V5P7V0oaTmeoW/rAWrFLY+i1O83W6/5oVQk5BjxrTBesTZxXd9FXM5Qu7rml9/3bVz/JLoRND 56opsRRnJBpqMRcVJwIALxOvjl4CAAA= X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-11.tower-27.messagelabs.com!1490877792!64103440!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31117 invoked from network); 30 Mar 2017 12:43:12 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-11.tower-27.messagelabs.com with SMTP; 30 Mar 2017 12:43:12 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E116828; Thu, 30 Mar 2017 05:43:11 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.218.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A6AA3F59A; Thu, 30 Mar 2017 05:43:11 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Thu, 30 Mar 2017 13:43:06 +0100 Message-Id: <20170330124306.17357-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Cc: Julien Grall , sstabellini@kernel.org, shankerd@qti.qualcomm.com Subject: [Xen-devel] [PATCH for-4.9] xen/arm: acpi: Map MMIO on fault in stage-2 page table for the hardware domain X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" When booting using ACPI, not all MMIOs can be discovered by parsing the static tables or the UEFI memory map. A lot of them will be described in the DSDT. However, Xen does not have an AML parser which requires us to find a different approach. During the first discussions on supporting ACPI (see design doc [1]), it was decided to rely on the hardware domain to make a request to the hypervisor to map the MMIO region in stage-2 page table before accessing it. This approach works fine if the OS has limited hooks to modify the page tables. In the case of Linux kernel, notifiers have been added to map the MMIO regions when adding a new AMBA/platform device. Whilst this is covering most of the MMIOs, some of them (e.g OpRegion, ECAM...) are not related to a specific device or the driver is not using the AMBA/platform API. So more hooks would need to be added in the code. Various approaches have been discussed (see [2]), one of them was to create stage-2 mappings seamlessly in Xen upon hardware memory faults. This approach was first ruled out because it relies on the hardware domain to probe the region before any use. So this would not work when DMA'ing to another device's MMIO region when the device is protected by an SMMU. It has been pointed out that this is a limited use case compare to DMA'ing between MMIO and RAM. This patch implements this approach. All MMIOs region will be mapped in stage-2 using p2m_mmio_direct_c (i.e normal memory outer and inner write-back cacheable). The stage-1 page table will be in control of the memory attribute. This is fine because the hardware domain is a trusted domain. Note that MMIO will only be mapped on a data abort fault. It is assumed that it will not be possible to execute code from MMIO (p2m_mmio_direct_c will forbid that). As mentioned above, this solution will cover most of the cases. If a platform requires to do DMA'ing to another device's MMIO region without any access performed by the OS. Then it will be expected to have specific platform code in the hypervisor to map the MMIO at boot time or the OS to use the existing hypercalls (i.e XENMEM_add_to_add_physmap{,_batch}) before any access. [1] https://lists.xen.org/archives/html/xen-devel/2015-11/msg00488.html [2] https://marc.info/?l=linux-arm-kernel&m=148469169210500&w=2 Signed-off-by: Julien Grall Tested-by: Shanker Donthineni --- This patch is a candidate for Xen 4.9. Whilst the last posting date was few days ago, I think it would be good to have this patch in the next release. Although ACPI support for ARM64 is still a technical preview, it would help servers to test Xen upstream on their platform with ACPI and provide feedback on missing features. All the code is gated by !acpi_disabled and therefore will not be executed on when using Device Tree. RM hat on: I will leave the decision to Stefano. Shanker: You mentioned offline that you tested the patch. May I add your tested-by? --- xen/arch/arm/traps.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 614501f761..ebf915bb3b 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -49,6 +50,7 @@ #include #include #include +#include /* The base of the stack must always be double-word aligned, which means * that both the kernel half of struct cpu_user_regs (which is pushed in @@ -2534,6 +2536,35 @@ static bool try_handle_mmio(struct cpu_user_regs *regs, return !!handle_mmio(info); } +/* + * When using ACPI, most of the MMIO regions will be mapped on-demand + * in stage-2 page tables for the hardware domain because Xen is not + * able to know from the EFI memory map the MMIO regions. + */ +static bool try_map_mmio(gfn_t gfn) +{ + struct domain *d = current->domain; + + /* For the hardware domain, all MMIOs are mapped with GFN == MFN */ + mfn_t mfn = _mfn(gfn_x(gfn)); + + /* + * Device-Tree should already have everything mapped when building + * the hardware domain. + */ + if ( acpi_disabled ) + return false; + + if ( d != hardware_domain ) + return false; + + /* The hardware domain can only map permitted MMIO regions */ + if ( !iomem_access_permitted(d, mfn_x(mfn), mfn_x(mfn) + 1) ) + return false; + + return !map_regions_p2mt(d, gfn, 1, mfn, p2m_mmio_direct_c); +} + static void do_trap_data_abort_guest(struct cpu_user_regs *regs, const union hsr hsr) { @@ -2611,6 +2642,9 @@ static void do_trap_data_abort_guest(struct cpu_user_regs *regs, if ( !mfn_eq(mfn, INVALID_MFN) ) return; + if ( try_map_mmio(_gfn(paddr_to_pfn(info.gpa))) ) + return; + break; default: gprintk(XENLOG_WARNING, "Unsupported DFSC: HSR=%#x DFSC=%#x\n",