From patchwork Tue May 14 12:24:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 164178 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp2554999ili; Tue, 14 May 2019 05:26:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqyfZkUjypxseaHYkNxaUmEFG5RXJdVz0xelI/Aql9ZL00VY24H8DB2Y0MsWyWrF8s6ZR/GM X-Received: by 2002:a02:1142:: with SMTP id 63mr22121429jaf.19.1557836768693; Tue, 14 May 2019 05:26:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557836768; cv=none; d=google.com; s=arc-20160816; b=ZO8dq5VezjSVD7JXjpEtbZKcMzFPQSsTa2ZKZ1wFodxQYGWoKnzpm2xgc9ha+qym+3 dMYO8msyWurqO5StIGYyVLZGIOO5JMWBEgEuZ61o9pU1yueNsFwiHDbZYn4vmbQ9Afmq uS82birxHFSzJh+0TYYDLe3vKUzy45hU+iAGi3oV6p0xQPcSu3gvbWatsvszDR/x/EWl qCODEBFWAI4HT3EoaafVBsCxTB+GvRH5OXDIABruUTPXkSENxgxeXdbsQn61F0Ax5DqQ SW+YcqmWqxCfG4sz0tHxiRF66u89MivSK7Ks0jqT9YRNxW5EEoabEl7mKFZBctqMiyTx w0Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:references:in-reply-to:message-id:date:to:from; bh=gWiIjnb7FKVA+rv1YIQ9lWA/2IPZtXuIP6zSBI8grJU=; b=qZsPD45wYnXMIW/XJiYkDOznVBMnR8lcYv4NQqSIpEEKHltMBKYtatI038PmzZWvUa ojbfBg4Wxs/iioj62hre9ekUiyNXk+1upVS2gE8nuK/mSgOXc6O1ViZV2qfsYXr9xNi8 IIwJ91lWBetG+cuNlRlip4EaSTG6/0n3TZmzr3UHbXEMa+eox6TvX4CYGYDBw4bs657f SWxmYiLIyjn++9SglWLKyeEw+m6iFfKULvC7b/yH7Bj6Y9lNZOjPGkMWy+0alSZ526cW s537n9Ph7UtJ863HghscaqZJqM3oKYCy6UW+lJEQ/H4djWUzUOJDzgCSQYSDHrF9iorE BQ0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id n25si8871557iog.20.2019.05.14.05.26.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 05:26:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQWUh-0002hj-Hv; Tue, 14 May 2019 12:25:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQWUg-0002fg-6G for xen-devel@lists.xenproject.org; Tue, 14 May 2019 12:25:18 +0000 X-Inumbo-ID: 5538ff00-7643-11e9-82b7-93f578dac36c Received: from foss.arm.com (unknown [217.140.101.70]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 5538ff00-7643-11e9-82b7-93f578dac36c; Tue, 14 May 2019 12:25:17 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73C8B341; Tue, 14 May 2019 05:25:17 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 40AC23F71E; Tue, 14 May 2019 05:25:16 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 14 May 2019 13:24:47 +0100 Message-Id: <20190514122456.28559-11-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190514122456.28559-1-julien.grall@arm.com> References: <20190514122456.28559-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH MM-PART2 RESEND v2 10/19] xen/arm32: head: Correctly report the HW CPU ID X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Oleksandr_Tyshchenko@epam.com, Julien Grall , Stefano Stabellini , Andrii Anisov MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There are no reason to consider the HW CPU ID will be 0 when the processor is part of a uniprocessor system. At best, this will result to conflicting output as the rest of Xen use the value directly read from MPIDR. So remove the zeroing and logic to check if the CPU is part of a uniprocessor system. Signed-off-by: Julien Grall Reviewed-by: Andrii Anisov Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Andrii's reviewed-by --- xen/arch/arm/arm32/head.S | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 9f40face98..d42a13556c 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -124,16 +124,8 @@ GLOBAL(init_secondary) mov r12, #1 /* r12 := is_secondary_cpu */ common_start: - mov r7, #0 /* r7 := CPU ID. Initialy zero until we - * find that multiprocessor extensions are - * present and the system is SMP */ mrc CP32(r1, MPIDR) - tst r1, #MPIDR_SMP /* Multiprocessor extension supported? */ - beq 1f - tst r1, #MPIDR_UP /* Uniprocessor system? */ - bne 1f bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */ -1: /* Non-boot CPUs wait here until __cpu_up is ready for them */ teq r12, #0