From patchwork Tue Feb 9 23:42:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Stone X-Patchwork-Id: 61608 Delivered-To: patches@linaro.org Received: by 10.112.43.199 with SMTP id y7csp2334049lbl; Tue, 9 Feb 2016 15:42:52 -0800 (PST) X-Received: by 10.182.225.132 with SMTP id rk4mr32483419obc.68.1455061372855; Tue, 09 Feb 2016 15:42:52 -0800 (PST) Return-Path: Received: from mail-ob0-x231.google.com (mail-ob0-x231.google.com. [2607:f8b0:4003:c01::231]) by mx.google.com with ESMTPS id i124si250659oia.87.2016.02.09.15.42.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Feb 2016 15:42:52 -0800 (PST) Received-SPF: pass (google.com: domain of al.stone@linaro.org designates 2607:f8b0:4003:c01::231 as permitted sender) client-ip=2607:f8b0:4003:c01::231; Authentication-Results: mx.google.com; spf=pass (google.com: domain of al.stone@linaro.org designates 2607:f8b0:4003:c01::231 as permitted sender) smtp.mailfrom=al.stone@linaro.org; dkim=pass header.i=@linaro.org Received: by mail-ob0-x231.google.com with SMTP id xk3so4552730obc.2 for ; Tue, 09 Feb 2016 15:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=H0tWqgzcs10XiO8GLaDuMI+JR2hgh0VzwQ7j6DQdrpk=; b=O52NmjwZaaSsqscPgA2Onq9qxvORtXo2BZS+wrzbEhJeGljSx2W/pRGozrDOZkO2gV iDk2Uu/aTS5OK0DFUqyOcEzEE0niittbaco1bBRU+sPkkhIpeJmPXXkjAn00ZXfP7PZW ZNOtSBbMPE3+bm6fguqmgkvI9h7J1S5tgVZJU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=H0tWqgzcs10XiO8GLaDuMI+JR2hgh0VzwQ7j6DQdrpk=; b=Kl7vvSPhbKALtEL8yINE+xNRF3dfQ83iWoQkfEIs10mKmzZbm/bZ9vW3KTvN/ql+dO qVhOoNVHPSLewDnyn9Yfc+pLVpC+XcsUrJn7Bnr5qtFs5dI8tvid/1v9xjNUJe1b5LDA 2cQzRtFf95TAr6g3HIqeNY4ETDz5WdtsPKDzo6i0qiRG+mdr6gYiqrkkLgNCdmSna/8n Kj3dX3RnXbaDUti/qY8T6OrsUH5FzeEuTWZpvKQVdpO2A+JedT/zOsl0QANpcvHCCUFX 2yGQl2PuzDNA6gT5uRIvzw4j8+DBJrg2+X0ypQmw+t4CY1N22ec/XnV+zS1NffrSf4hx mCEA== X-Gm-Message-State: AG10YOTFwCJIE7uDE13o+L79qFVAgkOUdf1WW4O85/tYOY5xIW9WotLLR9V55sUeNSR9KN+0o9s= X-Received: by 10.60.140.129 with SMTP id rg1mr32950138oeb.25.1455061372465; Tue, 09 Feb 2016 15:42:52 -0800 (PST) Return-Path: Received: from fidelio.ahs3 (c-50-134-239-249.hsd1.co.comcast.net. [50.134.239.249]) by smtp.googlemail.com with ESMTPSA id e202sm265229oig.2.2016.02.09.15.42.50 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 09 Feb 2016 15:42:50 -0800 (PST) Subject: Re: ACK: [PATCH 21/21] FADT: remove no longer useful variables from test1 To: Colin Ian King , fwts-devel@lists.ubuntu.com References: <1454981583-31872-1-git-send-email-al.stone@linaro.org> <1454981583-31872-22-git-send-email-al.stone@linaro.org> <56B9DCBB.6080003@canonical.com> Cc: patches@linaro.org, linaro-acpi@lists.linaro.org From: Al Stone Message-ID: <56BA797A.5070903@linaro.org> Date: Tue, 9 Feb 2016 16:42:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56B9DCBB.6080003@canonical.com> On 02/09/2016 05:34 AM, Colin Ian King wrote: > On 09/02/16 01:33, Al Stone wrote: >> Now that the tests have been resequenced, added to, and generally >> overhauled, clean up some variables in test1 that are no longer >> useful. >> >> Signed-off-by: Al Stone >> --- >> src/acpi/fadt/fadt.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c >> index 05205cb..fbc71fd 100644 >> --- a/src/acpi/fadt/fadt.c >> +++ b/src/acpi/fadt/fadt.c >> @@ -1514,8 +1514,6 @@ static void acpi_table_check_fadt_sleep_status_reg(fwts_framework *fw) >> >> static int fadt_test1(fwts_framework *fw) >> { >> - bool passed = true; >> - >> acpi_table_check_fadt_firmware_ctrl(fw); >> acpi_table_check_fadt_dsdt(fw); >> acpi_table_check_fadt_reserved(fw); >> @@ -1589,8 +1587,6 @@ static int fadt_test1(fwts_framework *fw) >> */ >> fwts_log_info(fw, "FADT Hypervisor Vendor Identity is %" PRIu64, >> fadt->hypervisor_id); >> - if (passed) >> - fwts_passed(fw, "No issues found in FADT table."); >> >> return FWTS_OK; >> } >> > Acked-by: Colin Ian King > > Thanks Al for all these improvements. Are there any fwts-test patches > to come later? > > Colin > Argh. My bad. I must have missed these the first time through. So, attached are the regression test cleanups. Sorry about that.... -- ciao, al ----------------------------------- Al Stone Software Engineer Linaro Enterprise Group al.stone@linaro.org ----------------------------------- >From 2fbb59e6cb12f5e83fd0d1939878e52e391ac6f8 Mon Sep 17 00:00:00 2001 >From: Al Stone Date: Tue, 9 Feb 2016 16:36:00 -0700 Subject: [PATCH] Update regression tests for updated FADT spec compliance tests Signed-off-by: Al Stone --- .../arg-show-tests-0001/arg-show-tests-0001.log | 1 + .../arg-show-tests-full-0001.log | 21 +++++++++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) -- 2.5.0 diff --git a/fwts-test/arg-show-tests-0001/arg-show-tests-0001.log b/fwts-test/arg-show-tests-0001/arg-show-tests-0001.log index c131850..ab96106 100644 --- a/fwts-test/arg-show-tests-0001/arg-show-tests-0001.log +++ b/fwts-test/arg-show-tests-0001/arg-show-tests-0001.log @@ -172,5 +172,6 @@ UEFI tests: uefirtvariable UEFI Runtime service variable interface tests. ACPI Spec Compliance tests: + fadt FADT Fixed ACPI Description Table tests. madt MADT Multiple APIC Description Table (spec compliant). rsdp RSDP Root System Description Pointer test. diff --git a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log index 9b7185a..a3ba2fc 100644 --- a/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log +++ b/fwts-test/arg-show-tests-full-0001/arg-show-tests-full-0001.log @@ -37,8 +37,11 @@ ACPI tests: ERST Error Record Serialization Table test. facs (1 test): FACS Firmware ACPI Control Structure test. - fadt (3 tests): - Test FADT ACPI Description Table tests. + fadt (6 tests): + ACPI FADT Description Table flag info. + FADT checksum test. + FADT revision test. + ACPI FADT Description Table tests. Test FADT SCI_EN bit is enabled. Test FADT reset register. fpdt (1 test): @@ -371,8 +374,11 @@ Batch tests: ERST Error Record Serialization Table test. facs (1 test): FACS Firmware ACPI Control Structure test. - fadt (3 tests): - Test FADT ACPI Description Table tests. + fadt (6 tests): + ACPI FADT Description Table flag info. + FADT checksum test. + FADT revision test. + ACPI FADT Description Table tests. Test FADT SCI_EN bit is enabled. Test FADT reset register. fan (2 tests): @@ -891,6 +897,13 @@ UEFI tests: Test UEFI RT service get variable interface, invalid parameters. ACPI Spec Compliance tests: + fadt (6 tests): + ACPI FADT Description Table flag info. + FADT checksum test. + FADT revision test. + ACPI FADT Description Table tests. + Test FADT SCI_EN bit is enabled. + Test FADT reset register. madt (5 tests): MADT checksum test. MADT revision test.