From patchwork Wed Sep 20 12:59:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 113117 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp736020qgf; Wed, 20 Sep 2017 05:59:41 -0700 (PDT) X-Received: by 10.98.216.132 with SMTP id e126mr2072004pfg.276.1505912380898; Wed, 20 Sep 2017 05:59:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505912380; cv=none; d=google.com; s=arc-20160816; b=E860M6Ntxs3WCkth8YVqqW2VLF6smQDhGYrRFPpnbXpDH//Ck5w5jFYBpEVsf7PJzZ ZHDk9Vd9OUe18kYBi1x7w7NgTxB2NHLM9t5Voi7Mot6mGoLVXfOQAbdLIl7TvxzuBrym H0ybYO8dLkMDAhINKs66q/m2ee+lvHLcDcu7qgvBptje6uKR/Xp5rWNEjPMyv+oGpsEN Fs6UfBdLDz6gBtNqTOBoolHj/bQ8H9PKKZoHg5ZNpPJZx6LOCUQMTx7GQYrayFXESHkk iwlJkMBR/3oJIQ9JUnOt1bsB5sduJ6p5ezEWqggOBVZXMxetSr8sP4KDu2/m2cdHuaW4 HHTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=5KktbHfIl64suCBrd/iOziEEjorX6AWIL+521znesfk=; b=eg1rOzmZDsCvEAdSr/wv1dBQTcxMPuPn1RS9F9LrMiDEQ7LjqFYTiVpMEDm9UOrwSw EYPEhH44Tbn5dMdpO3gcOLeRPOXvqFyYqf5DfiTVk+gviJsO8OI4KGMUFuJ/xdGx7Sy8 jr/1aUkF4EFYB3lrj8z5i4svdPc2PkM8fq94it7UkcKn+9dAN0L5Il9yt3QaLgQr0n4j ESNvEs8MDuA5DAXFCZBa/gCR27zsZ2+IfhuulBnLI/PBCHbRnTzKT+OBEGViWYWTMs6D SnDeinTNjmOESeHMKln8F3u1eiJr5B6AE0Nhl8W5CmKdqANHsi2Jdf9/dMLF8JZoBjhW DDTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=qew0VksR; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id g5si3031586pgc.796.2017.09.20.05.59.40; Wed, 20 Sep 2017 05:59:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=qew0VksR; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 7A26978062; Wed, 20 Sep 2017 12:59:38 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by mail.openembedded.org (Postfix) with ESMTP id 80D1577F79 for ; Wed, 20 Sep 2017 12:59:30 +0000 (UTC) Received: by mail-wr0-f175.google.com with SMTP id o42so2096403wrb.3 for ; Wed, 20 Sep 2017 05:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=LtD6bYLeom9uCpiYdTfMjYGbIpmXa1CLL4GdQB9MI28=; b=qew0VksRs+BWcwhAsbL7GZwxWFJZONjBzW9ZLJ11d51R9XwqoguVpucSbKUhP12KUm gIf1MNC54IppIx0vxUiYNv/NzSdiBH1+xvbtMNxEXC5Jngj1DDSZ9HHG1t3qlW9CCaih cD78q9/rOaKN7j1pFyVTsv2EkPHm4BdafQV0s8DBibYvgvEeqfDzZV1UpiLgSQcF6mEk 0NSA8fBJ/abFk2L2id9WjtUaYDhAuz/A+pbJzc4fe6zt9LaoerB4EYYbabd8cuuhSHpg d9CKTCQOvifLSqgZrnqq7uFVfRxtK12rYESJewvP08dJUvgC9kFft6Br2qrB24hTaeSP ny6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=LtD6bYLeom9uCpiYdTfMjYGbIpmXa1CLL4GdQB9MI28=; b=YtjxD1qNyHBwFogvkbo4DUhjxpvN+Behaie9u5ok4JITFRi12DzBDDeKGp+vEuAEMw jCEbnO9pKSFe8Wk1sLIWLtv8tlTlX1My3OQKjt3a0R3+NRsFDv/0BxWgw2ULSc+EznQ0 85qNpYi0Ut8sBOpXx5KTO4ao2eWsTdfP2hjF05vxkrnTIfd5gS3RImwzH/nqtYmahzJF Nb74b+tjrGSThT40XlO6x7yMjuNaGCsp66HPbbm0F8RM5l5hGIri90rQX6r9JhisPzr1 n6mlZXNPq9Ngm1epRD2rqMufdESgvg2KK3RmlktYGeZe7R+h2JR26tSE4Ur6zJkJJesE YRFg== X-Gm-Message-State: AHPjjUgUkjJR9qmPTduGt947AJc0Opf6V78mbsxsY7Q1hJlZYyM26I6U nUG8S7x0P8Tt8AXX1OKN/LRlB6Zr X-Google-Smtp-Source: AOwi7QDC4spzS3LyDcck4WNkPp5SKityUvtLX+ywCfDjYS3rXpZyWZEcd/TBZlIh7NLJyVCeGHlu7A== X-Received: by 10.223.145.163 with SMTP id 32mr4472487wri.279.1505912370624; Wed, 20 Sep 2017 05:59:30 -0700 (PDT) Received: from flashheart.burtonini.com (home.burtonini.com. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id p20sm1695658wma.28.2017.09.20.05.59.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Sep 2017 05:59:29 -0700 (PDT) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Wed, 20 Sep 2017 13:59:25 +0100 Message-Id: <20170920125925.28089-2-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170920125925.28089-1-ross.burton@intel.com> References: <20170920125925.28089-1-ross.burton@intel.com> Subject: [OE-core] [PATCH 2/2] sanity: check that path variables don't use ~ X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org The core path variables (TMPDIR, DL_DIR, SSTATE_DIR) don't use tilde expansion but if the user does then the errors are very mysterious, so check on startup. Signed-off-by: Ross Burton --- meta/classes/sanity.bbclass | 5 +++++ 1 file changed, 5 insertions(+) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 91b92ec28a8..1feb7949daa 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -726,6 +726,11 @@ def check_sanity_everybuild(status, d): if not ( check_conf_exists("conf/distro/${DISTRO}.conf", d) or check_conf_exists("conf/distro/include/${DISTRO}.inc", d) ): status.addresult("DISTRO '%s' not found. Please set a valid DISTRO in your local.conf\n" % d.getVar("DISTRO")) + # Check that these variables don't use tilde-expansion as we don't do that + for v in ("TMPDIR", "DL_DIR", "SSTATE_DIR"): + if d.getVar(v).startswith("~"): + status.addresult("%s uses ~ but Bitbake will not expand this, use an absolute path or variables." % v) + # Check that DL_DIR is set, exists and is writable. In theory, we should never even hit the check if DL_DIR isn't # set, since so much relies on it being set. dldir = d.getVar('DL_DIR')