From patchwork Mon Dec 3 20:35:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 152734 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp7264912ljp; Mon, 3 Dec 2018 12:35:25 -0800 (PST) X-Google-Smtp-Source: AFSGD/WJwoJjmyvXei4FtlER7B/mXtRhn1ugIxzV8HXtTNFIgQe6esmR+8fqphyDBf62pN4rpYyw X-Received: by 2002:a17:902:a710:: with SMTP id w16mr17004197plq.95.1543869325815; Mon, 03 Dec 2018 12:35:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543869325; cv=none; d=google.com; s=arc-20160816; b=xcbm1qLhV5w9zrgX3jfzT6uoiz6Zy5/Lhub9dD9Xjw/LulaEZgiEHKcRVS6i+w3vsv QmwlKR1RReq8UJzmRglOXur9DXJNxo6YexmgR3gnJOYCvzgq52xiIv26io09bdqcIfgU mVoWG9QQtNjjx9BkZxxl/pLZPxE1QZ+9nVbsTfMr6paLW5f5+z3Y74MADVpttuX5Htk+ UPdWlSMdDximbl/4kYlR6KOx9YCj3DZ5xb3gSL2T7fIwImEVQbQJ7L6UJHBG4LyStmYJ MsO6LrbFInIjjEmLTUpkWK7mWrSw6vus21AXNSb14CbekI7i7opP8cDTSl6Wl7UYcGHp 11Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=KFXEUw+heTCinwfEo1tjxcBM3242IxeHG4h6kclE+HU=; b=MHNGQu3sHc4Ct6/0UfhaY1bCFPBQdjHoAEq8PjSRHmwBr4+P3oBfXOKH7NGpHaMLlm OHtm20WJEPvQOW3d/48ku4hfZUyFuhys88lW16AWaAybLbUBftE+MMpDEjWoKdf0cH3Z t69QbwaeX03aqAa5Z7hn1S5Zckk7ECLrnmnYa9jGM2cwQocQDPZjmudRt3aDuyZCLGI9 lX2RhykP3cTtlwSIuh+If5zyGwkRL/8xxjg1IK9hTDCkUtU6Dz1r6oYUkv5nI1N8MPL5 fm6CTD1nXOSKrtiSljUwjdtIKY8kl+8svDA1pr173x3416BFgli0PZoGAa7pll3qOrgU MyDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=DlmrKc+q; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 34si8266835pgt.455.2018.12.03.12.35.24; Mon, 03 Dec 2018 12:35:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=DlmrKc+q; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from 165.28.230.35.bc.googleusercontent.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 2A7CD6C590; Mon, 3 Dec 2018 20:35:21 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mail.openembedded.org (Postfix) with ESMTP id DE7876C543 for ; Mon, 3 Dec 2018 20:35:19 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id y1so7276112wmi.3 for ; Mon, 03 Dec 2018 12:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=MckTPQe0gDBiTt+2lEsjgxc5g/sSQfHSeW52NJWUSM4=; b=DlmrKc+qRcZXS1KxKWTmagc54XAIwD6x91x4QEIxORDOFUOJGIFl+/4BzdqoTp9uoO SgRSVjqBFuj8FDW2Fz+uAxnIUlnhOUevEuhM47khhWg6kmrZXZFlIaq8Iyay8ipyN+s+ ptH9mEBSPlFkfReMVwitjwYgijAvysZt/D+KMJ98n3UCF4IMfgJtlwoNlGtRIoYb/0H3 Q4TUBUwoD9dSO2JaqVjgbkmZ8ITNkLWk1m2eiquoH8g5VFDme0HZgqjguZoqcWT+oSkW d3gW+m53YUhnHTTcMzJs7Lsk47Ok2cusMA3UePW9f2/QuK9P5q/DARkkKyc+hNLc2f2v 7KXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=MckTPQe0gDBiTt+2lEsjgxc5g/sSQfHSeW52NJWUSM4=; b=kr6aLUMqV+ibJkprw/atEJP5ubIBKrOsMC2C6mQMjVXR72UPV4Pw3QbexgQXeIshVf yBSvrD2ALyx4RIWlBd4ZCbq+3OmKA8HTzhX3oQ6ZRNfmSQSsBnoRFpNVXozwD/LPBm66 9eR9c72ghfkMbZ73f6Wkqvs3aphSFTlhbO7MeNeEX1BHoYW/V2JlerXTMjhveMNz6GFZ DUFJ7b2n427Vs4o1gQ/JeesqqsKoCI6ZVu4QviT95OtVqj32L+7XMlrSnt9+tWfh3BMm aA5SFSPfDwPl0bLwyLO0pJxVHZZeK+9EO/AYwB70rFv3sfTzTg9Ck0vDX5VCXnjpjHc6 LBuA== X-Gm-Message-State: AA+aEWbda6+nObt+4uR/X7xrsbtKlIqfhYjlVdkRzeOIYknGU9PnXjHz +UfkFCOjqWinmGRT/8/2+FjIZXuoUC8= X-Received: by 2002:a1c:c543:: with SMTP id v64mr9219711wmf.123.1543869320165; Mon, 03 Dec 2018 12:35:20 -0800 (PST) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id q2sm15361570wru.56.2018.12.03.12.35.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Dec 2018 12:35:19 -0800 (PST) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Mon, 3 Dec 2018 20:35:14 +0000 Message-Id: <20181203203516.26461-1-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 Subject: [OE-core] [PATCH 1/3] oeqa: don't litter /tmp with temporary directories X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org If we need to create a temporary directory in targetbuild or buildproject use tempfile.TemporaryDirectory so that when the test case is finished, the directory is deleted. Also synchronise the logic and don't possibly store the temporary directory in self.tmpdir as nothing uses that. Signed-off-by: Ross Burton --- meta/lib/oeqa/utils/buildproject.py | 5 ++++- meta/lib/oeqa/utils/targetbuild.py | 5 +++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/lib/oeqa/utils/buildproject.py b/meta/lib/oeqa/utils/buildproject.py index 7e9b84955f5..524015ede4b 100644 --- a/meta/lib/oeqa/utils/buildproject.py +++ b/meta/lib/oeqa/utils/buildproject.py @@ -17,7 +17,10 @@ class BuildProject(metaclass=ABCMeta): self.uri = uri self.archive = os.path.basename(uri) if not tmpdir: - tmpdir = tempfile.mkdtemp(prefix='buildproject') + tmpdir = self.d.getVar('WORKDIR') + if not tmpdir: + self.tempdirobj = tempfile.TemporaryDirectory(prefix='buildproject-') + tmpdir = self.tempdirobj.name self.localarchive = os.path.join(tmpdir, self.archive) self.dl_dir = dl_dir if foldername: diff --git a/meta/lib/oeqa/utils/targetbuild.py b/meta/lib/oeqa/utils/targetbuild.py index 1202d579fb0..b8db7b2aca0 100644 --- a/meta/lib/oeqa/utils/targetbuild.py +++ b/meta/lib/oeqa/utils/targetbuild.py @@ -20,8 +20,9 @@ class BuildProject(metaclass=ABCMeta): if not tmpdir: tmpdir = self.d.getVar('WORKDIR') if not tmpdir: - tmpdir = tempfile.mkdtemp(prefix='buildproject') - self.localarchive = os.path.join(tmpdir,self.archive) + self.tempdirobj = tempfile.TemporaryDirectory(prefix='buildproject-') + tmpdir = self.tempdirobj.name + self.localarchive = os.path.join(tmpdir, self.archive) if foldername: self.fname = foldername else: