From patchwork Mon Apr 8 17:47:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 161945 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3967469jan; Mon, 8 Apr 2019 10:47:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXdFL8HRZY3caITftyaPSV1RTpc0eyi/aVKeeq9QsDR8ZgzA0Y/R1zF6qYLEc3igdbj9LW X-Received: by 2002:a65:654c:: with SMTP id a12mr30018824pgw.101.1554745665260; Mon, 08 Apr 2019 10:47:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554745665; cv=none; d=google.com; s=arc-20160816; b=EuQVx8ypWAAr+nIHMSzF6cH6EpBPmOn5uRUMEhNGcLtCm9ant6Pq2Q0MazOUbW7izT CD+lVthoyZAuIQRhiPZIUDY81Sp7hkgaLvf27VlTdagCCECvzH8mbRpyOLvpCXgjI1EU jRrp5k0bOysZ0im5zdVEAr7L1YOgx/vdE35Os1UNTo4tOtNvkofI+dJAjh1iLbEG+VJ+ rjbbjtaOtXr0swRGUrPqDci8BboSJpI7HdBy3VggY8xD+t9cVXEG/2xrleaazVvmLA7X 2viOcAvc3UNl91qMa3tW5EpHqtOP1WZsCu+kjZEcNDL9KobspTrVC7c1V8TC+FuhmRb5 b0Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=wFw/5SgDkjioTwDposEUxQgewbEilKoxvAz/F9unHI0=; b=inbkSxY/9NdKjNRddYISgTlWrLrOIB8jpL+lnwiBvOrbIcGnRa9aEelR95i2h6gxjA GqyEaFI49zECtnRNP+LgXXQ4iyL3jATpBWdfFrCRNS8wjLJzSnagDPfxmwMetT+ALCj9 VsVSX3pdTEjwd92OJBkT3/5UtEBPIMrkA7mwK30KRSMRC1tzMP689aYqXrrJwG2Q2c2H Asuc2ckN5RfTCSiUIrwc51X5y4+Sa+PB6WmHsAlUsoesZ6YexEpUH+lgUQz3a7w7//9J TJS6w0tUc4ZB5Bsebd7qgGF5mmv9WiADVhqgCSUiJFfCpSCKlAHvUeZ8FfcpEzL1j8nb p+lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ld9DUj9K; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id e3si11611559pgc.98.2019.04.08.10.47.44; Mon, 08 Apr 2019 10:47:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ld9DUj9K; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 411747D577; Mon, 8 Apr 2019 17:47:40 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by mail.openembedded.org (Postfix) with ESMTP id 409947D574 for ; Mon, 8 Apr 2019 17:47:39 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id z9so4800931pgu.10 for ; Mon, 08 Apr 2019 10:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hCxLrwf+wPDcC0/k7ghSJtxRQ5a/7fzu2G+3KSDZcic=; b=ld9DUj9KFxJ4nc2TvcjBAntmmE38a7DRkZEV8qdM9/6Mm4JoZQR5g2Jlw/b84UrXZw wTO4DVUAzW+5zvCPtZegFQfIa9hfXaop1/e/0pZb/yOwbUAjQOCIc0CUtACwbziWo5oK Kgn5yvz93gnqbfHo/iUV0H11xPBAtWKnnWqpIPolIYZkVQd8FlbSAUaeQ2MEhA3VyCE2 Hrp6FNcGiKXdSSoMMEgiwYlxYO6q6Wt6RvJrS8Dh2RvPuZZITCX5NjBFzUFF1ZgJS+vf q7uiqoZRMlO/E1gOhIVEWpsze0T5a/ewLSMQ5k62vaVqMuw73XErIUFMny0a/kvHjJbL OnOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hCxLrwf+wPDcC0/k7ghSJtxRQ5a/7fzu2G+3KSDZcic=; b=CjQrr9bioDAzXrJUv+Tpz61/49IKuv6sL5Jx774rL1wSZuWKfyJT3h4C/rBvFPozxb WL1wQnRPfcMcrMCh0cPEUYwbb/Vs0Tg57wKfpu6z2zXhz3KM6KNnn9jFUKIEcUaJhgDi Jc3BVbk+wQoEe31LyDMh65A9vZfy7Dvfrh0OVmIPWvEFjHNYujCXZfBjlOJ79Eo5bDNT HprUYGCCdOt9NGV+4X09LU0Vdkr8rp9z4Tw65HhYlGeGFuUNhkdKAYKvXcGA9sXyOLTE nhHnxOp78FmSuhh3hH79WIo2Fm6kVsBQdKwFaKSFEyRbe6xB3ZjxWUx1v7UJPuhTyXcb ZG+w== X-Gm-Message-State: APjAAAWizcxHbTWuwkrsQKNlBZp06lvgNETG5koo32IdUFWPPJt1wl6g aqe16GzH43rACzD8Y+C8dJ6I5l4JYrc= X-Received: by 2002:a65:5ac3:: with SMTP id d3mr30487839pgt.168.1554745659419; Mon, 08 Apr 2019 10:47:39 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:8500:6bc6::8ec8]) by smtp.gmail.com with ESMTPSA id b72sm67232254pga.86.2019.04.08.10.47.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 10:47:38 -0700 (PDT) From: Khem Raj To: openembedded-core@lists.openembedded.org Date: Mon, 8 Apr 2019 10:47:32 -0700 Message-Id: <20190408174732.20703-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [OE-core] [PATCH V2] Revert "mdadm: fix gcc8 maybe-uninitialized/format-overflow warning" X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org This patch tried to address a gcc problem when -Og is used, but it did cause regressions on normal compiles when using clang e.g. the real problem is to fix the compiler until then disable the warning in DEBUG_FLAGS This reverts commit 630281663893cdcfa9c4323b717b415d87d5510f. Signed-off-by: Khem Raj --- ...-uninitialized-format-overflow-warni.patch | 60 ------------------- meta/recipes-extended/mdadm/mdadm_4.1.bb | 1 - 2 files changed, 61 deletions(-) delete mode 100644 meta/recipes-extended/mdadm/files/0001-mdadm-gcc8-maybe-uninitialized-format-overflow-warni.patch -- 2.21.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/recipes-extended/mdadm/files/0001-mdadm-gcc8-maybe-uninitialized-format-overflow-warni.patch b/meta/recipes-extended/mdadm/files/0001-mdadm-gcc8-maybe-uninitialized-format-overflow-warni.patch deleted file mode 100644 index 237f83a87e..0000000000 --- a/meta/recipes-extended/mdadm/files/0001-mdadm-gcc8-maybe-uninitialized-format-overflow-warni.patch +++ /dev/null @@ -1,60 +0,0 @@ -From bf457a83834932ba06de3528b8779a023e73fa7b Mon Sep 17 00:00:00 2001 -From: Changqing Li -Date: Tue, 12 Mar 2019 16:17:29 +0800 -Subject: [PATCH] mdadm: gcc8 maybe-uninitialized/format-overflow warning - -while compiled with -Werror=maybe-uninitialized/-Werror=format-overflow=, -it failed - -[snip] -| Incremental.c: In function 'Incremental_container': -| Incremental.c:1593:3: error: 'mdfd' may be used uninitialized in this function [-Werror=maybe-uninitialized] -| close(mdfd); -| ^~~~~~~~~~~ - -[snip] -super-intel.c: In function 'apply_takeover_update': -| super-intel.c:9615:15: error: '%d' directive writing between 1 and 11 bytes into a region of size 7 [-Werror=format-overflow=] -| " MISSING_%d", du->index); -| ^~ - -Upstream-Status: Submitted [https://github.com/neilbrown/mdadm/pull/36] - -Signed-off-by: Changqing Li ---- - Incremental.c | 2 +- - super-intel.c | 4 ++-- - 2 files changed, 3 insertions(+), 3 deletions(-) - -diff --git a/Incremental.c b/Incremental.c -index a4ff7d4..b667868 100644 ---- a/Incremental.c -+++ b/Incremental.c -@@ -1500,7 +1500,7 @@ static int Incremental_container(struct supertype *st, char *devname, - return 0; - } - for (ra = list ; ra ; ra = ra->next) { -- int mdfd; -+ int mdfd = 0; - char chosen_name[1024]; - struct map_ent *mp; - struct mddev_ident *match = NULL; -diff --git a/super-intel.c b/super-intel.c -index 10d7218..c3741ea 100644 ---- a/super-intel.c -+++ b/super-intel.c -@@ -9612,9 +9612,9 @@ static int apply_takeover_update(struct imsm_update_takeover *u, - du->major = 0; - du->index = (i * 2) + 1; - sprintf((char *)du->disk.serial, -- " MISSING_%d", du->index); -+ " MISSING_%hu", du->index); - sprintf((char *)du->serial, -- "MISSING_%d", du->index); -+ "MISSING_%hu", du->index); - du->next = super->missing; - super->missing = du; - } --- -2.7.4 - diff --git a/meta/recipes-extended/mdadm/mdadm_4.1.bb b/meta/recipes-extended/mdadm/mdadm_4.1.bb index 9862a38dc3..947706ff5f 100644 --- a/meta/recipes-extended/mdadm/mdadm_4.1.bb +++ b/meta/recipes-extended/mdadm/mdadm_4.1.bb @@ -19,7 +19,6 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/raid/mdadm/${BPN}-${PV}.tar.xz \ file://0001-fix-gcc-8-format-truncation-warning.patch \ file://mdadm.init \ file://mdmonitor.service \ - file://0001-mdadm-gcc8-maybe-uninitialized-format-overflow-warni.patch \ " SRC_URI[md5sum] = "51bf3651bd73a06c413a2f964f299598" SRC_URI[sha256sum] = "ab7688842908d3583a704d491956f31324c3a5fc9f6a04653cb75d19f1934f4a"