From patchwork Mon May 6 17:51:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 163440 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:81:0:0:0:0 with SMTP id l1csp269835ilm; Mon, 6 May 2019 10:51:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRWl3a1G3Mr7JjPtKDFCcli0bbZssZZ1eTALCcy5RHdl8RiNWT3zZ1jxRVVFuWN6geerKs X-Received: by 2002:a62:ea0a:: with SMTP id t10mr18647985pfh.236.1557165109564; Mon, 06 May 2019 10:51:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557165109; cv=none; d=google.com; s=arc-20160816; b=SmMkZ8yigwW6oRZCW3HyojW7ZzRHZcXbh4AeuilX88K4biCKAlE5cE7kRjc2Dmf5gC F7tC1UsrFv1sH/t3UTCOwGgfpbT3J4y0PzAdOgjY83kGw7Vbm/wHG8wwEmYCtKXLQ7sW FgFvTLXtjJ7/yFM9mwzLOecfEgpdztUW9qXCSnrzmqwV+KTlJqh+5NNFuSSWfhmyJoVR p0DaAiu8XMPN6yeFdaFauFB9DEBUnjDUr+49F+I/gH/dIgs77w8du+AYqIvIRx+9UOPQ UVNY4U6vKH7nKuV6MIWLiCVQwAvXPeSOLc5LjyP32ZsvhIKzek0uiqYNhSmeh3v+4EZC jkPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=Znfb/6oGOcLaTMMkOjO89gEO/xnjcHXthDKZBinIoi8=; b=wtOltfi9gvlCGJNtsFqc4/U4RKwhrCwPU8tRVoMCqcnkyLjX/XuE/9OrQa3sS2FxHT irjDau3pFTC+kybQLi2rycKLw0WXwnJWcaxjZ+MNlEBlDv/skgwU1y1NkVGsj1ejT6SO 7ov4TpMH0slvOhRUEhZtCnpZL1DUmXnxTJDVYU9JSAEdTBHv0x1R1VrgHrYF5CbPkwag 4+Wse4w8G0ThmeZRZYJywG6HPAByPcI1KSX/uOWQWRKLdBlNLu7DNR0IYo6IGrnw6ylb 05n0iUIdXwCQ06CBRmuMlrmt9UI2ldiSSgd/KCMxi8mxJHjbjpV5TBJVJ0lervRWIW3X JSGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b="kJg8aHJ/"; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 71si16539334plc.160.2019.05.06.10.51.48; Mon, 06 May 2019 10:51:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b="kJg8aHJ/"; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id DF1487D0FB; Mon, 6 May 2019 17:51:44 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mail.openembedded.org (Postfix) with ESMTP id 657EE7D0FB for ; Mon, 6 May 2019 17:51:43 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id z26so7157230pfg.6 for ; Mon, 06 May 2019 10:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9yVjfFDv+uCbhxafIHG5t3LrTWEnU1DXIqhreRyr17w=; b=kJg8aHJ/Hpa6oBZrFNd9kvRFDo5Cenl64LzYd5G5cl0/T6pd23ISrIkm5nxR/+AjuN 3Cw8xZAA0mgJj2jyx8NEE/UqLVy1vcQVlrcgea9d9bgwE6GTp457L5X7EaEdYA1EDM9R mn/73tBGhZG27idPCKDS/b7d9GpPurBmCxazX5eURYAzDWrG5o3EUcHzev3vS7p9MGPg OBVpM6urf7U2VY12fuDEo4wWx2jFnb+rTHGbl2YFi0n7v9me8lbGCJnGbCb7gBSKy4DG R34WRYI/dBZxlG4KngBfLSZp9LkPFGH04qoVrPY9PfVxTS/WC1H9rg/JogDelMA5Q1DW kRLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9yVjfFDv+uCbhxafIHG5t3LrTWEnU1DXIqhreRyr17w=; b=g9YHZ5J2aQTdDV/3eUGzy/uz8Wxt1UXzhqXfkdons5OK4XPJFOA9vG1U6+jc7dTHJR 9cie/+LS3J2OxaJkvt6KjjH1U4y+iFnikj8HCROZVcp0Q7qn0acjWom1fVLgG65hf4vR eQbG/4qO/DdKzqe7e2tlg5ruao6oa+fQ/SqoAils/gd3VRZh0r3YMdgZS7kjzwPuxU4a g2Co7q88Jq8y138BecD0QXRmEoAZgim/rwJaxIGrioHz0wFzFfMWOQSNE1toKwTEPuYC vc/ZlBe4kpj5QmNwwIOvgdDLIOR4mlGiQ6qa9noanJ7woB7xLZ9DUFJuYKgnZyAOtbqc lSpQ== X-Gm-Message-State: APjAAAXGjm/VpF9HkBuRyn6Quz9Wj9PMimgWyJrlwB7qF3Ut/L+F9iPz Dddeg1RAQSYlHvHSfrCyHtSE/VOJYzs= X-Received: by 2002:a62:582:: with SMTP id 124mr20237909pff.209.1557165103599; Mon, 06 May 2019 10:51:43 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:8500:6bc6::592a]) by smtp.gmail.com with ESMTPSA id n7sm14764022pff.45.2019.05.06.10.51.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 May 2019 10:51:43 -0700 (PDT) From: Khem Raj To: openembedded-core@lists.openembedded.org Date: Mon, 6 May 2019 10:51:35 -0700 Message-Id: <20190506175136.7594-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [OE-core] [PATCH 1/2] systemd: Fix build with gcc9 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org gcc9 throws additional warnings about format string overflow Signed-off-by: Khem Raj --- ...-format-overflow-warnings-with-gcc-9.patch | 41 +++++++++++++++++++ meta/recipes-core/systemd/systemd_242.bb | 1 + 2 files changed, 42 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/0006-Fix-format-overflow-warnings-with-gcc-9.patch diff --git a/meta/recipes-core/systemd/systemd/0006-Fix-format-overflow-warnings-with-gcc-9.patch b/meta/recipes-core/systemd/systemd/0006-Fix-format-overflow-warnings-with-gcc-9.patch new file mode 100644 index 0000000000..510ac22150 --- /dev/null +++ b/meta/recipes-core/systemd/systemd/0006-Fix-format-overflow-warnings-with-gcc-9.patch @@ -0,0 +1,41 @@ +From c8050da8b7b0e59e4d1d0e15a92b9ecad299dbbb Mon Sep 17 00:00:00 2001 +From: Khem Raj +Date: Mon, 6 May 2019 10:41:15 -0700 +Subject: [PATCH] Fix format-overflow warnings with gcc-9 +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +gcc-9 has become a bit stricter and can check all kind of formatted +input/output functions which causes additional warnings when compiling +networkd + +/src/basic/log.h:104:9: error: ‘%s’ directive argument is null [-Werror=format-overflow=] + log_internal_realm(LOG_REALM_PLUS_LEVEL(LOG_REALM, (level)), __VA_ARGS__) + +see https://github.com/systemd/systemd/issues/12454 + +Upstream-Status: Pending + +Signed-off-by: Khem Raj +--- + src/network/networkd-link.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c +index 533193ac93..976cbbeaaa 100644 +--- a/src/network/networkd-link.c ++++ b/src/network/networkd-link.c +@@ -339,7 +339,8 @@ static int link_enable_ipv6(Link *link) { + r = sysctl_write_ip_property_boolean(AF_INET6, link->ifname, "disable_ipv6", disabled); + if (r < 0) + log_link_warning_errno(link, r, "Cannot %s IPv6 for interface %s: %m", +- enable_disable(!disabled), link->ifname); ++ enable_disable(!disabled), ++ (link->ifname) ? link->ifname : ""); + else + log_link_info(link, "IPv6 successfully %sd", enable_disable(!disabled)); + +-- +2.21.0 + diff --git a/meta/recipes-core/systemd/systemd_242.bb b/meta/recipes-core/systemd/systemd_242.bb index a6b39d57e8..93c4472bab 100644 --- a/meta/recipes-core/systemd/systemd_242.bb +++ b/meta/recipes-core/systemd/systemd_242.bb @@ -22,6 +22,7 @@ SRC_URI += "file://touchscreen.rules \ file://0003-implment-systemd-sysv-install-for-OE.patch \ file://0004-rules-whitelist-hd-devices.patch \ file://0005-rules-watch-metadata-changes-in-ide-devices.patch \ + file://0006-Fix-format-overflow-warnings-with-gcc-9.patch \ file://99-default.preset \ "