From patchwork Sat Oct 26 06:49:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Kuster X-Patchwork-Id: 177805 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp565893ill; Fri, 25 Oct 2019 23:52:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDOSQL/kwHDUJJVE58QCEeGuUM2M+nhkqM8PKYxqobtFviiK0IKwJ5KuEerBuqgx/jzU1i X-Received: by 2002:a17:902:74c9:: with SMTP id f9mr8315919plt.105.1572072751309; Fri, 25 Oct 2019 23:52:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572072751; cv=none; d=google.com; s=arc-20160816; b=XW/FRBphcEGGzPKANIrSr5Lse+iQ3ZAPUu1e1wFXujxfO7XiNj6GZ6/uUeJo9ZqrWw Z1eLjrDxdSDDmY2R34eQb1fH6B1SJUHS2OQAb+3durJKLLjQ+U6I1Hp7K6K9CkutriYH rUY/Qimb+vkALxqpp2POccjlhfb/ABEfvyc4qrpEnbPXsFhN/EM6m/Mv6dxnrFXz0NvZ RA1uB8kwSTtTbYXLuO7Osncf8aPo4D+lgJAnrC0QYs0WsANu8VvxfFcU2WXsGukGCo22 RuOod/ZTRVDMCimcy3qZhxipu9MCdkCHKxF1N3tXCgIVflw3y+LM3pbPmifQU8Hkloa0 QFkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=CSsSPu5FaP2CjNcA12mTCyeWJtj2eUV6phf99hqZmGQ=; b=wMEIDQGx4uTjJhdTL9rHbmLpJPxw5q76C20s0KeSxY9vmHc2T78qb82qKBGJztds9F yMs1qjSYE+HaRdlghj9rsDPA/ZV5yv3ataqqnuNJyshKeqPQDf3a/AzTBQFTn0enEcxp +SDo2+y/0QyHGhVG8NwXfKMW9jR8MtH+WJLuFvEwItgKBUJHt+PrrT9+gPbj9c1jY1qJ t7JXVbe8Kh7/1fJ2PdosKCMgvBPMVyh4du9vfzsbBtAICaM2LltkaOP8YoP4mlFlkahO /w8ax4uQN3mgzKAzWJeB0hx3vrSPJ/FEVvmlL+yTh0trfrJtvSkKSYsdetoKZOvKXY8n QxQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=WnSj6VSt; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id a141si5160924pfd.106.2019.10.25.23.52.31; Fri, 25 Oct 2019 23:52:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=WnSj6VSt; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id AECBA7FC50; Sat, 26 Oct 2019 06:51:47 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mail.openembedded.org (Postfix) with ESMTP id 3064B7FC09 for ; Sat, 26 Oct 2019 06:50:12 +0000 (UTC) Received: by mail-wm1-f52.google.com with SMTP id g24so4361865wmh.5 for ; Fri, 25 Oct 2019 23:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=QwBCnFU5ZMZOzJnNrmyXTizNkY32vmUNNK6JRylTgMo=; b=WnSj6VStk12kv4isFgXVA+ftUVjk5iGFkwkuGnRjiq52Z4WlKMa72Nl2tdV0ZNrdHW GenAAcIF22tgxq+hxFzVNLx/I5NyfPTOhJ49dpa5fQbcVOfjZtNhKNK+VeBi92LbnzvE /VLsaz2Aoqd1FAr3HZjXigifbO3e1hZRbXMJwy8/fwHK3UoxqIAa6IzyJd7oACdvr8FB IwcjNYPT/+9kwurhRUYsMSQDf1wVU4mBekuO3yCVWvANDDlj3J9kpYXAb0bViUJOUUIU VTdx/O857+o4pT141YIMch3E0jncQ+ZFePhNEv7+DeTV2gsq3fIeYjZx6uTzXXHtm15S yvVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=QwBCnFU5ZMZOzJnNrmyXTizNkY32vmUNNK6JRylTgMo=; b=OrnmZiw7uuXCAuSfF0W28CfZMN69KbGEsQSDoQOcx8lEzBXt7nYgFVC7fDhExF5V1P kX4k/9wCxwheaA+wf7DwA3mg7zDNz2eMc6zSVs8s2afbMAwyg1htE/v63BpHRSfxA5X3 FFoGfR+QPJ3ukOMKxrwFgt5jmNPMYAFcyhuC9KvFNQIg9Uxh5HsXKmxuumy67V0iKZW+ qWGD2nxVbty8rdJEUGIFGVrITkwxMBSB3CDIKtEp8E/uFmxHxuHnl+qugHWJ5b0fsp3T ad7/k7ntfFZSvuBbEwG7YOgYhWQhtrgNpWiyBMNLKOrmEQrh5IIUicHjXkPCElkCzQon cxQw== X-Gm-Message-State: APjAAAUbV7eUyLuXjMM23DX0xFrkmw0ponECCCwndqbO61XHgQtMaB1Y 3DQE5ksK3C3FPbgViabkzxG5bnrMKKs= X-Received: by 2002:a1c:c28a:: with SMTP id s132mr6616035wmf.162.1572072612640; Fri, 25 Oct 2019 23:50:12 -0700 (PDT) Received: from akuster-ThinkPad-T460s.controleur.wifipass.org ([178.18.58.186]) by smtp.gmail.com with ESMTPSA id v6sm4807911wru.72.2019.10.25.23.50.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 Oct 2019 23:50:12 -0700 (PDT) From: Armin Kuster To: openembedded-core@lists.openembedded.org Date: Fri, 25 Oct 2019 23:49:42 -0700 Message-Id: <95d3ca54453cdb0662fae2a2cf7e8173611c86f4.1572072422.git.akuster808@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: Subject: [OE-core] [zeus 10/28] sanity: check the format of SDK_VENDOR X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org From: Ross Burton If SDK_VENDOR isn't formatted as -foosdk and is instead for example -foo-sdk then the triple that are constructed are not in fact triples, which results in mysterious compile errors. Check in sanity.bbclass so this failure is detected early. [ YOCTO #13573 ] Signed-off-by: Ross Burton Signed-off-by: Richard Purdie (cherry picked from commit b0efd8d4d0dbc30e6505b42f5603f18fa764d732) Signed-off-by: Armin Kuster --- meta/classes/sanity.bbclass | 5 +++++ 1 file changed, 5 insertions(+) -- 2.7.4 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 2d3f49e..705062b 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -798,6 +798,11 @@ def check_sanity_everybuild(status, d): elif d.getVar('SDK_ARCH', False) == "${BUILD_ARCH}": status.addresult('SDKMACHINE is set, but SDK_ARCH has not been changed as a result - SDKMACHINE may have been set too late (e.g. in the distro configuration)\n') + # If SDK_VENDOR looks like "-my-sdk" then the triples are badly formed so fail early + sdkvendor = d.getVar("SDK_VENDOR") + if not (sdkvendor.startswith("-") and sdkvendor.count("-") == 1): + status.addresult("SDK_VENDOR should be of the form '-foosdk' with a single dash\n") + check_supported_distro(d) omask = os.umask(0o022)