From patchwork Tue Aug 5 22:31:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Martin X-Patchwork-Id: 34968 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f197.google.com (mail-vc0-f197.google.com [209.85.220.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 91DC1202A1 for ; Tue, 5 Aug 2014 22:32:29 +0000 (UTC) Received: by mail-vc0-f197.google.com with SMTP id ij19sf4580691vcb.0 for ; Tue, 05 Aug 2014 15:32:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:thread-topic :thread-index:message-id:references:in-reply-to:accept-language :acceptlanguage:mime-version:cc:subject:precedence:reply-to:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-language:content-type :content-transfer-encoding; bh=Wy6jxLx6YrtTe0mihF8Ytl0VHOY11RM/098pILOZQuo=; b=Y788q7GNe4a7EXKzN7Qv2tWWJcv8TVFXynGN3GQtaXK4xTVhwX9MowpbCvW7S4fhAG 2z24ccfGyKmmdLyBSKXj7i/mtLQI56EwnxOwOMyox67tFudQPGtFqtPkRyvIiJ95tmTL VLKRzXbtv1rSwS0TV5vrqwsbMMFDB0W8XjpIdWfqcJMRaCZYWqTc89FuVipeFgJPg51b +tTdcplhz3MrpMEnrPzJEX5P4g/L/Rqgwo8BeJrMhoI8ux3w6shUrnw1rAvQCfDUS8H1 u7C9trvii3e8WtNG+JgZkQejV1nAOHCZjtOGokyr7lRjQsQRF/7EZ02uM9ZKhIWvuHQd +f7g== X-Gm-Message-State: ALoCoQmCFDrMbtUqonoYvdcNNb8lWCCrjImHAJ8VtQGPfGNFHooPtNQ1ZtnP/O9NcPI1XEvugBQR X-Received: by 10.236.207.164 with SMTP id n24mr3931122yho.5.1407277949371; Tue, 05 Aug 2014 15:32:29 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.80.244 with SMTP id c107ls495945qgd.39.gmail; Tue, 05 Aug 2014 15:32:29 -0700 (PDT) X-Received: by 10.220.118.136 with SMTP id v8mr5756066vcq.50.1407277949296; Tue, 05 Aug 2014 15:32:29 -0700 (PDT) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by mx.google.com with ESMTPS id y7si2179331vcp.89.2014.08.05.15.32.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 05 Aug 2014 15:32:29 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) client-ip=209.85.220.170; Received: by mail-vc0-f170.google.com with SMTP id lf12so2796609vcb.1 for ; Tue, 05 Aug 2014 15:32:29 -0700 (PDT) X-Received: by 10.221.5.137 with SMTP id og9mr6223336vcb.18.1407277949204; Tue, 05 Aug 2014 15:32:29 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp425732vcb; Tue, 5 Aug 2014 15:32:28 -0700 (PDT) X-Received: by 10.50.143.65 with SMTP id sc1mr2668655igb.19.1407277948264; Tue, 05 Aug 2014 15:32:28 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id gd5si8054861igd.29.2014.08.05.15.32.27 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 05 Aug 2014 15:32:28 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XEnHG-0006aO-8L; Tue, 05 Aug 2014 22:32:18 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XEnHE-0006aI-Hv for edk2-devel@lists.sourceforge.net; Tue, 05 Aug 2014 22:32:16 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of arm.com designates 195.130.217.12 as permitted sender) client-ip=195.130.217.12; envelope-from=olivier.martin@arm.com; helo=service88.mimecast.com; Received: from service88.mimecast.com ([195.130.217.12]) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1XEnHA-0005k9-Hi for edk2-devel@lists.sourceforge.net; Tue, 05 Aug 2014 22:32:16 +0000 Received: from emea-cam-gw2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) (Using TLS) by service88.mimecast.com; Tue, 05 Aug 2014 23:32:06 +0100 Received: from george.Emea.Arm.com ([fe80::4c19:a8f:5c9a:76df]) by emea-cam-gw2.Emea.Arm.com ([::1]) with mapi; Tue, 5 Aug 2014 23:32:05 +0100 From: Olivier Martin To: "Mcdaniel, Daryl" , "Carsey, Jaben" , "edk2-devel@lists.sourceforge.net" Date: Tue, 5 Aug 2014 23:31:52 +0100 Thread-Topic: StdLib: the long standing build error Thread-Index: Ac6YPNRsg3rEv6DjQserYgiaIQtxrwEyALqgAASLhfA4gE4L4AANchWwDCCg9VAARByIgAAHBHWl Message-ID: <0877601216922E4B83A7129715B5DA2BAC50E117CD@GEORGE.Emea.Arm.com> References: <002201ce983c$d4bda0a0$7e38e1e0$@martin@arm.com> <66BD57653246D24E9698B0A6509545A886DF0F88@ORSMSX109.amr.corp.intel.com> <002801cf7f18$5cc12c20$16438460$@martin@arm.com> <004601cfafd0$9c7fe700$d57fb500$@martin@arm.com>, <66BD57653246D24E9698B0A6509545A897E8A1D9@ORSMSX109.amr.corp.intel.com> In-Reply-To: <66BD57653246D24E9698B0A6509545A897E8A1D9@ORSMSX109.amr.corp.intel.com> Accept-Language: en-US, en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US, en-GB MIME-Version: 1.0 X-MC-Unique: 114080523320600202 X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1XEnHA-0005k9-Hi Cc: "Mitchell, Mark L" , Harry Liebel Subject: Re: [edk2] StdLib: the long standing build error X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: olivier.martin@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Content-Language: en-GB Why do not put '*va_arg(ap, long double *) = res;' which seems to be the valid solution and add a #ifdef for the faulty toolchains. I do not feel fair to keep a workaround by default when it blocks all the other toolchains. --- a/StdLib/LibC/Stdio/vfscanf.c +++ b/StdLib/LibC/Stdio/vfscanf.c @@ -843,12 +843,8 @@ literal: goto match_failure; if ((flags & SUPPRESS) == 0) { if (flags & LONGDBL) { - long double **mp = (long double **)ap; long double res = strtold(buf, &p); - - *(*mp) = res; - ap += sizeof(long double *); -/*???*/ //*va_arg(ap, long double *) = res; + *va_arg(ap, long double *) = res; } else if (flags & LONG) { double res = strtod(buf, &p); *va_arg(ap, double *) = res;