From patchwork Fri May 3 09:53:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 16622 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qe0-f72.google.com (mail-qe0-f72.google.com [209.85.128.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 10C7423905 for ; Fri, 3 May 2013 09:53:42 +0000 (UTC) Received: by mail-qe0-f72.google.com with SMTP id 1sf2702497qee.3 for ; Fri, 03 May 2013 02:53:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :x-forwarded-to:x-forwarded-for:delivered-to:x-received:received-spf :x-ironport-av:message-id:subject:from:to:cc:date:in-reply-to :references:organization:x-mailer:mime-version:x-gm-message-state :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-google-group-id:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=rEBGTTvLikWbefZ0gB84MbJwBlVRjlkmxD7RVTt8fio=; b=nybPuJ2FAhntrl+7GeedU1aXjHi2VEArOPvtChROEvE5GsW24SdCiWGvHFalFrJPRM NUnGI5zI/XLQzfgI4Gm1n5Q0srNNkx0dXO/PM0fYdPrehZGuKjK6h0ypKmqVgJ0LkN6g I17vG/BX5NLZ6rqfuXJxvv6VI8wGPgmmjPA2kblUjI7qGpxhdZz5SW7xYsg9hU6N6XDY /QrqiIc3NVISWXzBwbTIxc90vPtcJcPJz0BcP3Jir8N1q3phwdwiM3efZXPqfMc08Ug3 V4FDUVfD36PrPj+5TywsI4qeF6av3tycJ9tAIfCOhsIshr7S3XqpCF/yAdScf5YlsH/l sLNw== X-Received: by 10.236.87.79 with SMTP id x55mr601227yhe.54.1367574812289; Fri, 03 May 2013 02:53:32 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.127.230 with SMTP id nj6ls1745154qeb.87.gmail; Fri, 03 May 2013 02:53:32 -0700 (PDT) X-Received: by 10.52.88.2 with SMTP id bc2mr2963338vdb.27.1367574812084; Fri, 03 May 2013 02:53:32 -0700 (PDT) Received: from mail-vb0-x232.google.com (mail-vb0-x232.google.com [2607:f8b0:400c:c02::232]) by mx.google.com with ESMTPS id f7si4747403vcs.88.2013.05.03.02.53.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 03 May 2013 02:53:31 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::232 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::232; Received: by mail-vb0-f50.google.com with SMTP id w16so1200639vbb.37 for ; Fri, 03 May 2013 02:53:31 -0700 (PDT) X-Received: by 10.220.189.9 with SMTP id dc9mr3408812vcb.8.1367574811874; Fri, 03 May 2013 02:53:31 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp14121veb; Fri, 3 May 2013 02:53:31 -0700 (PDT) X-Received: by 10.181.12.5 with SMTP id em5mr12114061wid.24.1367574810656; Fri, 03 May 2013 02:53:30 -0700 (PDT) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com. [46.33.159.39]) by mx.google.com with ESMTPS id b10si9392485wix.85.2013.05.03.02.53.29 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 03 May 2013 02:53:30 -0700 (PDT) Received-SPF: pass (google.com: domain of Ian.Campbell@citrix.com designates 46.33.159.39 as permitted sender) client-ip=46.33.159.39; X-IronPort-AV: E=Sophos;i="4.87,552,1363132800"; d="scan'208";a="4198173" Received: from lonpmailmx01.citrite.net ([10.30.203.162]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/RC4-MD5; 03 May 2013 09:51:41 +0000 Received: from [10.80.2.42] (10.80.2.42) by LONPMAILMX01.citrite.net (10.30.203.162) with Microsoft SMTP Server id 8.3.298.1; Fri, 3 May 2013 10:53:29 +0100 Message-ID: <1367574808.28742.53.camel@zakaz.uk.xensource.com> Subject: Re: [Xen-devel] [PATCH] build: Conditional build/clean/distclean targets on subsystems From: Ian Campbell To: Jan Beulich CC: "xen-devel@lists.xen.org" , Julien Grall , Ian Jackson , "patches@linaro.org" Date: Fri, 3 May 2013 10:53:28 +0100 In-Reply-To: <1367570585.28742.35.camel@zakaz.uk.xensource.com> References: <1367536673-26300-1-git-send-email-julien.grall@linaro.org> <5183803902000078000D2F2A@nat28.tlf.novell.com> <1367570585.28742.35.camel@zakaz.uk.xensource.com> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.4.4-1 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQmpFV0OSmUXSukTuhPQZAbFB6R5j7wBlNnGMgBVKBoW3zMIol/B3CUzoq6JVSvvDukXOEbc X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::232 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Fri, 2013-05-03 at 09:43 +0100, Ian Campbell wrote: > On Fri, 2013-05-03 at 08:15 +0100, Jan Beulich wrote: > > >>> On 03.05.13 at 01:17, Julien Grall wrote: > > > The commit 3378685 "Add conditional build of subsystems to configure.ac" > > > allows the user to disable/enable some components of Xen. After this commit > > > some targets are still called on every subsystems. > > > > For build this is correct to do, but for any clean target it isn't - clean > > should remove leftovers from earlier builds even if there was an > > intermediate reconfigure. > > Yes, I think so too. > > > > For Xen on ARM, the makefile targets build, clean and distclean will failed. > > > > If they fail, this will need fixing elsewhere then. > > Part of the issue is that there are targets which are simply not ported > to ARM and therefore are missing bits of infrastructure , e.g. mini-os > where one if the clean failures is lack of > extras/mini-os/arch/arm/arch.mk. > > However I think it is wrong to tie the clean/distclean of these into the > configurey selection mechanism, i.e. mini-os should know that it only > support x86 (for the minute) and DTRT when called for ARM (which is > likely to be nothing much). Perhaps a stub > extras/mini-os/arch/arm/arch.mk is the answer? > > The other case is the kernel distclean, which fails with > buildconfigs/mk.linux-2.6-common:32: buildconfigs/src.: No such file or directory > but that seems to fail on x86 too. Having disabled it by default so long > ago perhaps the time has come to simply remove this stuff? I don't know > if anyone is still using it -- the test system perhaps? > > Or it could be fixed with the below, I think. > > Ian. > > 8<--------------------- > > build: fix kernel build rules. > > Rename mk.linux-2.6-common to common.linux-2.6 so that it does not get > included in the ALLKERNELS logic. > > Specify XEN_LINUX_SOURCE for linux-2.6-native, looking at 414614d84e67 > and todays linux-2.6-xen.mk I am guessing that hg-clone of the 2.6.18 > tree is the expected method. To be honest I didn't even try it... > > Signed-off-by: Ian Campbell > --- > NB git diff -M style diff, includes the rename... > > .../{mk.linux-2.6-common => common.linux-2.6} | 0 > buildconfigs/mk.linux-2.6 | 2 +- > buildconfigs/mk.linux-2.6-native | 3 ++- > buildconfigs/mk.linux-2.6-pvops | 2 +- > buildconfigs/mk.linux-2.6-tip-latest | 2 +- > buildconfigs/mk.linux-2.6-xen | 2 +- > 6 files changed, 6 insertions(+), 5 deletions(-) Ahem.... 8<---------------- Acked-by: George Dunlap diff --git a/buildconfigs/mk.linux-2.6-common b/buildconfigs/common.linux-2.6 similarity index 100% rename from buildconfigs/mk.linux-2.6-common rename to buildconfigs/common.linux-2.6 diff --git a/buildconfigs/mk.linux-2.6 b/buildconfigs/mk.linux-2.6 index 6b8d989..6523afb 100644 --- a/buildconfigs/mk.linux-2.6 +++ b/buildconfigs/mk.linux-2.6 @@ -7,4 +7,4 @@ XEN_LINUX_CONFIG_UPDATE := buildconfigs/enable-xen-config EXTRAVERSION ?= -include buildconfigs/mk.linux-2.6-common +include buildconfigs/common.linux-2.6 diff --git a/buildconfigs/mk.linux-2.6-native b/buildconfigs/mk.linux-2.6-native index c7c0949..6e2a77b 100644 --- a/buildconfigs/mk.linux-2.6-native +++ b/buildconfigs/mk.linux-2.6-native @@ -1,5 +1,7 @@ EXTRAVERSION = -native IMAGE_TARGET = bzImage INSTALL_BOOT_PATH = $(DESTDIR)/boot +LINUX_VER ?= 2.6.18 +XEN_LINUX_SOURCE ?= hg-clone -include buildconfigs/mk.linux-2.6-common +include buildconfigs/common.linux-2.6 diff --git a/buildconfigs/mk.linux-2.6-pvops b/buildconfigs/mk.linux-2.6-pvops index 59cae79..9a11c7d 100644 --- a/buildconfigs/mk.linux-2.6-pvops +++ b/buildconfigs/mk.linux-2.6-pvops @@ -14,4 +14,4 @@ XEN_LINUX_GIT_REMOTEBRANCH ?= xen/stable-2.6.32.x EXTRAVERSION ?= -include buildconfigs/mk.linux-2.6-common +include buildconfigs/common.linux-2.6 diff --git a/buildconfigs/mk.linux-2.6-tip-latest b/buildconfigs/mk.linux-2.6-tip-latest index 2a0b9af..158dda0 100644 --- a/buildconfigs/mk.linux-2.6-tip-latest +++ b/buildconfigs/mk.linux-2.6-tip-latest @@ -14,4 +14,4 @@ XEN_LINUX_GIT_REMOTEBRANCH ?= auto-latest EXTRAVERSION ?= -include buildconfigs/mk.linux-2.6-common +include buildconfigs/common.linux-2.6 diff --git a/buildconfigs/mk.linux-2.6-xen b/buildconfigs/mk.linux-2.6-xen index 8594b55..b1facb6 100644 --- a/buildconfigs/mk.linux-2.6-xen +++ b/buildconfigs/mk.linux-2.6-xen @@ -3,4 +3,4 @@ LINUX_VER ?= 2.6.18 XEN_LINUX_SOURCE ?= hg-clone -include buildconfigs/mk.linux-2.6-common +include buildconfigs/common.linux-2.6