From patchwork Tue Sep 2 22:56:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 36533 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f197.google.com (mail-pd0-f197.google.com [209.85.192.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E64FF20C87 for ; Tue, 2 Sep 2014 22:57:08 +0000 (UTC) Received: by mail-pd0-f197.google.com with SMTP id y10sf45005128pdj.0 for ; Tue, 02 Sep 2014 15:57:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=ddTrWpn0IcSiBAKvDwzbxlQ11oifbc8QG1lA1jhn+0I=; b=VmslOMlzGPb2w69B2QKyH5vC2gg+JQOhIsImmnRfO7NZAK7Z9t60JfOQ8bNpM8Jjfo sk+NgnntWLo9K+u7x5Sw237CAnNptowrQ1wcBZPTA1k8fQDCDDpEWkuponsq33douCGu CwwX0W1bSFdUzEE+YvMMryyB5HU3FgFMrM8uFXCU4TlCK7VE7o86OE20WAFj8+mmlYsl EhUJBnAv70DoKVVYi/tmhgQGV6z+rJ3Md8koMAkjIsG7/U9DfUMKwnFVEKHN8zG2ZPa9 NICjfE/PgX6n0rCuOAwIn5gg8VUJxHsbwwHbtq9Vgfrt2miwN26/jgXQWi/BEBn7DPPo vJYg== X-Gm-Message-State: ALoCoQk2b+ODA2wEkfIn/wimU8ADxN9+E/dN6yVhqimm5eT1Cp5V6Dfaj6erUodC0338LgigQHx1 X-Received: by 10.66.221.230 with SMTP id qh6mr7221781pac.9.1409698628234; Tue, 02 Sep 2014 15:57:08 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.108.38 with SMTP id i35ls2599357qgf.76.gmail; Tue, 02 Sep 2014 15:57:08 -0700 (PDT) X-Received: by 10.53.12.225 with SMTP id et1mr26503056vdd.5.1409698628129; Tue, 02 Sep 2014 15:57:08 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id xe15si172755vdc.85.2014.09.02.15.57.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Sep 2014 15:57:08 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id im17so7913896vcb.32 for ; Tue, 02 Sep 2014 15:57:08 -0700 (PDT) X-Received: by 10.220.86.193 with SMTP id t1mr20303823vcl.22.1409698628053; Tue, 02 Sep 2014 15:57:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp596461vcb; Tue, 2 Sep 2014 15:57:07 -0700 (PDT) X-Received: by 10.42.4.136 with SMTP id 8mr10740490ics.57.1409698627123; Tue, 02 Sep 2014 15:57:07 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id n6si146284igj.57.2014.09.02.15.57.06 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 02 Sep 2014 15:57:07 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XOx0V-0001Ch-AO; Tue, 02 Sep 2014 22:56:59 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XOx0T-0001CM-Ar for edk2-devel@lists.sourceforge.net; Tue, 02 Sep 2014 22:56:57 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=lersek@redhat.com; helo=mx1.redhat.com; Received: from mx1.redhat.com ([209.132.183.28]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1XOx0S-0000kT-Fe for edk2-devel@lists.sourceforge.net; Tue, 02 Sep 2014 22:56:57 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s82MuorY008188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 2 Sep 2014 18:56:50 -0400 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-55.ams2.redhat.com [10.36.116.55]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s82MueDZ005138 for ; Tue, 2 Sep 2014 18:56:49 -0400 From: Laszlo Ersek To: edk2-devel@lists.sourceforge.net Date: Wed, 3 Sep 2014 00:56:36 +0200 Message-Id: <1409698598-9766-10-git-send-email-lersek@redhat.com> In-Reply-To: <1409698598-9766-1-git-send-email-lersek@redhat.com> References: <54063964.8060402@redhat.com> <1409698598-9766-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Spam-Score: -3.2 (---) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1XOx0S-0000kT-Fe Subject: [edk2] [PATCH 10/12] OvmfPkg: SerializeVariablesLib: add constructor X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lersek@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Calls to constructors of interdependent library instances are generated in the correct order only if all library instances in question have constructors. If some have no constructors, then the rest may see their constructors called out of order. Cycle detection also only works when all library instances have constructors. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- .../Library/SerializeVariablesLib/SerializeVariablesLib.inf | 2 ++ OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.c | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf b/OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf index b0c12b0..baec28e 100644 --- a/OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf +++ b/OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf @@ -22,6 +22,8 @@ VERSION_STRING = 1.0 LIBRARY_CLASS = SerializeVariablesLib|DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER UEFI_DRIVER + CONSTRUCTOR = DxeSerializeVariablesLibConstructor + [Sources] SerializeVariablesLib.c diff --git a/OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.c b/OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.c index 19569b2..dfff3a2 100644 --- a/OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.c +++ b/OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.c @@ -868,3 +868,13 @@ SerializeVariablesToBuffer ( return RETURN_SUCCESS; } + +EFI_STATUS +EFIAPI +DxeSerializeVariablesLibConstructor ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + return EFI_SUCCESS; +}