From patchwork Mon Sep 2 07:13:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 19669 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f198.google.com (mail-ve0-f198.google.com [209.85.128.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F069224869 for ; Mon, 2 Sep 2013 07:13:41 +0000 (UTC) Received: by mail-ve0-f198.google.com with SMTP id 15sf5031027vea.5 for ; Mon, 02 Sep 2013 00:13:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=LslJUABGu0qeLfafdfei3AOy1QQcVAtEuFwhBMT763c=; b=bCWwchYEjb9FhSNmDjU24MZNeaDVfUHqgtvE29u+JnXAE20qDMntxWXRntBBNi2+Ir Qm3V/0hVKce+VUWlt+ftsphT7OhurkDSeCYURyN/4Sz35BBOeoCL4QodLuXKHR1w2pMi tLyNLo5DRScu2tp7eLQp8MW40o0soeIR2c0QFWPy5uMARi9k5l+8LsKTaXAntS2HYDfG v3qb6qn/SMp3hcIRvGTkMJn6UxmMJQsOK4G/psevLg367g/ob0D4urUpxsyGOvqlH7IC VgokKkSsbGKEIQQ4mQ+cydnLbpOfnaWldqbevmwJ3MgTOxlkHJGPdYo5Gio5Jokv84J8 aQ/g== X-Received: by 10.236.153.39 with SMTP id e27mr7782849yhk.14.1378106021194; Mon, 02 Sep 2013 00:13:41 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.4.41 with SMTP id h9ls2081443qeh.79.gmail; Mon, 02 Sep 2013 00:13:41 -0700 (PDT) X-Received: by 10.58.146.71 with SMTP id ta7mr730890veb.23.1378106021066; Mon, 02 Sep 2013 00:13:41 -0700 (PDT) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx.google.com with ESMTPS id tg9si2822145vcb.107.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Sep 2013 00:13:41 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.169; Received: by mail-ve0-f169.google.com with SMTP id db10so2960326veb.28 for ; Mon, 02 Sep 2013 00:13:41 -0700 (PDT) X-Gm-Message-State: ALoCoQnLRXOx6BxIzolgWG4iGfOk1hHIgaw1pPBXJ8j7hYrMJkwDyOBVoCzm9LoufruYFPsoIscE X-Received: by 10.220.186.202 with SMTP id ct10mr22125957vcb.14.1378106020994; Mon, 02 Sep 2013 00:13:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp99239vcz; Mon, 2 Sep 2013 00:13:40 -0700 (PDT) X-Received: by 10.182.247.68 with SMTP id yc4mr15943081obc.67.1378106019906; Mon, 02 Sep 2013 00:13:39 -0700 (PDT) Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com [209.85.214.181]) by mx.google.com with ESMTPS id f9si5269277obv.62.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Sep 2013 00:13:39 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.214.181 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.214.181; Received: by mail-ob0-f181.google.com with SMTP id dn14so4234646obc.12 for ; Mon, 02 Sep 2013 00:13:39 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.84.132 with SMTP id z4mr16111104oby.49.1378106019256; Mon, 02 Sep 2013 00:13:39 -0700 (PDT) Received: by 10.182.28.168 with HTTP; Mon, 2 Sep 2013 00:13:39 -0700 (PDT) In-Reply-To: References: Date: Mon, 2 Sep 2013 12:43:39 +0530 Message-ID: Subject: Re: [LNG] Re: [ovs-dev] datapath: remove HAVE_MAC_RAW From: Viresh Kumar To: Jesse Gross Cc: "dev@openvswitch.org" , Linaro Networking , Patch Tracking X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 31 August 2013 05:45, Jesse Gross wrote: > Out of curiosity, what is the actual symbol that we're finding in the RT kernel? Its not about RT kernel really.. Following patch did this: b0e380b [SK_BUFF]: unions of just one member don't get anything done, kill them + unsigned char *network_header; + unsigned char *mac_header; struct dst_entry *dst; struct sec_path *sp; -------x--------------------x---------------- This is why we have code in OVS repo which searches just for "raw" keyword and things used to work well... But in RT kernel we have few usages of "raw"... viresh@blr-linut-001:$ ggrep raw include/linux/skbuff.h include/linux/skbuff.h: raw_spinlock_t raw_lock; include/linux/skbuff.h:static inline void skb_queue_head_init_raw(struct sk_buff_head *list) include/linux/skbuff.h: raw_spin_lock_init(&list->raw_lock); And this causes confusion to our script.. And so I am trying to search for "*raw;" to make the search more accurate :) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 230dd43..c45ad12 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -69,8 +69,8 @@ [snip] @@ -236,18 +236,9 @@ struct sk_buff { int iif; /* 4 byte hole on 64 bit*/ - union { - unsigned char *raw; - } h; - - union { - unsigned char *raw; - } nh; - - union { - unsigned char *raw; - } mac; - + unsigned char *transport_header;