From patchwork Sun Oct 4 00:52:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: 'Timothy Arceri' via Patchwork Forward X-Patchwork-Id: 54485 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by patches.linaro.org (Postfix) with ESMTPS id 0E7A6218EF for ; Sun, 4 Oct 2015 00:52:21 +0000 (UTC) Received: by laff3 with SMTP id f3sf4770294laf.0 for ; Sat, 03 Oct 2015 17:52:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list:reply-to; bh=yIqzRiho/6xJoMH6xnc76FoRVLonav9mimCFc9l7gRw=; b=JENQXnuXPNo5Un56UN8nVpP3mK4UAZow+Oh98N98I9+AV9PwY8wZwYf4RpAWDWKUW3 PeAvA7QTbDGMaIGngwqTgyma7SAhnKhN2uqVodkMRT7im9bxMF092c44GmFJLs6BdzvK 1OeBh/tyuBUK+Nd4Z84iMn2x5lp3qiGMXPAeIwp1YQflK8wylvr+hnCXMBN/Y+shMJcv w+R3vkwv9BBVVfIfdgA0S9xnCXJdIPuxU5Oo1DJseLrw0D2H8QR1PBDYNufvNHHomhJg yBmrXRFXyU0lWr9laFfZHbcPjnba8o8oDXycOfzm5fL+AmhteXPPRDjW3RdI4WRtQH4U G9nA== X-Gm-Message-State: ALoCoQlfq5Pc432I7fsfnnPFail/T1ye+qSMRhZz7EVhlyKxAyCRmj28bjPeDrsWTYY8+VO6BeJH X-Received: by 10.112.136.99 with SMTP id pz3mr2378114lbb.11.1443919938907; Sat, 03 Oct 2015 17:52:18 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.44.12 with SMTP id s12ls137000lfs.90.gmail; Sat, 03 Oct 2015 17:52:18 -0700 (PDT) X-Received: by 10.112.180.198 with SMTP id dq6mr8423323lbc.90.1443919938803; Sat, 03 Oct 2015 17:52:18 -0700 (PDT) Received: from mail-lb0-x234.google.com (mail-lb0-x234.google.com. [2a00:1450:4010:c04::234]) by mx.google.com with ESMTPS id xe5si11501369lbb.65.2015.10.03.17.52.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Oct 2015 17:52:18 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::234 as permitted sender) client-ip=2a00:1450:4010:c04::234; Received: by lbwr8 with SMTP id r8so42063497lbw.2 for ; Sat, 03 Oct 2015 17:52:18 -0700 (PDT) X-Received: by 10.25.205.198 with SMTP id d189mr5456096lfg.72.1443919938479; Sat, 03 Oct 2015 17:52:18 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp505392lbq; Sat, 3 Oct 2015 17:52:17 -0700 (PDT) X-Received: by 10.68.92.164 with SMTP id cn4mr9658329pbb.156.1443919936916; Sat, 03 Oct 2015 17:52:16 -0700 (PDT) Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTP id yt1si28488300pab.45.2015.10.03.17.52.16; Sat, 03 Oct 2015 17:52:16 -0700 (PDT) Received-SPF: pass (google.com: domain of piglit-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 177E86E5A8; Sat, 3 Oct 2015 17:52:16 -0700 (PDT) X-Original-To: piglit@lists.freedesktop.org Delivered-To: piglit@lists.freedesktop.org Received: from nm30-vm6.bullet.mail.gq1.yahoo.com (nm30-vm6.bullet.mail.gq1.yahoo.com [98.136.216.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id E006F6E5A8 for ; Sat, 3 Oct 2015 17:52:14 -0700 (PDT) Received: from [216.39.60.184] by nm30.bullet.mail.gq1.yahoo.com with NNFMP; 04 Oct 2015 00:52:12 -0000 Received: from [98.136.164.71] by tm20.bullet.mail.gq1.yahoo.com with NNFMP; 04 Oct 2015 00:52:12 -0000 Received: from [127.0.0.1] by smtp233.mail.gq1.yahoo.com with NNFMP; 04 Oct 2015 00:52:12 -0000 X-Yahoo-Newman-Id: 935980.92716.bm@smtp233.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: rSNFWBAVM1lkLZ1QrVimbxekXuJaMBiTOvoc_uw0GBlZ2BX tzGKeQkHu2Lsk_6glpSlMFsAh5ygpQX_7IMtyt.bup4lpPhea4Ym3vfJiuk5 pn3OGoo.mUabargafBNMnvFmiqjtiRI2yq47.xIFAJ4cfQFJGCiKGrKc_PtV EDx9U8dgsvQICEkeQT5_oMi4FbzeY7DMvSNVNgwSu2J9ruqfRgaLfcaIDZ2g kM1jvucu6lHpqz107ZO3snmvi.bnMbeV0bBKS04rCMNByUECBupbgfyIvUXW cxrCRxTpEE13xxhSi58Yz4IEsUsVZwdQ4s1mRefcMbGDvoFTUGLLY8EXBI_z 6A.SGM5RY9LDfU5kP_4cjsH5fzi0qo6dNQbQ_7Jyjsml40bTBMAoKQxBxFbH VeZeLU.jEr0h8KliclsjcGYouNOhPuqr2QliIbzd6eGf1dIGRO_IPzx53.r1 2sMEwqd3hkmk37RxtpjuVNyEOchhctCUJVdeb5Ekpim6l2ZVNZhVNVNVcdw0 XLzYrGTAnxuonzdQEFLbV.7f6bLlzeF4- X-Yahoo-SMTP: 9BNlx.aswBAkr0D8mG_whiOP1dyU From: "'Timothy Arceri' via Patchwork Forward" To: piglit@lists.freedesktop.org Date: Sun, 4 Oct 2015 11:52:06 +1100 Message-Id: <1443919926-16815-1-git-send-email-t_arceri@yahoo.com.au> X-Mailer: git-send-email 2.4.3 Subject: [Piglit] [PATCH] arb_shader_atomic_counters: add error output if uniform not found X-BeenThere: piglit@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: piglit-bounces@lists.freedesktop.org Sender: "Piglit" X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::234 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=neutral (body hash did not verify) header.i=@yahoo.com.au; dmarc=fail (p=NONE dis=NONE) header.from=yahoo.com.au Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 X-Original-From: Timothy Arceri Reply-To: Timothy Arceri Cc: Francisco Jerez Reviewed-by: Francisco Jerez --- For some reason the lookup of this uniform is the only test that is failing with my intra-stage atomic index Mesa patches. I haven't looked into why yet but this will help debugging any problems in future. tests/spec/arb_shader_atomic_counters/array-indexing.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_shader_atomic_counters/array-indexing.c b/tests/spec/arb_shader_atomic_counters/array-indexing.c index 030ab58..354a432 100644 --- a/tests/spec/arb_shader_atomic_counters/array-indexing.c +++ b/tests/spec/arb_shader_atomic_counters/array-indexing.c @@ -19,7 +19,7 @@ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS * IN THE SOFTWARE. - */ + / /** @file array-indexing.c * @@ -48,8 +48,11 @@ set_uniform_int(GLuint prog, const char *name, int value) glUseProgram(prog); loc = glGetUniformLocation(prog, name); - if (loc < 0) + if (loc < 0) { + fprintf(stderr, "Failed to get location for uniform '%s'.\n", + name); return false; + } glUniform1i(loc, value);