mbox series

[v2,0/5] target/mips: Misc patches

Message ID 1602103041-32017-1-git-send-email-aleksandar.qemu.devel@gmail.com
Headers show
Series target/mips: Misc patches | expand

Message

Aleksandar Markovic Oct. 7, 2020, 8:37 p.m. UTC
A set of several, mostly FP, refactorings and improvements.

v1->v2:

  - added a patch on MAINTAINERS

Aleksandar Markovic (5):
  target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS>
  target/mips: Demacro helpers for M<ADD|SUB>F.<D|S>
  target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S>
  target/mips: Refactor helpers for fp comparison instructions
  MAINTAINERS: Remove myself

 target/mips/fpu_helper.c | 276 +++++++++++++++++++++++++++++++++--------------
 MAINTAINERS              |  17 +--
 2 files changed, 200 insertions(+), 93 deletions(-)

Comments

Philippe Mathieu-Daudé Oct. 8, 2020, 10:51 a.m. UTC | #1
On 10/8/20 12:21 PM, Philippe Mathieu-Daudé wrote:
> On 10/8/20 9:21 AM, chen huacai wrote:
>> Hi, Aleksandar,
>>
>> On Thu, Oct 8, 2020 at 4:40 AM Aleksandar Markovic
>> <aleksandar.qemu.devel@gmail.com> wrote:
>>>
>>> I have been working on project other than QEMU for some time, and would
>>> like to devote myself to that project. It is imposible for me to find
>>> enough time to perform maintainer's duties with needed meticulousness
>>> and patience.
> 
> Thanks Aleksandar for your contributions and keeping MIPS in good
> shape during 2 years!
> 
>>>
>>> I wish prosperous future to QEMU and all colegues in QEMU community.
>> I'm very sorry to hear that. I hope you can be still here if possible...
>> I found that there are many reviewers, so, if it is a must that
>> Aleksandar will leave us, can these reviewers be maintainers?

Note the problem with QEMU MIPS is not there is few maintainers,
is really there are no reviewers... See, there are about 25 patches
unreviewed on the list since various weeks. I don't have problem
merging/testing them once reviewed and doing maintenance, but I
can not review them all (in particular the one I send...).

Maintaining is not about merging your own area patches, it is
also about trying to understand what the other are doing,
eventually having to verify the specs, understand the use case,
and so on. Like I intend to do with your Loongson-3 series.

Note that I do that in my free time, and I certainly do not want
to be the single maintainer, I don't have the bandwidth.

> 
> Thanks for volunteering! Aleksandar Rikalo hasn't sent anything
> to the list since 4 months. Is Jiaxun Yang also volunteering?
> 
> Regards,
> 
> Phil.
> 
>>
>> Huacai
>>>
>>> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>> ---
>>>  MAINTAINERS | 17 +++++------------
>>>  1 file changed, 5 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index e9d85cc..426f52c 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -221,11 +221,10 @@ F: hw/microblaze/
>>>  F: disas/microblaze.c
>>>
>>>  MIPS TCG CPUs
>>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>>  R: Aurelien Jarno <aurelien@aurel32.net>
>>>  R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
>>> -S: Maintained
>>> +S: Orphaned
>>>  F: target/mips/
>>>  F: default-configs/*mips*
>>>  F: disas/*mips*
>>> @@ -387,7 +386,6 @@ F: target/arm/kvm.c
>>>
>>>  MIPS KVM CPUs
>>>  M: Huacai Chen <chenhc@lemote.com>
>>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>>  S: Odd Fixes
>>>  F: target/mips/kvm.c
>>>
>>> @@ -1124,10 +1122,9 @@ F: hw/display/jazz_led.c
>>>  F: hw/dma/rc4030.c
>>>
>>>  Malta
>>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>>  M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>  R: Aurelien Jarno <aurelien@aurel32.net>
>>> -S: Maintained
>>> +S: Odd Fixes
>>>  F: hw/isa/piix4.c
>>>  F: hw/acpi/piix4.c
>>>  F: hw/mips/malta.c
>>> @@ -1137,14 +1134,12 @@ F: tests/acceptance/linux_ssh_mips_malta.py
>>>  F: tests/acceptance/machine_mips_malta.py
>>>
>>>  Mipssim
>>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
>>> -S: Odd Fixes
>>> +S: Orphaned
>>>  F: hw/mips/mipssim.c
>>>  F: hw/net/mipsnet.c
>>>
>>>  R4000
>>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>>  R: Aurelien Jarno <aurelien@aurel32.net>
>>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
>>>  S: Obsolete
>>> @@ -1153,7 +1148,6 @@ F: hw/mips/r4k.c
>>>  Fuloong 2E
>>>  M: Huacai Chen <chenhc@lemote.com>
>>>  M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>>  R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>>  S: Odd Fixes
>>>  F: hw/mips/fuloong2e.c
>>> @@ -2821,12 +2815,11 @@ F: tcg/i386/
>>>  F: disas/i386.c
>>>
>>>  MIPS TCG target
>>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>>  R: Aurelien Jarno <aurelien@aurel32.net>
>>>  R: Huacai Chen <chenhc@lemote.com>
>>>  R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>>  R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
>>> -S: Maintained
>>> +S: Orphaned
>>>  F: tcg/mips/
>>>
>>>  PPC TCG target
>>> @@ -3167,7 +3160,7 @@ S: Odd Fixes
>>>  F: scripts/git-submodule.sh
>>>
>>>  UI translations
>>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>>> +S: Orphaned
>>>  F: po/*.po
>>>
>>>  Sphinx documentation configuration and build machinery
>>> --
>>> 2.7.4
>>>
>>>
>>
>>
>
Jiaxun Yang Oct. 9, 2020, 2:52 a.m. UTC | #2
在 2020/10/8 18:21, Philippe Mathieu-Daudé 写道:
> On 10/8/20 9:21 AM, chen huacai wrote:
>> Hi, Aleksandar,
>>
>> On Thu, Oct 8, 2020 at 4:40 AM Aleksandar Markovic
>> <aleksandar.qemu.devel@gmail.com> wrote:
>>> I have been working on project other than QEMU for some time, and would
>>> like to devote myself to that project. It is imposible for me to find
>>> enough time to perform maintainer's duties with needed meticulousness
>>> and patience.
> Thanks Aleksandar for your contributions and keeping MIPS in good
> shape during 2 years!
>
>>> I wish prosperous future to QEMU and all colegues in QEMU community.
>> I'm very sorry to hear that. I hope you can be still here if possible...
>> I found that there are many reviewers, so, if it is a must that
>> Aleksandar will leave us, can these reviewers be maintainers?
> Thanks for volunteering! Aleksandar Rikalo hasn't sent anything
> to the list since 4 months. Is Jiaxun Yang also volunteering?

Hi all,

Thanks for the inviation.
I'm busy with real world recently (probably until Dec) so I can't 
promise anything.

But I can start with helping reviewing blocking patches.

- Jiaxun

> Regards,
>
> Phil.
>
Philippe Mathieu-Daudé Oct. 9, 2020, 3 p.m. UTC | #3
On 10/7/20 10:37 PM, Aleksandar Markovic wrote:
> A set of several, mostly FP, refactorings and improvements.
> 
> v1->v2:
> 
>    - added a patch on MAINTAINERS
> 
> Aleksandar Markovic (5):
>    target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS>
>    target/mips: Demacro helpers for M<ADD|SUB>F.<D|S>
>    target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S>
>    target/mips: Refactor helpers for fp comparison instructions
>    MAINTAINERS: Remove myself

Thanks, patches 1-3 & 5 applied to mips-next tree.