mbox series

[PULL,v2,00/20] Queued TCG patches

Message ID 20171010193003.28857-1-richard.henderson@linaro.org
Headers show
Series Queued TCG patches | expand

Message

Richard Henderson Oct. 10, 2017, 7:29 p.m. UTC 
One trivial cleanup from Jiang.  Cherry-picking half of Emilio's
patch set that has been reviewed.

Changes since v1:
  * Dropped 2 mprotect changes that Werrored on w32.
  * Dropped tcg optimize patch that broke arm32 host.


r~


The following changes since commit 567d0a19c7998fa366598b83d5a6e5f0759d3ea9:

  Merge remote-tracking branch 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-10-10 13:25:46 +0100)

are available in the git repository at:

  git://github.com/rth7680/qemu.git tags/pull-tcg-20171010

for you to fetch changes up to 8df8d529ed958de4e23dcbf38bd34eff1a4716f2:

  tcg/mips: delete commented out extern keyword. (2017-10-10 09:45:01 -0700)

----------------------------------------------------------------
Queued TCG patches

----------------------------------------------------------------
Emilio G. Cota (19):
      cputlb: bring back tlb_flush_count under !TLB_DEBUG
      tcg: fix corruption of code_time profiling counter upon tb_flush
      exec-all: fix typos in TranslationBlock's documentation
      translate-all: make have_tb_lock static
      cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find
      tcg/i386: constify tcg_target_callee_save_regs
      tcg/mips: constify tcg_target_callee_save_regs
      tcg: remove addr argument from lookup_tb_ptr
      tcg: consolidate TB lookups in tb_lookup__cpu_state
      exec-all: bring tb->invalid into tb->cflags
      translate-all: define and use DEBUG_TB_FLUSH_GATE
      exec-all: introduce TB_PAGE_ADDR_FMT
      translate-all: define and use DEBUG_TB_INVALIDATE_GATE
      translate-all: define and use DEBUG_TB_CHECK_GATE
      exec-all: extract tb->tc_* into a separate struct tc_tb
      tci: move tci_regs to tcg_qemu_tb_exec's stack
      tcg: take .helpers out of TCGContext
      util: move qemu_real_host_page_size/mask to osdep.h
      tcg: define TCG_HIGHWATER

Jiang Biao (1):
      tcg/mips: delete commented out extern keyword.

 accel/tcg/tcg-runtime.h    |   2 +-
 include/exec/cpu-all.h     |   2 -
 include/exec/cpu-defs.h    |   1 +
 include/exec/cputlb.h      |   3 +-
 include/exec/exec-all.h    |  19 +-
 include/exec/tb-lookup.h   |  49 ++++
 include/qemu/osdep.h       |   6 +
 tcg/tcg-op.h               |   4 +-
 tcg/tcg.h                  |   2 -
 accel/tcg/cpu-exec.c       |  73 +++---
 accel/tcg/cputlb.c         |  17 +-
 accel/tcg/tcg-runtime.c    |  34 +--
 accel/tcg/translate-all.c  |  96 +++++---
 exec.c                     |   4 -
 target/alpha/translate.c   |   2 +-
 target/arm/translate-a64.c |   4 +-
 target/arm/translate.c     |   5 +-
 target/hppa/translate.c    |   6 +-
 target/i386/translate.c    |  17 +-
 target/mips/translate.c    |   4 +-
 target/s390x/translate.c   |   2 +-
 target/sh4/translate.c     |   4 +-
 tcg/i386/tcg-target.inc.c  |   2 +-
 tcg/mips/tcg-target.inc.c  |   4 +-
 tcg/tcg-op.c               |   4 +-
 tcg/tcg.c                  |  18 +-
 tcg/tci.c                  | 552 +++++++++++++++++++++++----------------------
 util/pagesize.c            |  18 ++
 util/Makefile.objs         |   1 +
 29 files changed, 521 insertions(+), 434 deletions(-)
 create mode 100644 include/exec/tb-lookup.h
 create mode 100644 util/pagesize.c

Comments

no-reply@patchew.org Oct. 11, 2017, 12:22 a.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20171010193003.28857-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PULL v2 00/20] Queued TCG patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3bdf71c8cc tcg/mips: delete commented out extern keyword.
b6db70242c tcg: define TCG_HIGHWATER
8110aaa390 util: move qemu_real_host_page_size/mask to osdep.h
3b52eb07c3 tcg: take .helpers out of TCGContext
a1956949ff tci: move tci_regs to tcg_qemu_tb_exec's stack
4108e03598 exec-all: extract tb->tc_* into a separate struct tc_tb
2565c32cab translate-all: define and use DEBUG_TB_CHECK_GATE
be8d38903e translate-all: define and use DEBUG_TB_INVALIDATE_GATE
501c9fcf6e exec-all: introduce TB_PAGE_ADDR_FMT
4cc8ef863e translate-all: define and use DEBUG_TB_FLUSH_GATE
6a61ad246b exec-all: bring tb->invalid into tb->cflags
1fa8a382ef tcg: consolidate TB lookups in tb_lookup__cpu_state
b35dbd37fa tcg: remove addr argument from lookup_tb_ptr
8e09f17d21 tcg/mips: constify tcg_target_callee_save_regs
c6f520348a tcg/i386: constify tcg_target_callee_save_regs
41a8d06218 cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find
3293107b44 translate-all: make have_tb_lock static
ad863faa4a exec-all: fix typos in TranslationBlock's documentation
8f10ba2c46 tcg: fix corruption of code_time profiling counter upon tb_flush
7fb10a792f cputlb: bring back tlb_flush_count under !TLB_DEBUG

=== OUTPUT BEGIN ===
Checking PATCH 1/20: cputlb: bring back tlb_flush_count under !TLB_DEBUG...
Checking PATCH 2/20: tcg: fix corruption of code_time profiling counter upon tb_flush...
Checking PATCH 3/20: exec-all: fix typos in TranslationBlock's documentation...
Checking PATCH 4/20: translate-all: make have_tb_lock static...
Checking PATCH 5/20: cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find...
Checking PATCH 6/20: tcg/i386: constify tcg_target_callee_save_regs...
Checking PATCH 7/20: tcg/mips: constify tcg_target_callee_save_regs...
Checking PATCH 8/20: tcg: remove addr argument from lookup_tb_ptr...
Checking PATCH 9/20: tcg: consolidate TB lookups in tb_lookup__cpu_state...
Checking PATCH 10/20: exec-all: bring tb->invalid into tb->cflags...
Checking PATCH 11/20: translate-all: define and use DEBUG_TB_FLUSH_GATE...
Checking PATCH 12/20: exec-all: introduce TB_PAGE_ADDR_FMT...
Checking PATCH 13/20: translate-all: define and use DEBUG_TB_INVALIDATE_GATE...
Checking PATCH 14/20: translate-all: define and use DEBUG_TB_CHECK_GATE...
Checking PATCH 15/20: exec-all: extract tb->tc_* into a separate struct tc_tb...
Checking PATCH 16/20: tci: move tci_regs to tcg_qemu_tb_exec's stack...
Checking PATCH 17/20: tcg: take .helpers out of TCGContext...
Checking PATCH 18/20: util: move qemu_real_host_page_size/mask to osdep.h...
Checking PATCH 19/20: tcg: define TCG_HIGHWATER...
Checking PATCH 20/20: tcg/mips: delete commented out extern keyword....
ERROR: externs should be avoided in .c files
#22: FILE: tcg/mips/tcg-target.inc.c:39:
+int link_error(void);

total: 1 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Peter Maydell Oct. 11, 2017, 12:06 p.m. UTC | #2 
On 10 October 2017 at 20:29, Richard Henderson
<richard.henderson@linaro.org> wrote:
> One trivial cleanup from Jiang.  Cherry-picking half of Emilio's

> patch set that has been reviewed.

>

> Changes since v1:

>   * Dropped 2 mprotect changes that Werrored on w32.

>   * Dropped tcg optimize patch that broke arm32 host.

>

>

> r~

>

>

> The following changes since commit 567d0a19c7998fa366598b83d5a6e5f0759d3ea9:

>

>   Merge remote-tracking branch 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-10-10 13:25:46 +0100)

>

> are available in the git repository at:

>

>   git://github.com/rth7680/qemu.git tags/pull-tcg-20171010

>

> for you to fetch changes up to 8df8d529ed958de4e23dcbf38bd34eff1a4716f2:

>

>   tcg/mips: delete commented out extern keyword. (2017-10-10 09:45:01 -0700)

>

> ----------------------------------------------------------------

> Queued TCG patches

>


Applied, thanks.

-- PMM