| Message ID | 20171109075243.4794-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | Capstone updates | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL for-2.11 0/2] Capstone updates
Type: series
Message-id: 20171109075243.4794-1-richard.henderson@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20171109075243.4794-1-richard.henderson@linaro.org -> patchew/20171109075243.4794-1-richard.henderson@linaro.org
Switched to a new branch 'test'
7202d02907 Makefile: Capstone: Add support for cross compile ranlib
c6dc01dedb disas: Dump insn bytes along with capstone disassembly
=== OUTPUT BEGIN ===
Checking PATCH 1/2: disas: Dump insn bytes along with capstone disassembly...
ERROR: suspect code indent for conditional statements (8, 11)
#98: FILE: disas.c:315:
while (cs_disasm_iter(handle, &cbuf, &csize, &pc, insn)) {
+ cap_dump_insn(info, insn);
ERROR: suspect code indent for conditional statements (4, 7)
#110: FILE: disas.c:360:
while (cs_disasm_iter(handle, &cbuf, &size, &pc, insn)) {
+ cap_dump_insn(info, insn);
total: 2 errors, 0 warnings, 184 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/2: Makefile: Capstone: Add support for cross compile ranlib...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 9 November 2017 at 07:52, Richard Henderson <richard.henderson@linaro.org> wrote: > One build fix for mingw cross-compiling, one feature regression fix. > > > r~ > > > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +0000) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-cap-20171109 > > for you to fetch changes up to 9f81aeb5dadab588920b157a4610e890995ef4b9: > > Makefile: Capstone: Add support for cross compile ranlib (2017-11-09 08:47:14 +0100) > > ---------------------------------------------------------------- > Capstone fixes for 2.11 > > ---------------------------------------------------------------- > Alistair Francis (1): > Makefile: Capstone: Add support for cross compile ranlib > > Richard Henderson (1): > disas: Dump insn bytes along with capstone disassembly > Applied, thanks. -- PMM
One build fix for mingw cross-compiling, one feature regression fix. r~ The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +0000) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-cap-20171109 for you to fetch changes up to 9f81aeb5dadab588920b157a4610e890995ef4b9: Makefile: Capstone: Add support for cross compile ranlib (2017-11-09 08:47:14 +0100) ---------------------------------------------------------------- Capstone fixes for 2.11 ---------------------------------------------------------------- Alistair Francis (1): Makefile: Capstone: Add support for cross compile ranlib Richard Henderson (1): disas: Dump insn bytes along with capstone disassembly Makefile | 2 +- include/disas/bfd.h | 2 ++ disas.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++------- target/arm/cpu.c | 6 ++++ target/i386/cpu.c | 2 ++ configure | 3 ++ 6 files changed, 98 insertions(+), 13 deletions(-)