mbox series

[00/13] target/openrisc: Convert to decodetree.py

Message ID 20180504054030.24527-1-richard.henderson@linaro.org
Headers show
Series target/openrisc: Convert to decodetree.py | expand

Message

Richard Henderson May 4, 2018, 5:40 a.m. UTC 
While the openrisc decode isn't particularly complicated,
the result, I think, is still cleaner.


r~


Richard Henderson (13):
  target-openrisc: Write back result before FPE exception
  target/openrisc: Start conversion to decodetree.py
  target/openrisc: Convert branch insns
  target/openrisc: Convert memory insns
  target/openrisc: Convert remainder of dec_misc insns
  target/openrisc: Convert dec_calc
  target/openrisc: Convert dec_mac
  target/openrisc: Convert dec_logic
  target/openrisc: Convert dec_M
  target/openrisc: Convert dec_comp
  target/openrisc: Convert dec_compi
  target/openrisc: Convert dec_float
  target/openrisc: Merge disas_openrisc_insn

 target/openrisc/helper.h      |   25 +-
 target/openrisc/fpu_helper.c  |  250 ++----
 target/openrisc/translate.c   | 1847 +++++++++++++++++++----------------------
 target/openrisc/Makefile.objs |    9 +
 target/openrisc/insns.decode  |  189 +++++
 5 files changed, 1110 insertions(+), 1210 deletions(-)
 create mode 100644 target/openrisc/insns.decode

-- 
2.14.3

Comments

Stafford Horne May 5, 2018, 5:49 a.m. UTC | #1 
On Thu, May 03, 2018 at 10:40:17PM -0700, Richard Henderson wrote:
> While the openrisc decode isn't particularly complicated,

> the result, I think, is still cleaner.


Hi Richard,

I agree this does look clean, thanks for doing this.

I reviewed all and everything seems good, do you plan to send the PR during the
merge window?

-Stafford

> 

> r~

> 

> 

> Richard Henderson (13):

>   target-openrisc: Write back result before FPE exception

>   target/openrisc: Start conversion to decodetree.py

>   target/openrisc: Convert branch insns

>   target/openrisc: Convert memory insns

>   target/openrisc: Convert remainder of dec_misc insns

>   target/openrisc: Convert dec_calc

>   target/openrisc: Convert dec_mac

>   target/openrisc: Convert dec_logic

>   target/openrisc: Convert dec_M

>   target/openrisc: Convert dec_comp

>   target/openrisc: Convert dec_compi

>   target/openrisc: Convert dec_float

>   target/openrisc: Merge disas_openrisc_insn

> 

>  target/openrisc/helper.h      |   25 +-

>  target/openrisc/fpu_helper.c  |  250 ++----

>  target/openrisc/translate.c   | 1847 +++++++++++++++++++----------------------

>  target/openrisc/Makefile.objs |    9 +

>  target/openrisc/insns.decode  |  189 +++++

>  5 files changed, 1110 insertions(+), 1210 deletions(-)

>  create mode 100644 target/openrisc/insns.decode

> 

> -- 

> 2.14.3

>
Richard Henderson May 5, 2018, 3:15 p.m. UTC | #2 
On 05/04/2018 10:49 PM, Stafford Horne wrote:
> I reviewed all and everything seems good, do you plan to send the PR during the

> merge window?


Yes, I can do that.


r~