| Message ID | 20180531224911.23725-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | linux-user: Reorg interp_prefix handling | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180531224911.23725-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v5 0/6] linux-user: Reorg interp_prefix handling
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180531224911.23725-1-richard.henderson@linaro.org -> patchew/20180531224911.23725-1-richard.henderson@linaro.org
Switched to a new branch 'test'
2755fa1986 linux-user: Use *at functions to implement interp_prefix
8af5f75489 linux-user: Check is_hostfd in mmap syscalls
83374c532a linux-user: Check contains_hostfd in select syscalls
41b80ec144 linux-user: Check is_hostfd in do_syscall
fb3aa3a0d8 linux-user: Add host_fds and manipulators
11567891c5 gdbstub: Return the fd from gdbserver_start
=== OUTPUT BEGIN ===
Checking PATCH 1/6: gdbstub: Return the fd from gdbserver_start...
Checking PATCH 2/6: linux-user: Add host_fds and manipulators...
Checking PATCH 3/6: linux-user: Check is_hostfd in do_syscall...
Checking PATCH 4/6: linux-user: Check contains_hostfd in select syscalls...
Checking PATCH 5/6: linux-user: Check is_hostfd in mmap syscalls...
Checking PATCH 6/6: linux-user: Use *at functions to implement interp_prefix...
ERROR: do not use assignment in if condition
#200: FILE: linux-user/syscall.c:8541:
+ if (!(fn = lock_user_string(arg2))) {
ERROR: do not use assignment in if condition
#218: FILE: linux-user/syscall.c:8562:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#236: FILE: linux-user/syscall.c:8577:
+ if (!(fn = lock_user_string(arg2))) {
ERROR: do not use assignment in if condition
#254: FILE: linux-user/syscall.c:8735:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#333: FILE: linux-user/syscall.c:9769:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#349: FILE: linux-user/syscall.c:9809:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#365: FILE: linux-user/syscall.c:10099:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#380: FILE: linux-user/syscall.c:10111:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#398: FILE: linux-user/syscall.c:11303:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#415: FILE: linux-user/syscall.c:11317:
+ if (!(fn = lock_user_string(arg1))) {
ERROR: do not use assignment in if condition
#433: FILE: linux-user/syscall.c:11349:
+ if (!(fn = lock_user_string(arg2))) {
ERROR: do not use assignment in if condition
#452: FILE: linux-user/syscall.c:12394:
+ if (!(fn = lock_user_string(arg2))) {
ERROR: do not use assignment in if condition
#472: FILE: linux-user/syscall.c:12433:
+ if (!(fn = lock_user_string(arg2))) {
total: 13 errors, 0 warnings, 423 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Changes since v4 (2018-01-28) * Protect host fds from guest manipulation. * Rename the interp_dirfd macro to TRY_INTERP_FD * Add TRY_INTERP_PATH for acct, statfs, inotify_add_watch Changes since v3 (2017-12-29) * Use DO/WHILE as the control construct; wrap it in a macro. * Introduce linux_user_path to handle the cases *at syscalls do not cover. Changes since v2 (2017-12-04) * Use IF as the control construct instead of SWITCH. Changes since v1 (2016-11-??) * Require interp_dirfd set before trying the *at path. r~ Richard Henderson (6): gdbstub: Return the fd from gdbserver_start linux-user: Add host_fds and manipulators linux-user: Check is_hostfd in do_syscall linux-user: Check contains_hostfd in select syscalls linux-user: Check is_hostfd in mmap syscalls linux-user: Use *at functions to implement interp_prefix linux-user/qemu.h | 67 ++++++ gdbstub.c | 5 +- linux-user/elfload.c | 5 +- linux-user/main.c | 53 ++++- linux-user/syscall.c | 485 ++++++++++++++++++++++++++++++++++++------- 5 files changed, 532 insertions(+), 83 deletions(-) -- 2.17.0