mbox series

[v4b,00/18] target/arm: SVE instructions, part 2

Message ID 20180613015641.5667-1-richard.henderson@linaro.org
Headers show
Series target/arm: SVE instructions, part 2 | expand

Message

Richard Henderson June 13, 2018, 1:56 a.m. UTC 
Here's the second installment of SVE instructions.
There are about 25 patches waiting for a third installment;
this makes a nice break before beginning with the memory ops.

Since v3, r-b tags, comment fixes, and other review feedback.


r~


Richard Henderson (18):
  target/arm: Extend vec_reg_offset to larger sizes
  target/arm: Implement SVE Permute - Unpredicated Group
  target/arm: Implement SVE Permute - Predicates Group
  target/arm: Implement SVE Permute - Interleaving Group
  target/arm: Implement SVE compress active elements
  target/arm: Implement SVE conditionally broadcast/extract element
  target/arm: Implement SVE copy to vector (predicated)
  target/arm: Implement SVE reverse within elements
  target/arm: Implement SVE vector splice (predicated)
  target/arm: Implement SVE Select Vectors Group
  target/arm: Implement SVE Integer Compare - Vectors Group
  target/arm: Implement SVE Integer Compare - Immediate Group
  target/arm: Implement SVE Partition Break Group
  target/arm: Implement SVE Predicate Count Group
  target/arm: Implement SVE Integer Compare - Scalars Group
  target/arm: Implement FDUP/DUP
  target/arm: Implement SVE Integer Wide Immediate - Unpredicated Group
  target/arm: Implement SVE Floating Point Arithmetic - Unpredicated
    Group

 target/arm/helper-sve.h    |  294 ++++++++
 target/arm/helper.h        |   19 +
 target/arm/translate-a64.h |   26 +-
 target/arm/sve_helper.c    | 1250 +++++++++++++++++++++++++++++++
 target/arm/translate-sve.c | 1458 ++++++++++++++++++++++++++++++++++++
 target/arm/vec_helper.c    |   69 ++
 target/arm/sve.decode      |  248 ++++++
 7 files changed, 3355 insertions(+), 9 deletions(-)

-- 
2.17.1

Comments

no-reply@patchew.org June 13, 2018, 2:54 a.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180613015641.5667-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v4b 00/18] target/arm: SVE instructions, part 2

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d3104242cb target/arm: Implement SVE Floating Point Arithmetic - Unpredicated Group
0ea2461007 target/arm: Implement SVE Integer Wide Immediate - Unpredicated Group
18a818eb47 target/arm: Implement FDUP/DUP
7f1af2a272 target/arm: Implement SVE Integer Compare - Scalars Group
b131f594f6 target/arm: Implement SVE Predicate Count Group
1eaefa4668 target/arm: Implement SVE Partition Break Group
c55e12b07b target/arm: Implement SVE Integer Compare - Immediate Group
f9f8d5d72f target/arm: Implement SVE Integer Compare - Vectors Group
37d52afaa6 target/arm: Implement SVE Select Vectors Group
b799bbce3d target/arm: Implement SVE vector splice (predicated)
fafdc0fe92 target/arm: Implement SVE reverse within elements
1145a50559 target/arm: Implement SVE copy to vector (predicated)
394600eb0d target/arm: Implement SVE conditionally broadcast/extract element
f97a7773f6 target/arm: Implement SVE compress active elements
31de221ead target/arm: Implement SVE Permute - Interleaving Group
4a8e4e671a target/arm: Implement SVE Permute - Predicates Group
d768f8bba5 target/arm: Implement SVE Permute - Unpredicated Group
9950c97fef target/arm: Extend vec_reg_offset to larger sizes

=== OUTPUT BEGIN ===
Checking PATCH 1/18: target/arm: Extend vec_reg_offset to larger sizes...
Checking PATCH 2/18: target/arm: Implement SVE Permute - Unpredicated Group...
ERROR: space prohibited before that close parenthesis ')'
#116: FILE: target/arm/sve_helper.c:1575:
+DO_INSR(sve_insr_d, uint64_t, )

ERROR: space prohibited before that close parenthesis ')'
#190: FILE: target/arm/sve_helper.c:1649:
+DO_TBL(sve_tbl_d, uint64_t, )

total: 2 errors, 0 warnings, 330 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/18: target/arm: Implement SVE Permute - Predicates Group...
Checking PATCH 4/18: target/arm: Implement SVE Permute - Interleaving Group...
ERROR: space prohibited before that close parenthesis ')'
#89: FILE: target/arm/sve_helper.c:1991:
+DO_ZIP(sve_zip_d, uint64_t, )

ERROR: space prohibited before that close parenthesis ')'
#113: FILE: target/arm/sve_helper.c:2015:
+DO_UZP(sve_uzp_d, uint64_t, )

ERROR: space prohibited before that close parenthesis ')'
#132: FILE: target/arm/sve_helper.c:2034:
+DO_TRN(sve_trn_d, uint64_t, )

total: 3 errors, 0 warnings, 193 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/18: target/arm: Implement SVE compress active elements...
Checking PATCH 6/18: target/arm: Implement SVE conditionally broadcast/extract element...
Checking PATCH 7/18: target/arm: Implement SVE copy to vector (predicated)...
Checking PATCH 8/18: target/arm: Implement SVE reverse within elements...
Checking PATCH 9/18: target/arm: Implement SVE vector splice (predicated)...
Checking PATCH 10/18: target/arm: Implement SVE Select Vectors Group...
Checking PATCH 11/18: target/arm: Implement SVE Integer Compare - Vectors Group...
ERROR: spaces required around that '==' (ctx:WxB)
#268: FILE: target/arm/sve_helper.c:2279:
+DO_CMP_PPZZ_B(sve_cmpeq_ppzz_b, uint8_t,  ==)
                                           ^

ERROR: spaces required around that '==' (ctx:WxB)
#269: FILE: target/arm/sve_helper.c:2280:
+DO_CMP_PPZZ_H(sve_cmpeq_ppzz_h, uint16_t, ==)
                                           ^

ERROR: spaces required around that '==' (ctx:WxB)
#270: FILE: target/arm/sve_helper.c:2281:
+DO_CMP_PPZZ_S(sve_cmpeq_ppzz_s, uint32_t, ==)
                                           ^

ERROR: spaces required around that '==' (ctx:WxB)
#271: FILE: target/arm/sve_helper.c:2282:
+DO_CMP_PPZZ_D(sve_cmpeq_ppzz_d, uint64_t, ==)
                                           ^

ERROR: spaces required around that '!=' (ctx:WxB)
#273: FILE: target/arm/sve_helper.c:2284:
+DO_CMP_PPZZ_B(sve_cmpne_ppzz_b, uint8_t,  !=)
                                           ^

ERROR: spaces required around that '!=' (ctx:WxB)
#274: FILE: target/arm/sve_helper.c:2285:
+DO_CMP_PPZZ_H(sve_cmpne_ppzz_h, uint16_t, !=)
                                           ^

ERROR: spaces required around that '!=' (ctx:WxB)
#275: FILE: target/arm/sve_helper.c:2286:
+DO_CMP_PPZZ_S(sve_cmpne_ppzz_s, uint32_t, !=)
                                           ^

ERROR: spaces required around that '!=' (ctx:WxB)
#276: FILE: target/arm/sve_helper.c:2287:
+DO_CMP_PPZZ_D(sve_cmpne_ppzz_d, uint64_t, !=)
                                           ^

ERROR: spaces required around that '>' (ctx:WxB)
#278: FILE: target/arm/sve_helper.c:2289:
+DO_CMP_PPZZ_B(sve_cmpgt_ppzz_b, int8_t,  >)
                                          ^

ERROR: spaces required around that '>' (ctx:WxB)
#279: FILE: target/arm/sve_helper.c:2290:
+DO_CMP_PPZZ_H(sve_cmpgt_ppzz_h, int16_t, >)
                                          ^

ERROR: spaces required around that '>' (ctx:WxB)
#280: FILE: target/arm/sve_helper.c:2291:
+DO_CMP_PPZZ_S(sve_cmpgt_ppzz_s, int32_t, >)
                                          ^

ERROR: spaces required around that '>' (ctx:WxB)
#281: FILE: target/arm/sve_helper.c:2292:
+DO_CMP_PPZZ_D(sve_cmpgt_ppzz_d, int64_t, >)
                                          ^

ERROR: spaces required around that '>=' (ctx:WxB)
#283: FILE: target/arm/sve_helper.c:2294:
+DO_CMP_PPZZ_B(sve_cmpge_ppzz_b, int8_t,  >=)
                                          ^

ERROR: spaces required around that '>=' (ctx:WxB)
#284: FILE: target/arm/sve_helper.c:2295:
+DO_CMP_PPZZ_H(sve_cmpge_ppzz_h, int16_t, >=)
                                          ^

ERROR: spaces required around that '>=' (ctx:WxB)
#285: FILE: target/arm/sve_helper.c:2296:
+DO_CMP_PPZZ_S(sve_cmpge_ppzz_s, int32_t, >=)
                                          ^

ERROR: spaces required around that '>=' (ctx:WxB)
#286: FILE: target/arm/sve_helper.c:2297:
+DO_CMP_PPZZ_D(sve_cmpge_ppzz_d, int64_t, >=)
                                          ^

ERROR: spaces required around that '>' (ctx:WxB)
#288: FILE: target/arm/sve_helper.c:2299:
+DO_CMP_PPZZ_B(sve_cmphi_ppzz_b, uint8_t,  >)
                                           ^

ERROR: spaces required around that '>' (ctx:WxB)
#289: FILE: target/arm/sve_helper.c:2300:
+DO_CMP_PPZZ_H(sve_cmphi_ppzz_h, uint16_t, >)
                                           ^

ERROR: spaces required around that '>' (ctx:WxB)
#290: FILE: target/arm/sve_helper.c:2301:
+DO_CMP_PPZZ_S(sve_cmphi_ppzz_s, uint32_t, >)
                                           ^

ERROR: spaces required around that '>' (ctx:WxB)
#291: FILE: target/arm/sve_helper.c:2302:
+DO_CMP_PPZZ_D(sve_cmphi_ppzz_d, uint64_t, >)
                                           ^

ERROR: spaces required around that '>=' (ctx:WxB)
#293: FILE: target/arm/sve_helper.c:2304:
+DO_CMP_PPZZ_B(sve_cmphs_ppzz_b, uint8_t,  >=)
                                           ^

ERROR: spaces required around that '>=' (ctx:WxB)
#294: FILE: target/arm/sve_helper.c:2305:
+DO_CMP_PPZZ_H(sve_cmphs_ppzz_h, uint16_t, >=)
                                           ^

ERROR: spaces required around that '>=' (ctx:WxB)
#295: FILE: target/arm/sve_helper.c:2306:
+DO_CMP_PPZZ_S(sve_cmphs_ppzz_s, uint32_t, >=)
                                           ^

ERROR: spaces required around that '>=' (ctx:WxB)
#296: FILE: target/arm/sve_helper.c:2307:
+DO_CMP_PPZZ_D(sve_cmphs_ppzz_d, uint64_t, >=)
                                           ^

ERROR: spaces required around that '==' (ctx:WxB)
#336: FILE: target/arm/sve_helper.c:2347:
+DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, uint8_t,  uint64_t, ==)
                                                     ^

ERROR: spaces required around that '==' (ctx:WxB)
#337: FILE: target/arm/sve_helper.c:2348:
+DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, uint16_t, uint64_t, ==)
                                                     ^

ERROR: spaces required around that '==' (ctx:WxB)
#338: FILE: target/arm/sve_helper.c:2349:
+DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, uint32_t, uint64_t, ==)
                                                     ^

ERROR: spaces required around that '!=' (ctx:WxB)
#340: FILE: target/arm/sve_helper.c:2351:
+DO_CMP_PPZW_B(sve_cmpne_ppzw_b, uint8_t,  uint64_t, !=)
                                                     ^

ERROR: spaces required around that '!=' (ctx:WxB)
#341: FILE: target/arm/sve_helper.c:2352:
+DO_CMP_PPZW_H(sve_cmpne_ppzw_h, uint16_t, uint64_t, !=)
                                                     ^

ERROR: spaces required around that '!=' (ctx:WxB)
#342: FILE: target/arm/sve_helper.c:2353:
+DO_CMP_PPZW_S(sve_cmpne_ppzw_s, uint32_t, uint64_t, !=)
                                                     ^

ERROR: spaces required around that '>' (ctx:WxB)
#344: FILE: target/arm/sve_helper.c:2355:
+DO_CMP_PPZW_B(sve_cmpgt_ppzw_b, int8_t,   int64_t, >)
                                                    ^

ERROR: spaces required around that '>' (ctx:WxB)
#345: FILE: target/arm/sve_helper.c:2356:
+DO_CMP_PPZW_H(sve_cmpgt_ppzw_h, int16_t,  int64_t, >)
                                                    ^

ERROR: spaces required around that '>' (ctx:WxB)
#346: FILE: target/arm/sve_helper.c:2357:
+DO_CMP_PPZW_S(sve_cmpgt_ppzw_s, int32_t,  int64_t, >)
                                                    ^

ERROR: spaces required around that '>=' (ctx:WxB)
#348: FILE: target/arm/sve_helper.c:2359:
+DO_CMP_PPZW_B(sve_cmpge_ppzw_b, int8_t,   int64_t, >=)
                                                    ^

ERROR: spaces required around that '>=' (ctx:WxB)
#349: FILE: target/arm/sve_helper.c:2360:
+DO_CMP_PPZW_H(sve_cmpge_ppzw_h, int16_t,  int64_t, >=)
                                                    ^

ERROR: spaces required around that '>=' (ctx:WxB)
#350: FILE: target/arm/sve_helper.c:2361:
+DO_CMP_PPZW_S(sve_cmpge_ppzw_s, int32_t,  int64_t, >=)
                                                    ^

ERROR: spaces required around that '>' (ctx:WxB)
#352: FILE: target/arm/sve_helper.c:2363:
+DO_CMP_PPZW_B(sve_cmphi_ppzw_b, uint8_t,  uint64_t, >)
                                                     ^

ERROR: spaces required around that '>' (ctx:WxB)
#353: FILE: target/arm/sve_helper.c:2364:
+DO_CMP_PPZW_H(sve_cmphi_ppzw_h, uint16_t, uint64_t, >)
                                                     ^

ERROR: spaces required around that '>' (ctx:WxB)
#354: FILE: target/arm/sve_helper.c:2365:
+DO_CMP_PPZW_S(sve_cmphi_ppzw_s, uint32_t, uint64_t, >)
                                                     ^

ERROR: spaces required around that '>=' (ctx:WxB)
#356: FILE: target/arm/sve_helper.c:2367:
+DO_CMP_PPZW_B(sve_cmphs_ppzw_b, uint8_t,  uint64_t, >=)
                                                     ^

ERROR: spaces required around that '>=' (ctx:WxB)
#357: FILE: target/arm/sve_helper.c:2368:
+DO_CMP_PPZW_H(sve_cmphs_ppzw_h, uint16_t, uint64_t, >=)
                                                     ^

ERROR: spaces required around that '>=' (ctx:WxB)
#358: FILE: target/arm/sve_helper.c:2369:
+DO_CMP_PPZW_S(sve_cmphs_ppzw_s, uint32_t, uint64_t, >=)
                                                     ^

ERROR: spaces required around that '<' (ctx:WxB)
#360: FILE: target/arm/sve_helper.c:2371:
+DO_CMP_PPZW_B(sve_cmplt_ppzw_b, int8_t,   int64_t, <)
                                                    ^

ERROR: spaces required around that '<' (ctx:WxB)
#361: FILE: target/arm/sve_helper.c:2372:
+DO_CMP_PPZW_H(sve_cmplt_ppzw_h, int16_t,  int64_t, <)
                                                    ^

ERROR: spaces required around that '<' (ctx:WxB)
#362: FILE: target/arm/sve_helper.c:2373:
+DO_CMP_PPZW_S(sve_cmplt_ppzw_s, int32_t,  int64_t, <)
                                                    ^

ERROR: spaces required around that '<=' (ctx:WxB)
#364: FILE: target/arm/sve_helper.c:2375:
+DO_CMP_PPZW_B(sve_cmple_ppzw_b, int8_t,   int64_t, <=)
                                                    ^

ERROR: spaces required around that '<=' (ctx:WxB)
#365: FILE: target/arm/sve_helper.c:2376:
+DO_CMP_PPZW_H(sve_cmple_ppzw_h, int16_t,  int64_t, <=)
                                                    ^

ERROR: spaces required around that '<=' (ctx:WxB)
#366: FILE: target/arm/sve_helper.c:2377:
+DO_CMP_PPZW_S(sve_cmple_ppzw_s, int32_t,  int64_t, <=)
                                                    ^

ERROR: spaces required around that '<' (ctx:WxB)
#368: FILE: target/arm/sve_helper.c:2379:
+DO_CMP_PPZW_B(sve_cmplo_ppzw_b, uint8_t,  uint64_t, <)
                                                     ^

ERROR: spaces required around that '<' (ctx:WxB)
#369: FILE: target/arm/sve_helper.c:2380:
+DO_CMP_PPZW_H(sve_cmplo_ppzw_h, uint16_t, uint64_t, <)
                                                     ^

ERROR: spaces required around that '<' (ctx:WxB)
#370: FILE: target/arm/sve_helper.c:2381:
+DO_CMP_PPZW_S(sve_cmplo_ppzw_s, uint32_t, uint64_t, <)
                                                     ^

ERROR: spaces required around that '<=' (ctx:WxB)
#372: FILE: target/arm/sve_helper.c:2383:
+DO_CMP_PPZW_B(sve_cmpls_ppzw_b, uint8_t,  uint64_t, <=)
                                                     ^

ERROR: spaces required around that '<=' (ctx:WxB)
#373: FILE: target/arm/sve_helper.c:2384:
+DO_CMP_PPZW_H(sve_cmpls_ppzw_h, uint16_t, uint64_t, <=)
                                                     ^

ERROR: spaces required around that '<=' (ctx:WxB)
#374: FILE: target/arm/sve_helper.c:2385:
+DO_CMP_PPZW_S(sve_cmpls_ppzw_s, uint32_t, uint64_t, <=)
                                                     ^

total: 54 errors, 0 warnings, 456 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 12/18: target/arm: Implement SVE Integer Compare - Immediate Group...
ERROR: spaces required around that '==' (ctx:WxB)
#147: FILE: target/arm/sve_helper.c:2424:
+DO_CMP_PPZI_B(sve_cmpeq_ppzi_b, uint8_t,  ==)
                                           ^

ERROR: spaces required around that '==' (ctx:WxB)
#148: FILE: target/arm/sve_helper.c:2425:
+DO_CMP_PPZI_H(sve_cmpeq_ppzi_h, uint16_t, ==)
                                           ^

ERROR: spaces required around that '==' (ctx:WxB)
#149: FILE: target/arm/sve_helper.c:2426:
+DO_CMP_PPZI_S(sve_cmpeq_ppzi_s, uint32_t, ==)
                                           ^

ERROR: spaces required around that '==' (ctx:WxB)
#150: FILE: target/arm/sve_helper.c:2427:
+DO_CMP_PPZI_D(sve_cmpeq_ppzi_d, uint64_t, ==)
                                           ^

ERROR: spaces required around that '!=' (ctx:WxB)
#152: FILE: target/arm/sve_helper.c:2429:
+DO_CMP_PPZI_B(sve_cmpne_ppzi_b, uint8_t,  !=)
                                           ^

ERROR: spaces required around that '!=' (ctx:WxB)
#153: FILE: target/arm/sve_helper.c:2430:
+DO_CMP_PPZI_H(sve_cmpne_ppzi_h, uint16_t, !=)
                                           ^

ERROR: spaces required around that '!=' (ctx:WxB)
#154: FILE: target/arm/sve_helper.c:2431:
+DO_CMP_PPZI_S(sve_cmpne_ppzi_s, uint32_t, !=)
                                           ^

ERROR: spaces required around that '!=' (ctx:WxB)
#155: FILE: target/arm/sve_helper.c:2432:
+DO_CMP_PPZI_D(sve_cmpne_ppzi_d, uint64_t, !=)
                                           ^

ERROR: spaces required around that '>' (ctx:WxB)
#157: FILE: target/arm/sve_helper.c:2434:
+DO_CMP_PPZI_B(sve_cmpgt_ppzi_b, int8_t,  >)
                                          ^

ERROR: spaces required around that '>' (ctx:WxB)
#158: FILE: target/arm/sve_helper.c:2435:
+DO_CMP_PPZI_H(sve_cmpgt_ppzi_h, int16_t, >)
                                          ^

ERROR: spaces required around that '>' (ctx:WxB)
#159: FILE: target/arm/sve_helper.c:2436:
+DO_CMP_PPZI_S(sve_cmpgt_ppzi_s, int32_t, >)
                                          ^

ERROR: spaces required around that '>' (ctx:WxB)
#160: FILE: target/arm/sve_helper.c:2437:
+DO_CMP_PPZI_D(sve_cmpgt_ppzi_d, int64_t, >)
                                          ^

ERROR: spaces required around that '>=' (ctx:WxB)
#162: FILE: target/arm/sve_helper.c:2439:
+DO_CMP_PPZI_B(sve_cmpge_ppzi_b, int8_t,  >=)
                                          ^

ERROR: spaces required around that '>=' (ctx:WxB)
#163: FILE: target/arm/sve_helper.c:2440:
+DO_CMP_PPZI_H(sve_cmpge_ppzi_h, int16_t, >=)
                                          ^

ERROR: spaces required around that '>=' (ctx:WxB)
#164: FILE: target/arm/sve_helper.c:2441:
+DO_CMP_PPZI_S(sve_cmpge_ppzi_s, int32_t, >=)
                                          ^

ERROR: spaces required around that '>=' (ctx:WxB)
#165: FILE: target/arm/sve_helper.c:2442:
+DO_CMP_PPZI_D(sve_cmpge_ppzi_d, int64_t, >=)
                                          ^

ERROR: spaces required around that '>' (ctx:WxB)
#167: FILE: target/arm/sve_helper.c:2444:
+DO_CMP_PPZI_B(sve_cmphi_ppzi_b, uint8_t,  >)
                                           ^

ERROR: spaces required around that '>' (ctx:WxB)
#168: FILE: target/arm/sve_helper.c:2445:
+DO_CMP_PPZI_H(sve_cmphi_ppzi_h, uint16_t, >)
                                           ^

ERROR: spaces required around that '>' (ctx:WxB)
#169: FILE: target/arm/sve_helper.c:2446:
+DO_CMP_PPZI_S(sve_cmphi_ppzi_s, uint32_t, >)
                                           ^

ERROR: spaces required around that '>' (ctx:WxB)
#170: FILE: target/arm/sve_helper.c:2447:
+DO_CMP_PPZI_D(sve_cmphi_ppzi_d, uint64_t, >)
                                           ^

ERROR: spaces required around that '>=' (ctx:WxB)
#172: FILE: target/arm/sve_helper.c:2449:
+DO_CMP_PPZI_B(sve_cmphs_ppzi_b, uint8_t,  >=)
                                           ^

ERROR: spaces required around that '>=' (ctx:WxB)
#173: FILE: target/arm/sve_helper.c:2450:
+DO_CMP_PPZI_H(sve_cmphs_ppzi_h, uint16_t, >=)
                                           ^

ERROR: spaces required around that '>=' (ctx:WxB)
#174: FILE: target/arm/sve_helper.c:2451:
+DO_CMP_PPZI_S(sve_cmphs_ppzi_s, uint32_t, >=)
                                           ^

ERROR: spaces required around that '>=' (ctx:WxB)
#175: FILE: target/arm/sve_helper.c:2452:
+DO_CMP_PPZI_D(sve_cmphs_ppzi_d, uint64_t, >=)
                                           ^

ERROR: spaces required around that '<' (ctx:WxB)
#177: FILE: target/arm/sve_helper.c:2454:
+DO_CMP_PPZI_B(sve_cmplt_ppzi_b, int8_t,  <)
                                          ^

ERROR: spaces required around that '<' (ctx:WxB)
#178: FILE: target/arm/sve_helper.c:2455:
+DO_CMP_PPZI_H(sve_cmplt_ppzi_h, int16_t, <)
                                          ^

ERROR: spaces required around that '<' (ctx:WxB)
#179: FILE: target/arm/sve_helper.c:2456:
+DO_CMP_PPZI_S(sve_cmplt_ppzi_s, int32_t, <)
                                          ^

ERROR: spaces required around that '<' (ctx:WxB)
#180: FILE: target/arm/sve_helper.c:2457:
+DO_CMP_PPZI_D(sve_cmplt_ppzi_d, int64_t, <)
                                          ^

ERROR: spaces required around that '<=' (ctx:WxB)
#182: FILE: target/arm/sve_helper.c:2459:
+DO_CMP_PPZI_B(sve_cmple_ppzi_b, int8_t,  <=)
                                          ^

ERROR: spaces required around that '<=' (ctx:WxB)
#183: FILE: target/arm/sve_helper.c:2460:
+DO_CMP_PPZI_H(sve_cmple_ppzi_h, int16_t, <=)
                                          ^

ERROR: spaces required around that '<=' (ctx:WxB)
#184: FILE: target/arm/sve_helper.c:2461:
+DO_CMP_PPZI_S(sve_cmple_ppzi_s, int32_t, <=)
                                          ^

ERROR: spaces required around that '<=' (ctx:WxB)
#185: FILE: target/arm/sve_helper.c:2462:
+DO_CMP_PPZI_D(sve_cmple_ppzi_d, int64_t, <=)
                                          ^

ERROR: spaces required around that '<' (ctx:WxB)
#187: FILE: target/arm/sve_helper.c:2464:
+DO_CMP_PPZI_B(sve_cmplo_ppzi_b, uint8_t,  <)
                                           ^

ERROR: spaces required around that '<' (ctx:WxB)
#188: FILE: target/arm/sve_helper.c:2465:
+DO_CMP_PPZI_H(sve_cmplo_ppzi_h, uint16_t, <)
                                           ^

ERROR: spaces required around that '<' (ctx:WxB)
#189: FILE: target/arm/sve_helper.c:2466:
+DO_CMP_PPZI_S(sve_cmplo_ppzi_s, uint32_t, <)
                                           ^

ERROR: spaces required around that '<' (ctx:WxB)
#190: FILE: target/arm/sve_helper.c:2467:
+DO_CMP_PPZI_D(sve_cmplo_ppzi_d, uint64_t, <)
                                           ^

ERROR: spaces required around that '<=' (ctx:WxB)
#192: FILE: target/arm/sve_helper.c:2469:
+DO_CMP_PPZI_B(sve_cmpls_ppzi_b, uint8_t,  <=)
                                           ^

ERROR: spaces required around that '<=' (ctx:WxB)
#193: FILE: target/arm/sve_helper.c:2470:
+DO_CMP_PPZI_H(sve_cmpls_ppzi_h, uint16_t, <=)
                                           ^

ERROR: spaces required around that '<=' (ctx:WxB)
#194: FILE: target/arm/sve_helper.c:2471:
+DO_CMP_PPZI_S(sve_cmpls_ppzi_s, uint32_t, <=)
                                           ^

ERROR: spaces required around that '<=' (ctx:WxB)
#195: FILE: target/arm/sve_helper.c:2472:
+DO_CMP_PPZI_D(sve_cmpls_ppzi_d, uint64_t, <=)
                                           ^

total: 40 errors, 0 warnings, 254 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/18: target/arm: Implement SVE Partition Break Group...
Checking PATCH 14/18: target/arm: Implement SVE Predicate Count Group...
Checking PATCH 15/18: target/arm: Implement SVE Integer Compare - Scalars Group...
Checking PATCH 16/18: target/arm: Implement FDUP/DUP...
Checking PATCH 17/18: target/arm: Implement SVE Integer Wide Immediate - Unpredicated Group...
Checking PATCH 18/18: target/arm: Implement SVE Floating Point Arithmetic - Unpredicated Group...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell June 15, 2018, 10:34 a.m. UTC | #2 
On 13 June 2018 at 02:56, Richard Henderson
<richard.henderson@linaro.org> wrote:
> Here's the second installment of SVE instructions.

> There are about 25 patches waiting for a third installment;

> this makes a nice break before beginning with the memory ops.

>

> Since v3, r-b tags, comment fixes, and other review feedback.

>

>




Applied to target-arm.next, thanks.

-- PMM