mbox series

[v3,0/4] softfloat: Fix division

Message ID 20181004175700.20847-1-richard.henderson@linaro.org
Headers show
Series softfloat: Fix division | expand

Message

Richard Henderson Oct. 4, 2018, 5:56 p.m. UTC
Changes from v2:
  * Add shift128Left.  I had been using shortShift128Left,
    with a shift of 64, which lead to undefined behaviour.
    Which I suspect is exactly the Heisenbug Alex saw.

    I did keep the R-b tags I had already applied.


r~


Richard Henderson (4):
  softfloat: Fix division
  softfloat: Specialize udiv_qrnnd for x86_64
  softfloat: Specialize udiv_qrnnd for s390x
  softfloat: Specialize udiv_qrnnd for ppc64

 include/fpu/softfloat-macros.h | 62 +++++++++++++++++++++++++++++-----
 fpu/softfloat.c                | 35 ++++++++++++++-----
 2 files changed, 80 insertions(+), 17 deletions(-)

-- 
2.17.1

Comments

Alex Bennée Oct. 5, 2018, 3:59 p.m. UTC | #1
Richard Henderson <richard.henderson@linaro.org> writes:

> Changes from v2:

>   * Add shift128Left.  I had been using shortShift128Left,

>     with a shift of 64, which lead to undefined behaviour.

>     Which I suspect is exactly the Heisenbug Alex saw.


No weirdness this time around

>

>     I did keep the R-b tags I had already applied.


You already have mine but this version also:

Tested-by: Alex Bennée <alex.bennee@linaro.org>


>

>

> r~

>

>

> Richard Henderson (4):

>   softfloat: Fix division

>   softfloat: Specialize udiv_qrnnd for x86_64

>   softfloat: Specialize udiv_qrnnd for s390x

>   softfloat: Specialize udiv_qrnnd for ppc64

>

>  include/fpu/softfloat-macros.h | 62 +++++++++++++++++++++++++++++-----

>  fpu/softfloat.c                | 35 ++++++++++++++-----

>  2 files changed, 80 insertions(+), 17 deletions(-)



--
Alex Bennée