mbox series

[v2,0/3] decodetree improvments

Message ID 20181031121443.605-1-richard.henderson@linaro.org
Headers show
Series decodetree improvments | expand

Message

Richard Henderson Oct. 31, 2018, 12:14 p.m. UTC 
All three patches have appeared on list before, though not all
at once in the same series.  This is all cleanup suggested by
the ongoing risc-v work.


r~


Richard Henderson (3):
  decodetree: Add !extern flag to argument sets
  decodetree: Remove "insn" argument from trans_* expanders
  decodetree: Allow multiple input files

 target/arm/translate-sve.c  | 507 +++++++++++++++++-------------------
 target/openrisc/disas.c     |  23 +-
 target/openrisc/translate.c | 200 +++++++-------
 scripts/decodetree.py       |  64 +++--
 4 files changed, 395 insertions(+), 399 deletions(-)

-- 
2.17.2

Comments

Philippe Mathieu-Daudé Oct. 31, 2018, 4:29 p.m. UTC | #1 
On 31/10/18 13:14, Richard Henderson wrote:
> All three patches have appeared on list before, though not all

> at once in the same series.  This is all cleanup suggested by

> the ongoing risc-v work.

> 

> 

> r~

> 

> 

> Richard Henderson (3):

>    decodetree: Add !extern flag to argument sets

>    decodetree: Remove "insn" argument from trans_* expanders

>    decodetree: Allow multiple input files


Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
no-reply@patchew.org Nov. 2, 2018, 4:39 a.m. UTC | #2 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20181031121443.605-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/3] decodetree improvments

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
370a53f714 decodetree: Allow multiple input files
b698bd34f5 decodetree: Remove "insn" argument from trans_* expanders
ec7600c51a decodetree: Add !extern flag to argument sets

=== OUTPUT BEGIN ===
Checking PATCH 1/3: decodetree: Add !extern flag to argument sets...
Checking PATCH 2/3: decodetree: Remove "insn" argument from trans_* expanders...
ERROR: spaces required around that '*' (ctx:WxV)
#122: FILE: target/arm/translate-sve.c:372:
+static bool trans_##NAME##_zpzz(DisasContext *s, arg_rprr_esz *a)         \
                                                               ^

ERROR: spaces required around that '*' (ctx:WxV)
#131: FILE: target/arm/translate-sve.c:404:
+static bool trans_SDIV_zpzz(DisasContext *s, arg_rprr_esz *a)
                                                           ^

ERROR: spaces required around that '*' (ctx:WxV)
#158: FILE: target/arm/translate-sve.c:450:
+static bool trans_##NAME(DisasContext *s, arg_rpr_esz *a)           \
                                                       ^

ERROR: spaces required around that '*' (ctx:WxV)
#167: FILE: target/arm/translate-sve.c:467:
+static bool trans_FABS(DisasContext *s, arg_rpr_esz *a)
                                                     ^

ERROR: spaces required around that '*' (ctx:WxV)
#331: FILE: target/arm/translate-sve.c:851:
+static bool trans_##NAME(DisasContext *s, arg_rprrr_esz *a)          \
                                                         ^

ERROR: spaces required around that '*' (ctx:WxV)
#1442: FILE: target/arm/translate-sve.c:3981:
+static bool trans_##NAME(DisasContext *s, arg_rprrr_esz *a)          \
                                                         ^

ERROR: spaces required around that '*' (ctx:WxV)
#1950: FILE: target/openrisc/disas.c:55:
+static bool trans_l_##opcode(disassemble_info *info, arg_l_##opcode *a) \
                                               ^

ERROR: spaces required around that '*' (ctx:WxV)
#1950: FILE: target/openrisc/disas.c:55:
+static bool trans_l_##opcode(disassemble_info *info, arg_l_##opcode *a) \
                                                                     ^

ERROR: spaces required around that '*' (ctx:WxV)
#1968: FILE: target/openrisc/disas.c:149:
+static bool trans_lf_##opcode##_##suffix(disassemble_info *info,        \
                                                           ^

ERROR: spaces required around that '*' (ctx:WxV)
#1969: FILE: target/openrisc/disas.c:150:
+                                         arg_lf_##opcode##_##suffix *a) \
                                                                     ^

total: 10 errors, 0 warnings, 2539 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/3: decodetree: Allow multiple input files...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com