From patchwork Tue Apr 16 08:31:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 162300 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3942025jan; Tue, 16 Apr 2019 01:34:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqxg5f7vFX5tSGQstu+QUMiGltdeC6S65JZdPl+Ppt+eYw7qadSZkfS5/+LOXK9GX3khsjKN X-Received: by 2002:a5d:6a0b:: with SMTP id m11mr49563699wru.290.1555403649627; Tue, 16 Apr 2019 01:34:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555403649; cv=none; d=google.com; s=arc-20160816; b=UfNGvSuRwW2ugKhDAtJtes6HOLEuJ/WiOW00pQozllSvu/pORz/e+FFKw3SPMjn24c elqnQqw3Whz5NjJ1Z/OPW04oOHXKjypF5RUGiPhpKGGJdDH6KnMsd4AJiMEJGq3L2n5L 6VGAMTSICpEGHNZSlJC/exLC1sdJexFjdhhbYLw7wnuKLgND4YuFu7Q4sT7zSm916COQ kHevxx2KJAm57zdmz7AtbGI1mT3jCUxLACHdBjXwTsEddeC58jQ8mCd9Ld2lyPXKuwaA Tc2q5wvdDLwxBSFkCdm20yJBc7rUJtqgziMUhihpwM/Aa0UQRQ6TfG3n3xvytl6gsvvU WFZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature; bh=58c5T72JhXU7KTjU0vC9upc1wTUu8WeZ8Lk/ZdEQRsw=; b=Rdy6uIT48Tk6db03Pfa/3t3z/c1YKr3+s92NfxkTAJPht9HmQ88YWM5WORlSMNr8Tx PRzb/VaOR34Bc8YmErakL84M97+e0YjJ7KdSfFI2uiea3oncAtq478oKBoc4sDsO0wmh CjN5wvmmqwLZkiWvHY4DjRlFMnZZ9kPFX/fKfxd+clftmYY9IxYdz/ftWDDz46VvcnYC G0RXTPOdaFHmmsWjAGY5kUpdSzv3zwDXZ1KaMI+G5NPzpvSyYMbSnqN/iNXoe2WnNrwQ FVmxUVpCwjO3lkGcyxyYdMJ/5jPBI2mRxtp7LxmxUJ0f8zFFHbzSR8Tyevstw4iphQbB CHag== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=fL7F5URT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x25si12458751wmk.189.2019.04.16.01.34.09 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 16 Apr 2019 01:34:09 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=fL7F5URT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:33014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGJXc-0004FX-Ju for patch@linaro.org; Tue, 16 Apr 2019 04:34:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGJVV-0002rv-0a for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGJVT-0006Fc-VX for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:31:56 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:35768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGJVT-0006CT-Ir for qemu-devel@nongnu.org; Tue, 16 Apr 2019 04:31:55 -0400 Received: by mail-pg1-x52f.google.com with SMTP id g8so9991863pgf.2 for ; Tue, 16 Apr 2019 01:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=58c5T72JhXU7KTjU0vC9upc1wTUu8WeZ8Lk/ZdEQRsw=; b=fL7F5URT7S2PzMotrVGP45T6fUWcYiPtst6dbAuO2lT5CpGZ3V5p1uZnojRJ1nOiVq hfMFrLbM7lkwWs30O/neQ8B4AZUeHCUNfGw7mieckn4CQqUVR0owoWGFb2JTbMZ7G1DY bQz8/aKzvvPuF8Onua0pnjsr1tyd1uFe8ZW1YUOcHRtAWDQpbKjRAyVfIEdXhXQBZkTJ +daJ+l98DdgRtadlbg0qcEqha1edrxYj/Rg7/5SUPAu+6IDd5QQ0Ffn3tvXRm/AsZI+I rZGpYK8n3lCzrAc1gQh2/azkV2b2FvyoPhL+FF8yF0NXU/tddbr3lnVwfLnQuwemFOmG hClQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=58c5T72JhXU7KTjU0vC9upc1wTUu8WeZ8Lk/ZdEQRsw=; b=AzY0KD0vuJbfFbx2cSKDbGuQ+SHHPntNg1OrgDlm9uoTPgrcqJpOx7x1i4gPuv/MJc S6CmcP8U/VU+ekczGMa8JRzGiY2bdNxpAT7CCEdCuR7nv7/9dCocYpeuQFyKJGKgPBcI CGGkyhszD0KhC3LVC+tdpA8rzjxwGncUHYQCRFJ1ZIf3F6ZWkPyVc8l2GeFfEcmMGzCF SRsJ2s4CxiLH4UW3bkuKVtmD8kc4JLWIUvPJcNnpL9uZEk/8tW3aNJv0EnQ+DQm2exO1 O/pkILsXAF36Kq7FRFdMN2xVLczOFggEvWa2/uvOlVrKqMf6o1td2IvuM7DmV+0NTMHA iFWw== X-Gm-Message-State: APjAAAVok55CJfLMJ+/91JPupkGLDAH8s8IlOBw1ImVRHDvJVh28yHUk cgm8zDdPOn2xZlNrkwd1WRdzxj3yoFU= X-Received: by 2002:a63:185a:: with SMTP id 26mr48540170pgy.337.1555403513627; Tue, 16 Apr 2019 01:31:53 -0700 (PDT) Received: from localhost.localdomain (rrcs-66-91-136-155.west.biz.rr.com. [66.91.136.155]) by smtp.gmail.com with ESMTPSA id m23sm76992727pfa.117.2019.04.16.01.31.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2019 01:31:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 15 Apr 2019 22:31:48 -1000 Message-Id: <20190416083150.19649-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52f Subject: [Qemu-devel] [PATCH 0/2] tcg: Fix launchpad 1824853 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This is a case where we generate more than 64k code for a mere 231 guest instructions. This hits some assertions within TCG that we're not overflowing the uint16_t that we use for representing our unwind info. Fix this by returning an error indication, rather than asserting. This lets us try again from tb_gen_code with a lower max_insns. This should resolve the problem for x86 as a host. There are other failure modes wrt out-of-range relocations that might affect the RISC hosts. I'm going to leave those for a different patch set. r~ Richard Henderson (2): tcg: Hoist max_insns computation to tb_gen_code tcg: Restart after TB code generation overflow include/exec/exec-all.h | 4 +-- include/exec/translator.h | 3 +- accel/tcg/translate-all.c | 54 +++++++++++++++++++++++++++++------ accel/tcg/translator.c | 15 ++-------- target/alpha/translate.c | 4 +-- target/arm/translate.c | 4 +-- target/cris/translate.c | 10 +------ target/hppa/translate.c | 5 ++-- target/i386/translate.c | 4 +-- target/lm32/translate.c | 10 +------ target/m68k/translate.c | 4 +-- target/microblaze/translate.c | 10 +------ target/mips/translate.c | 4 +-- target/moxie/translate.c | 11 ++----- target/nios2/translate.c | 14 ++------- target/openrisc/translate.c | 4 +-- target/ppc/translate.c | 4 +-- target/riscv/translate.c | 4 +-- target/s390x/translate.c | 4 +-- target/sh4/translate.c | 4 +-- target/sparc/translate.c | 4 +-- target/tilegx/translate.c | 12 +------- target/tricore/translate.c | 16 ++--------- target/unicore32/translate.c | 10 +------ target/xtensa/translate.c | 4 +-- tcg/tcg.c | 4 +++ 26 files changed, 93 insertions(+), 133 deletions(-) -- 2.17.1 Reviewed-by: Philippe Mathieu-Daudé