mbox series

[v2,0/8] exec: Cleanup watchpoints

Message ID 20190828231651.17176-1-richard.henderson@linaro.org
Headers show
Series exec: Cleanup watchpoints | expand

Message

Richard Henderson Aug. 28, 2019, 11:16 p.m. UTC 
Changes from v1:
  * Split out some minor fixes to separate patches.
  * Reload tlb_addr2 after tlb_fill for page2 in patch 7.

Blurb from v1:
As discussed with David earlier this week, the current implementation
of watchpoints cannot work, at least reliably.  We are raising an
exception out of the middle of the i/o access path which does not
even attempt to unwind the guest cpu state, nor does it have the
information required to do so.

This moves the implementation to the cputlb helpers.  This is a point
at which we can and do raise exceptions properly.

In addition, this fixes a bug in that unaligned stores were detecting
watchpoints in the middle of the byte-by-byte operation, which means
that we didn't signal the watchpoint early enough to avoid state change.


r~


David Hildenbrand (2):
  exec: Factor out core logic of check_watchpoint()
  tcg: Check for watchpoints in probe_write()

Richard Henderson (6):
  exec: Move user-only watchpoint stubs inline
  cputlb: Fold TLB_RECHECK into TLB_INVALID_MASK
  exec: Factor out cpu_watchpoint_address_matches
  cputlb: Fix size operand for tlb_fill on unaligned store
  cputlb: Remove double-alignment in store_helper
  cputlb: Handle watchpoints via TLB_WATCHPOINT

 include/exec/cpu-all.h |   8 +-
 include/hw/core/cpu.h  |  37 +++++++++
 accel/tcg/cputlb.c     | 166 +++++++++++++++++++++++++---------------
 exec.c                 | 167 +++++++++--------------------------------
 4 files changed, 179 insertions(+), 199 deletions(-)

-- 
2.17.1