| Message ID | 20200918132903.1848939-1-berrange@redhat.com |
|---|---|
| Headers | show |
| Series | gitlab: add jobs for checking paches | expand |
Patchew URL: https://patchew.org/QEMU/20200918132903.1848939-1-berrange@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200918132903.1848939-1-berrange@redhat.com/testing.FreeBSD/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200918132903.1848939-1-berrange@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200918132903.1848939-1-berrange@redhat.com/testing.FreeBSD/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 18/09/2020 15.29, Daniel P. Berrangé wrote: > This introduces two new jobs to GitLab. The first runs "checkpatch.pl" > across all patches, while the second is a dedicated DCO signoff check. This feels quite redundant since we're checking the patches with Patchew already ... or are there plans to get rid of this check in Patchew? Thomas
On 9/18/20 4:07 PM, Thomas Huth wrote: > On 18/09/2020 15.29, Daniel P. Berrangé wrote: >> This introduces two new jobs to GitLab. The first runs "checkpatch.pl" >> across all patches, while the second is a dedicated DCO signoff check. > > This feels quite redundant since we're checking the patches with Patchew > already ... or are there plans to get rid of this check in Patchew? The plan is to use GitLab-CI gating :) Also this free patchew community resources and use the user's resources instead. From a patchew sysadmin PoV this is a win IMO. > > Thomas >
On Fri, Sep 18, 2020 at 04:07:22PM +0200, Thomas Huth wrote: > On 18/09/2020 15.29, Daniel P. Berrangé wrote: > > This introduces two new jobs to GitLab. The first runs "checkpatch.pl" > > across all patches, while the second is a dedicated DCO signoff check. > > This feels quite redundant since we're checking the patches with Patchew > already ... or are there plans to get rid of this check in Patchew? patchew only runs once the contributor has sent their patches to the mailing list, whci his too late. We want contributors to test their series in GitLab CI ahead of sending it, so that patchew never has to report any failure, because the code is already perfect once on the list (except if git master has moved and causes conflicts of course). Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Fri, Sep 18, 2020 at 10:16 PM Daniel P. Berrangé <berrange@redhat.com> wrote: > > On Fri, Sep 18, 2020 at 04:07:22PM +0200, Thomas Huth wrote: > > On 18/09/2020 15.29, Daniel P. Berrangé wrote: > > > This introduces two new jobs to GitLab. The first runs "checkpatch.pl" > > > across all patches, while the second is a dedicated DCO signoff check. > > > > This feels quite redundant since we're checking the patches with Patchew > > already ... or are there plans to get rid of this check in Patchew? > > patchew only runs once the contributor has sent their patches to the > mailing list, whci his too late. > > We want contributors to test their series in GitLab CI ahead of sending > it, so that patchew never has to report any failure, because the code is > already perfect once on the list (except if git master has moved and > causes conflicts of course). > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > > agreed, and ineed patchew are broken now. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo <div dir="ltr"><br><br>On Fri, Sep 18, 2020 at 10:16 PM Daniel P. Berrangé <<a href="mailto:berrange@redhat.com">berrange@redhat.com</a>> wrote:<br>><br>> On Fri, Sep 18, 2020 at 04:07:22PM +0200, Thomas Huth wrote:<br>> > On 18/09/2020 15.29, Daniel P. Berrangé wrote:<br>> > > This introduces two new jobs to GitLab. The first runs "<a href="http://checkpatch.pl">checkpatch.pl</a>"<br>> > > across all patches, while the second is a dedicated DCO signoff check.<br>> ><br>> > This feels quite redundant since we're checking the patches with Patchew<br>> > already ... or are there plans to get rid of this check in Patchew?<br>><br>> patchew only runs once the contributor has sent their patches to the<br>> mailing list, whci his too late.<br>><br>> We want contributors to test their series in GitLab CI ahead of sending<br>> it, so that patchew never has to report any failure, because the code is<br>> already perfect once on the list (except if git master has moved and<br>> causes conflicts of course).<br>><br>> Regards,<br>> Daniel<br>> --<br>> |: <a href="https://berrange.com">https://berrange.com</a> -o- <a href="https://www.flickr.com/photos/dberrange">https://www.flickr.com/photos/dberrange</a> :|<br>> |: <a href="https://libvirt.org">https://libvirt.org</a> -o- <a href="https://fstop138.berrange.com">https://fstop138.berrange.com</a> :|<br>> |: <a href="https://entangle-photo.org">https://entangle-photo.org</a> -o- <a href="https://www.instagram.com/dberrange">https://www.instagram.com/dberrange</a> :|<br>><br>><br>agreed, and ineed patchew are broken now.<br><br>--<br> 此致<br>礼<br>罗勇刚<br>Yours<br> sincerely,<br>Yonggang Luo</div>
Patchew URL: https://patchew.org/QEMU/20200918132903.1848939-1-berrange@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is available at http://patchew.org/logs/20200918132903.1848939-1-berrange@redhat.com/testing.docker-quick@centos7/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com